summaryrefslogtreecommitdiffstats
path: root/src/com/android/settings/development/ForceMSAAPreferenceController.java
diff options
context:
space:
mode:
authorDoris Ling <dling@google.com>2018-03-01 10:33:14 -0800
committerDoris Ling <dling@google.com>2018-03-01 13:58:29 -0800
commit4fbf04cd1056928d1f2ef3c648b11112f80915de (patch)
treec32fb672c94d1543bb888f4b4499d5f92f238d36 /src/com/android/settings/development/ForceMSAAPreferenceController.java
parent46d6ecc2b186245785dfaa7936c0723b6ebb91a0 (diff)
downloadpackages_apps_Settings-4fbf04cd1056928d1f2ef3c648b11112f80915de.tar.gz
packages_apps_Settings-4fbf04cd1056928d1f2ef3c648b11112f80915de.tar.bz2
packages_apps_Settings-4fbf04cd1056928d1f2ef3c648b11112f80915de.zip
Remove unnecessary onDeveloperOptionsSwitchEnabled/Disabled override.
- default implementation has been added in the super class to handle enabling/disabling the preference when the master developer options switch it turned on/off. Removing all subclass that originally implemented the methods that only contains the default behavior. Bug: 73955632 Test: make RunSettingsRoboTests Change-Id: I13c372c2ab498a5786b40cdc1ad3b5f3424abb5a
Diffstat (limited to 'src/com/android/settings/development/ForceMSAAPreferenceController.java')
-rw-r--r--src/com/android/settings/development/ForceMSAAPreferenceController.java21
1 files changed, 3 insertions, 18 deletions
diff --git a/src/com/android/settings/development/ForceMSAAPreferenceController.java b/src/com/android/settings/development/ForceMSAAPreferenceController.java
index 2d2fd956bd..4fd1f3b0a9 100644
--- a/src/com/android/settings/development/ForceMSAAPreferenceController.java
+++ b/src/com/android/settings/development/ForceMSAAPreferenceController.java
@@ -21,7 +21,6 @@ import android.os.SystemProperties;
import android.support.annotation.VisibleForTesting;
import android.support.v14.preference.SwitchPreference;
import android.support.v7.preference.Preference;
-import android.support.v7.preference.PreferenceScreen;
import com.android.settings.core.PreferenceControllerMixin;
import com.android.settingslib.development.DeveloperOptionsPreferenceController;
@@ -35,8 +34,6 @@ public class ForceMSAAPreferenceController extends DeveloperOptionsPreferenceCon
@VisibleForTesting
static final String MSAA_PROPERTY = "debug.egl.force_msaa";
- private SwitchPreference mPreference;
-
public ForceMSAAPreferenceController(Context context) {
super(context);
}
@@ -47,13 +44,6 @@ public class ForceMSAAPreferenceController extends DeveloperOptionsPreferenceCon
}
@Override
- public void displayPreference(PreferenceScreen screen) {
- super.displayPreference(screen);
-
- mPreference = (SwitchPreference) screen.findPreference(getPreferenceKey());
- }
-
- @Override
public boolean onPreferenceChange(Preference preference, Object newValue) {
final boolean isEnabled = (Boolean) newValue;
SystemProperties.set(MSAA_PROPERTY,
@@ -65,18 +55,13 @@ public class ForceMSAAPreferenceController extends DeveloperOptionsPreferenceCon
@Override
public void updateState(Preference preference) {
final boolean isEnabled = SystemProperties.getBoolean(MSAA_PROPERTY, false /* default */);
- mPreference.setChecked(isEnabled);
- }
-
- @Override
- protected void onDeveloperOptionsSwitchEnabled() {
- mPreference.setEnabled(true);
+ ((SwitchPreference) mPreference).setChecked(isEnabled);
}
@Override
protected void onDeveloperOptionsSwitchDisabled() {
+ super.onDeveloperOptionsSwitchDisabled();
SystemProperties.set(MSAA_PROPERTY, Boolean.toString(false));
- mPreference.setChecked(false);
- mPreference.setEnabled(false);
+ ((SwitchPreference) mPreference).setChecked(false);
}
}