diff options
| author | Hugh Chen <hughchen@google.com> | 2020-11-12 16:56:15 +0800 |
|---|---|---|
| committer | Hugh Chen <hughchen@google.com> | 2020-11-24 17:54:48 +0800 |
| commit | 8f29850cca776b6a2ae1f11155c50dc4ef9ab89a (patch) | |
| tree | f1727c09749d9fd5501d0ce3fe5a91284dbb49c4 /src/com/android/settings/connecteddevice/PreviouslyConnectedDevicePreferenceController.java | |
| parent | b6bba3e9a20756c582bfe4d5e135b833e7df2fd4 (diff) | |
| download | packages_apps_Settings-8f29850cca776b6a2ae1f11155c50dc4ef9ab89a.tar.gz packages_apps_Settings-8f29850cca776b6a2ae1f11155c50dc4ef9ab89a.tar.bz2 packages_apps_Settings-8f29850cca776b6a2ae1f11155c50dc4ef9ab89a.zip | |
Fix crash on connected devices settings
If disconnected bluetooth devices didn't exist in
recent devices, the index will return -1. Our condition
didn't check this situation, the IndexOutOfBoundsException
will throw when this case happens.
This CL adds the condition to check whether index is over
than or equal 0 to fix IndexOutOfBoundsException.
Bug: 173059077
Test: make -j42 RunSettingsRoboTests
Change-Id: Id93f4cb6bded83540045c5e8c21c6f6122a39fed
Diffstat (limited to 'src/com/android/settings/connecteddevice/PreviouslyConnectedDevicePreferenceController.java')
| -rw-r--r-- | src/com/android/settings/connecteddevice/PreviouslyConnectedDevicePreferenceController.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/com/android/settings/connecteddevice/PreviouslyConnectedDevicePreferenceController.java b/src/com/android/settings/connecteddevice/PreviouslyConnectedDevicePreferenceController.java index 438a3815f9..a7bae3b863 100644 --- a/src/com/android/settings/connecteddevice/PreviouslyConnectedDevicePreferenceController.java +++ b/src/com/android/settings/connecteddevice/PreviouslyConnectedDevicePreferenceController.java @@ -144,7 +144,7 @@ public class PreviouslyConnectedDevicePreferenceController extends BasePreferenc private void addPreference(int index, Preference preference) { if (preference instanceof BluetoothDevicePreference) { - if (mDevicesList.size() >= index) { + if (index >= 0 && mDevicesList.size() >= index) { mDevicesList.add(index, preference); } else { mDevicesList.add(preference); |