diff options
author | hjchangliao <hjchangliao@google.com> | 2018-05-02 16:57:20 +0800 |
---|---|---|
committer | hjchangliao <hjchangliao@google.com> | 2018-05-16 16:05:41 +0800 |
commit | 2f73a6646f4709bff865826c0ea41fcb6f13e3c4 (patch) | |
tree | 16dd68158ba353a64863de674488abc453998f67 /src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java | |
parent | 5de68ea81a646453d66c64f0b16ae8b5c5f173b4 (diff) | |
download | packages_apps_Settings-2f73a6646f4709bff865826c0ea41fcb6f13e3c4.tar.gz packages_apps_Settings-2f73a6646f4709bff865826c0ea41fcb6f13e3c4.tar.bz2 packages_apps_Settings-2f73a6646f4709bff865826c0ea41fcb6f13e3c4.zip |
Convert Magnify controller to TogglePrefController
Convert below to TogglePreferenceController:
MagnificationNavbarPreferenceController
(Magnify with Button)
MagnificationGesturesPreferenceController
(Magnify with triple-tap)
The two controllers share the same fragment,
Add static method for set/get state in fragment,
And use them in controllers and fragment.
Change-Id: I2bdbdb36be71e1a3ffb557abc5a6115d48de53cf
Fixes: 67997698
Fixes: 67997726
Test: make RunSettingsRoboTests
Diffstat (limited to 'src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java')
-rw-r--r-- | src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java | 23 |
1 files changed, 16 insertions, 7 deletions
diff --git a/src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java b/src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java index 89bb7753f9..9bfc05ade4 100644 --- a/src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java +++ b/src/com/android/settings/accessibility/MagnificationGesturesPreferenceController.java @@ -19,9 +19,9 @@ import android.provider.Settings; import androidx.preference.Preference; import com.android.settings.R; -import com.android.settings.core.BasePreferenceController; +import com.android.settings.core.TogglePreferenceController; -public class MagnificationGesturesPreferenceController extends BasePreferenceController { +public class MagnificationGesturesPreferenceController extends TogglePreferenceController { private boolean mIsFromSUW = false; @@ -29,6 +29,18 @@ public class MagnificationGesturesPreferenceController extends BasePreferenceCon super(context, key); } + @Override + public boolean isChecked() { + return MagnificationPreferenceFragment.isChecked(mContext.getContentResolver(), + Settings.Secure.ACCESSIBILITY_DISPLAY_MAGNIFICATION_ENABLED); + } + + @Override + public boolean setChecked(boolean isChecked) { + return MagnificationPreferenceFragment.setChecked(mContext.getContentResolver(), + Settings.Secure.ACCESSIBILITY_DISPLAY_MAGNIFICATION_ENABLED, isChecked); + } + public void setIsFromSUW(boolean fromSUW) { mIsFromSUW = fromSUW; } @@ -38,6 +50,7 @@ public class MagnificationGesturesPreferenceController extends BasePreferenceCon if (getPreferenceKey().equals(preference.getKey())) { Bundle extras = preference.getExtras(); populateMagnificationGesturesPreferenceExtras(extras, mContext); + extras.putBoolean(AccessibilitySettings.EXTRA_CHECKED, isChecked()); extras.putBoolean(AccessibilitySettings.EXTRA_LAUNCHED_FROM_SUW, mIsFromSUW); } return false; @@ -54,8 +67,7 @@ public class MagnificationGesturesPreferenceController extends BasePreferenceCon if (mIsFromSUW) { resId = R.string.accessibility_screen_magnification_short_summary; } else { - final boolean enabled = Settings.Secure.getInt(mContext.getContentResolver(), - Settings.Secure.ACCESSIBILITY_DISPLAY_MAGNIFICATION_ENABLED, 0) == 1; + final boolean enabled = isChecked(); resId = (enabled ? R.string.accessibility_feature_state_on : R.string.accessibility_feature_state_off); } @@ -69,9 +81,6 @@ public class MagnificationGesturesPreferenceController extends BasePreferenceCon R.string.accessibility_screen_magnification_gestures_title); extras.putInt(AccessibilitySettings.EXTRA_SUMMARY_RES, R.string.accessibility_screen_magnification_summary); - extras.putBoolean(AccessibilitySettings.EXTRA_CHECKED, - Settings.Secure.getInt(context.getContentResolver(), - Settings.Secure.ACCESSIBILITY_DISPLAY_MAGNIFICATION_ENABLED, 0) == 1); extras.putInt(AccessibilitySettings.EXTRA_VIDEO_RAW_RESOURCE_ID, R.raw.accessibility_screen_magnification); } |