summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTreeHugger Robot <treehugger-gerrit@google.com>2019-09-23 15:07:13 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2019-09-23 15:07:13 +0000
commit5ff9517f23af0299af5b4ca9959923f79cde512a (patch)
tree3e1e4e8d68d8e9dc4296530916e509e42187647e
parent93343d0ccdbe7a6ed22ab4ac6555cad1ff8473e9 (diff)
parent78db757cad6ca72d10ad865603b1e960d90c3cd2 (diff)
downloadpackages_apps_Settings-5ff9517f23af0299af5b4ca9959923f79cde512a.tar.gz
packages_apps_Settings-5ff9517f23af0299af5b4ca9959923f79cde512a.tar.bz2
packages_apps_Settings-5ff9517f23af0299af5b4ca9959923f79cde512a.zip
Merge "Developer option off must not affect laser sensor"
-rw-r--r--src/com/android/settings/development/CameraLaserSensorPreferenceController.java9
-rw-r--r--tests/robotests/src/com/android/settings/development/CameraLaserSensorPreferenceControllerTest.java12
2 files changed, 3 insertions, 18 deletions
diff --git a/src/com/android/settings/development/CameraLaserSensorPreferenceController.java b/src/com/android/settings/development/CameraLaserSensorPreferenceController.java
index ec0ca24b6e..6717280953 100644
--- a/src/com/android/settings/development/CameraLaserSensorPreferenceController.java
+++ b/src/com/android/settings/development/CameraLaserSensorPreferenceController.java
@@ -75,12 +75,9 @@ public class CameraLaserSensorPreferenceController extends DeveloperOptionsPrefe
((SwitchPreference) mPreference).setChecked(enabled);
}
- @Override
- protected void onDeveloperOptionsSwitchDisabled() {
- super.onDeveloperOptionsSwitchDisabled();
- SystemProperties.set(PROPERTY_CAMERA_LASER_SENSOR, Integer.toString(DISABLED));
- ((SwitchPreference) mPreference).setChecked(false);
- }
+ // There should be no impact on the current
+ // laser sensor settings in case the developer
+ // settings switch is turned on or off!
private boolean isLaserSensorEnabled() {
final String prop = SystemProperties.get(PROPERTY_CAMERA_LASER_SENSOR,
diff --git a/tests/robotests/src/com/android/settings/development/CameraLaserSensorPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/development/CameraLaserSensorPreferenceControllerTest.java
index aa9cb46db1..d469c7193b 100644
--- a/tests/robotests/src/com/android/settings/development/CameraLaserSensorPreferenceControllerTest.java
+++ b/tests/robotests/src/com/android/settings/development/CameraLaserSensorPreferenceControllerTest.java
@@ -128,16 +128,4 @@ public class CameraLaserSensorPreferenceControllerTest {
CameraLaserSensorPreferenceController.PROPERTY_CAMERA_LASER_SENSOR,
Integer.toString(CameraLaserSensorPreferenceController.ENABLED)));
}
-
- @Test
- public void onDeveloperOptionsSwitchDisabled_preferenceShouldBeEnabled() {
- mController.onDeveloperOptionsSwitchDisabled();
-
- verify(mPreference).setEnabled(false);
- verify(mPreference).setChecked(false);
- assertThat(Integer.toString(CameraLaserSensorPreferenceController.DISABLED)).isEqualTo(
- SystemProperties.get(
- CameraLaserSensorPreferenceController.PROPERTY_CAMERA_LASER_SENSOR,
- Integer.toString(CameraLaserSensorPreferenceController.ENABLED)));
- }
}