diff options
author | Edgar Wang <edgarwang@google.com> | 2020-02-06 11:40:42 +0800 |
---|---|---|
committer | Edgar Wang <edgarwang@google.com> | 2020-02-06 19:07:11 +0800 |
commit | 0934babbfcefc02776d4e7c4a08e5a40435c9e5d (patch) | |
tree | 58f808eb00632ccfd279dfc47c01a684950bf21b | |
parent | 43190bf92bded261775c9400c0a9746136b8c8cc (diff) | |
download | packages_apps_Settings-0934babbfcefc02776d4e7c4a08e5a40435c9e5d.tar.gz packages_apps_Settings-0934babbfcefc02776d4e7c4a08e5a40435c9e5d.tar.bz2 packages_apps_Settings-0934babbfcefc02776d4e7c4a08e5a40435c9e5d.zip |
Make the fragment title can’t searchable
we shouldn't take users so deep into the settings IA because it's easy
to feel lost in settings after clicking on a result without additional
context.
Bug: 143055215
Test: robotest & manual
Change-Id: I337cb5ead31e1e4e7bf9be78132e90630f83ee43
151 files changed, 129 insertions, 530 deletions
diff --git a/res/xml/about_legal.xml b/res/xml/about_legal.xml index 6c59cacb05..d30ceaa280 100644 --- a/res/xml/about_legal.xml +++ b/res/xml/about_legal.xml @@ -16,8 +16,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:title="@string/legal_information" - android:key="legal_screen"> + android:title="@string/legal_information"> <!-- Note: The titles given here probably won't be used. Instead, we programmatically fill the title with the label of the activity with the corresponding action. diff --git a/res/xml/accessibility_autoclick_settings.xml b/res/xml/accessibility_autoclick_settings.xml index 70cb9c844a..e400b284bc 100644 --- a/res/xml/accessibility_autoclick_settings.xml +++ b/res/xml/accessibility_autoclick_settings.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="autoclick_preference_screen" android:title="@string/accessibility_autoclick_preference_title"> <com.android.settingslib.widget.RadioButtonPreference diff --git a/res/xml/accessibility_color_inversion_settings.xml b/res/xml/accessibility_color_inversion_settings.xml index 9e31ff97ad..9681001053 100644 --- a/res/xml/accessibility_color_inversion_settings.xml +++ b/res/xml/accessibility_color_inversion_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="color_inversion_preference_screen" android:persistent="false" android:title="@string/accessibility_display_inversion_preference_title"> diff --git a/res/xml/accessibility_control_timeout_settings.xml b/res/xml/accessibility_control_timeout_settings.xml index 77bbfd8a67..0f14cd5c9c 100644 --- a/res/xml/accessibility_control_timeout_settings.xml +++ b/res/xml/accessibility_control_timeout_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="accessibility_control_timeout_preference" android:title="@string/accessibility_control_timeout_preference_title" android:persistent="false" > diff --git a/res/xml/accessibility_daltonizer_settings.xml b/res/xml/accessibility_daltonizer_settings.xml index 976f9123de..0d9911c984 100644 --- a/res/xml/accessibility_daltonizer_settings.xml +++ b/res/xml/accessibility_daltonizer_settings.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="daltonizer_preference_screen" android:persistent="false" android:title="@string/accessibility_display_daltonizer_preference_title"> diff --git a/res/xml/accessibility_magnification_settings.xml b/res/xml/accessibility_magnification_settings.xml index bb40394810..6731dbac6f 100644 --- a/res/xml/accessibility_magnification_settings.xml +++ b/res/xml/accessibility_magnification_settings.xml @@ -16,9 +16,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="magnification_preference_screen_title" - android:title="@string/accessibility_screen_magnification_title" - settings:searchable="false"> + android:title="@string/accessibility_screen_magnification_title"> <Preference android:fragment="com.android.settings.accessibility.ToggleScreenMagnificationPreferenceFragment" android:key="screen_magnification_gestures_preference_screen" diff --git a/res/xml/accessibility_settings.xml b/res/xml/accessibility_settings.xml index be644d45bf..b7b88edf70 100644 --- a/res/xml/accessibility_settings.xml +++ b/res/xml/accessibility_settings.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="accessibility_settings_screen" android:persistent="false" android:title="@string/accessibility_settings"> diff --git a/res/xml/accessibility_vibration_settings.xml b/res/xml/accessibility_vibration_settings.xml index dc2b16a084..87c2988ac2 100644 --- a/res/xml/accessibility_vibration_settings.xml +++ b/res/xml/accessibility_vibration_settings.xml @@ -18,7 +18,6 @@ xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="accessibility_settings_vibration_screen" android:title="@string/accessibility_vibration_settings_title"> <Preference diff --git a/res/xml/accounts_dashboard_settings.xml b/res/xml/accounts_dashboard_settings.xml index d2affc7284..c42e1c7b2f 100644 --- a/res/xml/accounts_dashboard_settings.xml +++ b/res/xml/accounts_dashboard_settings.xml @@ -17,9 +17,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="user_and_account_settings_screen" - android:title="@string/account_dashboard_title" - settings:keywords="@string/keywords_accounts"> + android:title="@string/account_dashboard_title"> <PreferenceCategory android:key="dashboard_tile_placeholder" diff --git a/res/xml/adaptive_sleep_detail.xml b/res/xml/adaptive_sleep_detail.xml index 4b46fae3fb..0ea31ff7d3 100644 --- a/res/xml/adaptive_sleep_detail.xml +++ b/res/xml/adaptive_sleep_detail.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="adaptive_sleep_detail" android:title="@string/adaptive_sleep_title"> <com.android.settings.widget.VideoPreference @@ -52,4 +51,4 @@ android:selectable="false" settings:searchable="false" /> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/app_and_notification.xml b/res/xml/app_and_notification.xml index f75bd8629a..aa1a6ee931 100644 --- a/res/xml/app_and_notification.xml +++ b/res/xml/app_and_notification.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="apps_and_notification_screen" android:title="@string/app_and_notification_dashboard_title" settings:initialExpandedChildrenCount="4"> <!-- the initial count should include the dynamic tiles --> diff --git a/res/xml/assist_gesture_settings.xml b/res/xml/assist_gesture_settings.xml index 7cbd483d12..5f7918f3f5 100644 --- a/res/xml/assist_gesture_settings.xml +++ b/res/xml/assist_gesture_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" - android:key="gesture_assist_settings_page" android:title="@string/assist_gesture_title"> <com.android.settings.widget.VideoPreference diff --git a/res/xml/auto_brightness_detail.xml b/res/xml/auto_brightness_detail.xml index 7c66ab5e26..6b304efcaf 100644 --- a/res/xml/auto_brightness_detail.xml +++ b/res/xml/auto_brightness_detail.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="auto_brightness_detail" android:title="@string/auto_brightness_title"> <com.android.settings.widget.VideoPreference @@ -45,4 +44,4 @@ android:selectable="false" settings:searchable="false" /> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/available_virtual_keyboard.xml b/res/xml/available_virtual_keyboard.xml index 9a0b3c62ab..6be06a2678 100644 --- a/res/xml/available_virtual_keyboard.xml +++ b/res/xml/available_virtual_keyboard.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - android:key="available_virtual_keyboard_page" android:title="@string/add_virtual_keyboard"> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/battery_saver_settings.xml b/res/xml/battery_saver_settings.xml index 0436105dce..6009f6ae3c 100644 --- a/res/xml/battery_saver_settings.xml +++ b/res/xml/battery_saver_settings.xml @@ -17,8 +17,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:title="@string/battery_saver" - android:key="battery_saver_page"> + android:title="@string/battery_saver"> <Preference android:key="battery_saver_schedule" diff --git a/res/xml/bluetooth_screen.xml b/res/xml/bluetooth_screen.xml index 2a52a7cf36..cce114bf5a 100644 --- a/res/xml/bluetooth_screen.xml +++ b/res/xml/bluetooth_screen.xml @@ -16,7 +16,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="bluetooth_switchbar_screen" android:title="@string/bluetooth_settings_title"> <Preference @@ -40,4 +39,4 @@ android:key="bluetooth_screen_footer" android:selectable="false" settings:searchable="false"/> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/captioning_appearance.xml b/res/xml/captioning_appearance.xml index 66b298d5b6..3e0e804e53 100644 --- a/res/xml/captioning_appearance.xml +++ b/res/xml/captioning_appearance.xml @@ -18,8 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:fragment="com.android.settings.accessibility.CaptionAppearanceFragment" - android:key="captioning_appearance_screen" android:title="@string/captioning_caption_appearance_title"> <com.android.settingslib.widget.LayoutPreference diff --git a/res/xml/captioning_more_options.xml b/res/xml/captioning_more_options.xml index 9e5a18a270..d4111d27d7 100644 --- a/res/xml/captioning_more_options.xml +++ b/res/xml/captioning_more_options.xml @@ -18,8 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:fragment="com.android.settings.accessibility.CaptionMoreOptionsFragment" - android:key="captioning_more_options_screen" android:title="@string/captioning_more_options_title" > <com.android.settings.accessibility.LocalePreference diff --git a/res/xml/captioning_settings.xml b/res/xml/captioning_settings.xml index 1a8ed5505b..c8cb46c023 100644 --- a/res/xml/captioning_settings.xml +++ b/res/xml/captioning_settings.xml @@ -18,8 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:fragment="com.android.settings.accessibility.CaptionPropertiesFragment" - android:key="captioning_preference_screen" android:title="@string/accessibility_captioning_title" > <SwitchPreference diff --git a/res/xml/color_mode_settings.xml b/res/xml/color_mode_settings.xml index b7f58d2ea0..6044141c71 100644 --- a/res/xml/color_mode_settings.xml +++ b/res/xml/color_mode_settings.xml @@ -17,5 +17,4 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - android:key="color_mode_settings_screen" android:title="@string/color_mode_title" /> diff --git a/res/xml/configure_notification_settings.xml b/res/xml/configure_notification_settings.xml index 6e8f701704..021705703c 100644 --- a/res/xml/configure_notification_settings.xml +++ b/res/xml/configure_notification_settings.xml @@ -16,8 +16,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:title="@string/configure_notification_settings" - android:key="configure_notification_settings"> + android:title="@string/configure_notification_settings"> <com.android.settings.widget.VideoPreference android:key="notification_model_illustration" diff --git a/res/xml/connected_devices.xml b/res/xml/connected_devices.xml index 0e5afc349e..444b35cbd2 100644 --- a/res/xml/connected_devices.xml +++ b/res/xml/connected_devices.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="connected_devices_screen" android:title="@string/connected_devices_dashboard_title"> <com.android.settings.slices.SlicePreference @@ -57,6 +56,7 @@ android:title="@string/previous_connected_see_all" android:icon="@drawable/ic_chevron_right_24dp" android:order="10" + settings:searchable="false" android:fragment="com.android.settings.connecteddevice.PreviouslyConnectedDeviceDashboardFragment"/> </PreferenceCategory> diff --git a/res/xml/connected_devices_advanced.xml b/res/xml/connected_devices_advanced.xml index f5cef7ef5f..ba623807f4 100644 --- a/res/xml/connected_devices_advanced.xml +++ b/res/xml/connected_devices_advanced.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="connected_devices_advanced_screen" android:title="@string/connected_device_connections_title"> <Preference @@ -25,8 +24,7 @@ android:key="bluetooth_settings" android:title="@string/bluetooth_settings_title" android:icon="@*android:drawable/ic_settings_bluetooth" - android:order="-9" - settings:searchable="false"/> + android:order="-9"/> <Preference android:fragment="com.android.settings.connecteddevice.NfcAndPaymentFragment" @@ -42,7 +40,6 @@ android:title="@string/wifi_display_settings_title" android:icon="@drawable/ic_cast_24dp" android:order="-6" - settings:searchable="false" settings:controller="com.android.settings.wfd.WifiDisplayPreferenceController"/> <com.android.settingslib.RestrictedPreference @@ -59,8 +56,7 @@ android:summary="@string/summary_placeholder" android:icon="@*android:drawable/ic_settings_print" android:fragment="com.android.settings.print.PrintSettingsFragment" - android:order="-3" - settings:searchable="false"/> + android:order="-3"/> <Preference android:key="bt_received_files" diff --git a/res/xml/dark_mode_settings.xml b/res/xml/dark_mode_settings.xml index cf91186122..a5f03d22ac 100644 --- a/res/xml/dark_mode_settings.xml +++ b/res/xml/dark_mode_settings.xml @@ -18,7 +18,6 @@ xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" android:title="@string/dark_ui_mode" - android:key="dark_ui_mode_screen" settings:keywords="@string/keywords_dark_ui_mode"> <DropDownPreference @@ -56,4 +55,4 @@ settings:searchable="false" settings:allowDividerAbove="true"/> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/data_saver.xml b/res/xml/data_saver.xml index e884d6d68c..4a917f621a 100644 --- a/res/xml/data_saver.xml +++ b/res/xml/data_saver.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="data_saver_screen" android:title="@string/data_saver_title"> <Preference diff --git a/res/xml/date_time_prefs.xml b/res/xml/date_time_prefs.xml index a1e512fac8..20fac4547f 100644 --- a/res/xml/date_time_prefs.xml +++ b/res/xml/date_time_prefs.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="date_time_settings_screen" android:title="@string/date_and_time" settings:keywords="@string/keywords_date_and_time"> diff --git a/res/xml/development_settings.xml b/res/xml/development_settings.xml index ff6640cc1c..a49d85b9f0 100644 --- a/res/xml/development_settings.xml +++ b/res/xml/development_settings.xml @@ -125,8 +125,7 @@ <Preference android:key="quick_settings_tiles" android:title="@string/quick_settings_developer_tiles" - android:fragment="com.android.settings.development.qstile.DevelopmentTileConfigFragment" - settings:searchable="false" /> + android:fragment="com.android.settings.development.qstile.DevelopmentTileConfigFragment" /> </PreferenceCategory> <PreferenceCategory @@ -208,8 +207,7 @@ <Preference android:key="feature_flags_dashboard" android:title="@string/feature_flags_dashboard_title" - android:fragment="com.android.settings.development.featureflags.FeatureFlagsDashboard" - settings:searchable="false" /> + android:fragment="com.android.settings.development.featureflags.FeatureFlagsDashboard" /> <SwitchPreference android:key="enable_gpu_debug_layers" @@ -220,8 +218,7 @@ android:key="graphics_driver_dashboard" android:title="@string/graphics_driver_dashboard_title" android:summary="@string/graphics_driver_dashboard_summary" - android:fragment="com.android.settings.development.gamedriver.GameDriverDashboard" - settings:searchable="false" /> + android:fragment="com.android.settings.development.gamedriver.GameDriverDashboard" /> <Preference android:key="platform_compat_dashboard" diff --git a/res/xml/development_tile_settings.xml b/res/xml/development_tile_settings.xml index 3ce66947ee..e5bfbbf80c 100644 --- a/res/xml/development_tile_settings.xml +++ b/res/xml/development_tile_settings.xml @@ -18,6 +18,5 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="development_tile_settings" android:title="@string/quick_settings_developer_tiles" settings:controller="com.android.settings.development.qstile.DevelopmentTilePreferenceController" /> diff --git a/res/xml/device_admin_settings.xml b/res/xml/device_admin_settings.xml index 1837251455..9a48761ab1 100644 --- a/res/xml/device_admin_settings.xml +++ b/res/xml/device_admin_settings.xml @@ -19,7 +19,6 @@ xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" android:title="@string/manage_device_admin" - android:key="device_admin_settings" settings:controller="com.android.settings.applications.specialaccess.deviceadmin.DeviceAdminListPreferenceController"> <com.android.settingslib.widget.FooterPreference @@ -27,4 +26,4 @@ android:title="@string/no_device_admins" android:selectable="false" settings:searchable="false"/> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/display_settings.xml b/res/xml/display_settings.xml index 9bc6710845..4bf0c823ed 100644 --- a/res/xml/display_settings.xml +++ b/res/xml/display_settings.xml @@ -17,9 +17,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="display_settings_screen" android:title="@string/display_settings" - settings:keywords="@string/keywords_display" settings:initialExpandedChildrenCount="5"> <com.android.settingslib.RestrictedPreference @@ -37,8 +35,7 @@ android:fragment="com.android.settings.display.darkmode.DarkModeSettingsFragment" android:widgetLayout="@null" settings:widgetLayout="@null" - settings:controller="com.android.settings.display.DarkUIPreferenceController" - settings:searchable="false"/> + settings:controller="com.android.settings.display.DarkUIPreferenceController"/> <com.android.settings.display.NightDisplayPreference android:key="night_display" @@ -107,8 +104,7 @@ <com.android.settings.display.ScreenZoomPreference android:key="display_settings_screen_zoom" android:title="@string/screen_zoom_title" - android:fragment="com.android.settings.display.ScreenZoomSettings" - settings:searchable="false"/> + android:fragment="com.android.settings.display.ScreenZoomSettings"/> <SwitchPreference android:key="show_operator_name" @@ -118,13 +114,13 @@ <Preference android:key="screensaver" android:title="@string/screensaver_settings_title" - android:fragment="com.android.settings.dream.DreamSettings" - settings:searchable="false" /> + android:fragment="com.android.settings.dream.DreamSettings" /> <Preference android:key="lockscreen_from_display_settings" android:title="@string/lockscreen_settings_title" android:fragment="com.android.settings.security.LockscreenDashboardFragment" + settings:keywords="@string/keywords_ambient_display_screen" settings:controller="com.android.settings.security.screenlock.LockScreenPreferenceController" /> <SwitchPreference diff --git a/res/xml/double_tap_power_settings.xml b/res/xml/double_tap_power_settings.xml index c04a90bd6a..cb7bcbe37f 100644 --- a/res/xml/double_tap_power_settings.xml +++ b/res/xml/double_tap_power_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" - android:key="gesture_double_tap_power_screen" android:title="@string/double_tap_power_for_camera_title"> <com.android.settings.widget.VideoPreference @@ -34,4 +33,4 @@ app:controller="com.android.settings.gestures.DoubleTapPowerPreferenceController" app:allowDividerAbove="true" /> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/double_tap_screen_settings.xml b/res/xml/double_tap_screen_settings.xml index 2734143c06..e9eeb3adaf 100644 --- a/res/xml/double_tap_screen_settings.xml +++ b/res/xml/double_tap_screen_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" - android:key="gesture_double_tap_screen_screen" android:title="@string/ambient_display_title"> <com.android.settings.widget.VideoPreference @@ -34,4 +33,4 @@ app:controller="com.android.settings.gestures.DoubleTapScreenPreferenceController" app:allowDividerAbove="true" /> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/double_twist_gesture_settings.xml b/res/xml/double_twist_gesture_settings.xml index f91bd350b0..ad82df3f07 100644 --- a/res/xml/double_twist_gesture_settings.xml +++ b/res/xml/double_twist_gesture_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" - android:key="gesture_double_twist_screen" android:title="@string/double_twist_for_camera_mode_title"> <com.android.settings.widget.VideoPreference @@ -34,4 +33,4 @@ app:controller="com.android.settings.gestures.DoubleTwistPreferenceController" app:allowDividerAbove="true" /> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/dream_fragment_overview.xml b/res/xml/dream_fragment_overview.xml index e4c2eb5365..3cb49f9cce 100644 --- a/res/xml/dream_fragment_overview.xml +++ b/res/xml/dream_fragment_overview.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="dream_overview_screen" android:title="@string/screensaver_settings_title"> <com.android.settings.widget.GearPreference @@ -41,4 +40,4 @@ android:layout="@layout/dream_start_button" /> </PreferenceCategory> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/encryption_and_credential.xml b/res/xml/encryption_and_credential.xml index f7e7184036..b0906c1646 100644 --- a/res/xml/encryption_and_credential.xml +++ b/res/xml/encryption_and_credential.xml @@ -17,8 +17,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:title="@string/encryption_and_credential_settings_title" - android:key="encryption_and_credentials_screen"> + android:title="@string/encryption_and_credential_settings_title"> <PreferenceCategory android:key="encryption_and_credentials_status_category" diff --git a/res/xml/enterprise_privacy_settings.xml b/res/xml/enterprise_privacy_settings.xml index e0631df918..aebd130de2 100644 --- a/res/xml/enterprise_privacy_settings.xml +++ b/res/xml/enterprise_privacy_settings.xml @@ -16,7 +16,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="enterprise_privacy_settings" android:title="@string/enterprise_privacy_settings"> <PreferenceCategory android:key="exposure_category" diff --git a/res/xml/enterprise_set_default_apps_settings.xml b/res/xml/enterprise_set_default_apps_settings.xml index 474a5c9276..92a38f987a 100644 --- a/res/xml/enterprise_set_default_apps_settings.xml +++ b/res/xml/enterprise_set_default_apps_settings.xml @@ -16,8 +16,7 @@ --> <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="enterprise_set_default_apps_settings"> + xmlns:settings="http://schemas.android.com/apk/res-auto"> <PreferenceCategory android:key="dashboard_tile_placeholder"/> </PreferenceScreen> diff --git a/res/xml/feature_flags_settings.xml b/res/xml/feature_flags_settings.xml index 0e509a8c0f..a6cc0a9025 100644 --- a/res/xml/feature_flags_settings.xml +++ b/res/xml/feature_flags_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="feature_flags_settings" android:title="@string/feature_flags_dashboard_title"> <PreferenceCategory android:key="feature_flag_category" diff --git a/res/xml/firmware_version.xml b/res/xml/firmware_version.xml index 443ae35dd2..88b02a0f93 100644 --- a/res/xml/firmware_version.xml +++ b/res/xml/firmware_version.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="firmware_version_screen" android:title="@string/firmware_version" settings:keywords="@string/keywords_android_version"> diff --git a/res/xml/gestures.xml b/res/xml/gestures.xml index ff3a6b52c8..5ac27e0b01 100644 --- a/res/xml/gestures.xml +++ b/res/xml/gestures.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="gesture_settings_screen" android:title="@string/gesture_preference_title"> <Preference diff --git a/res/xml/global_actions_panel_settings.xml b/res/xml/global_actions_panel_settings.xml index 2dc0fe9a04..3b7bef3f57 100644 --- a/res/xml/global_actions_panel_settings.xml +++ b/res/xml/global_actions_panel_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" - android:key="gesture_global_actions_panel" android:title="@string/global_actions_panel_title"> <com.android.settings.widget.VideoPreference diff --git a/res/xml/graphics_driver_settings.xml b/res/xml/graphics_driver_settings.xml index e4aa04ed9c..bc2759fd91 100644 --- a/res/xml/graphics_driver_settings.xml +++ b/res/xml/graphics_driver_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="graphics_driver_settings" android:title="@string/graphics_driver_dashboard_title"> <ListPreference diff --git a/res/xml/hardware_info.xml b/res/xml/hardware_info.xml index 4ed914d0ad..10de2990ae 100644 --- a/res/xml/hardware_info.xml +++ b/res/xml/hardware_info.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="hardware_info_screen" android:title="@string/hardware_info" settings:keywords="@string/keywords_model_and_hardware"> diff --git a/res/xml/install_certificate_from_storage.xml b/res/xml/install_certificate_from_storage.xml index 640cb562c1..8227ead4c5 100644 --- a/res/xml/install_certificate_from_storage.xml +++ b/res/xml/install_certificate_from_storage.xml @@ -17,8 +17,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:title="@string/credentials_install" - android:key="install_certificate_from_storage"> + android:title="@string/credentials_install"> <PreferenceCategory android:key="certificate_types"> @@ -76,4 +75,4 @@ </PreferenceCategory> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/language_and_input.xml b/res/xml/language_and_input.xml index 03c83d4728..c3848e3275 100644 --- a/res/xml/language_and_input.xml +++ b/res/xml/language_and_input.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="language_and_input_settings_screen" android:title="@string/language_settings" settings:initialExpandedChildrenCount="3"> @@ -39,8 +38,7 @@ android:key="physical_keyboard_pref" android:title="@string/physical_keyboard_title" android:summary="@string/summary_placeholder" - android:fragment="com.android.settings.inputmethod.PhysicalKeyboardFragment" - settings:searchable="false"/> + android:fragment="com.android.settings.inputmethod.PhysicalKeyboardFragment"/> </PreferenceCategory> <PreferenceCategory diff --git a/res/xml/location_scanning.xml b/res/xml/location_scanning.xml index 5e7bd24452..f82500bf8e 100644 --- a/res/xml/location_scanning.xml +++ b/res/xml/location_scanning.xml @@ -15,8 +15,7 @@ --> <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - android:title="@string/location_scanning_screen_title" - android:key="scanning_screen"> + android:title="@string/location_scanning_screen_title"> <SwitchPreference android:title="@string/location_scanning_wifi_always_scanning_title" diff --git a/res/xml/location_settings.xml b/res/xml/location_settings.xml index fb03f4c7f3..6662c2f6fe 100644 --- a/res/xml/location_settings.xml +++ b/res/xml/location_settings.xml @@ -17,9 +17,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="location_settings" - android:title="@string/location_settings_title" - settings:keywords="@string/keywords_location"> + android:title="@string/location_settings_title"> <PreferenceCategory android:key="recent_location_requests" diff --git a/res/xml/module_licenses.xml b/res/xml/module_licenses.xml index 005b483850..def4d498c0 100644 --- a/res/xml/module_licenses.xml +++ b/res/xml/module_licenses.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="module_licenses" android:title="@string/module_license_title"> <PreferenceCategory android:key="module_licenses_category" diff --git a/res/xml/my_device_info.xml b/res/xml/my_device_info.xml index 3f22a7b033..dbf162353b 100644 --- a/res/xml/my_device_info.xml +++ b/res/xml/my_device_info.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="my_device_info_pref_screen" android:title="@string/about_settings"> <com.android.settingslib.widget.LayoutPreference @@ -68,8 +67,7 @@ android:order="15" android:title="@string/legal_information" android:fragment="com.android.settings.LegalSettings" - settings:allowDividerAbove="true" - settings:searchable="false"/> + settings:allowDividerAbove="true"/> <!-- Regulatory labels --> <Preference diff --git a/res/xml/network_and_internet.xml b/res/xml/network_and_internet.xml index 5280221619..c57c5b0af7 100644 --- a/res/xml/network_and_internet.xml +++ b/res/xml/network_and_internet.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="network_and_internet_screen" android:title="@string/network_dashboard_title" settings:initialExpandedChildrenCount="5"> diff --git a/res/xml/nfc_payment_settings.xml b/res/xml/nfc_payment_settings.xml index 2508c39fab..8e55a39a3c 100644 --- a/res/xml/nfc_payment_settings.xml +++ b/res/xml/nfc_payment_settings.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="nfc_payment_settings_screen" android:title="@string/nfc_payment_settings_title"> <com.android.settings.nfc.NfcPaymentPreference diff --git a/res/xml/night_display_settings.xml b/res/xml/night_display_settings.xml index 1a769f5443..eed5c7748e 100644 --- a/res/xml/night_display_settings.xml +++ b/res/xml/night_display_settings.xml @@ -18,7 +18,6 @@ xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" android:title="@string/night_display_title" - android:key="night_display_title" settings:keywords="@string/keywords_display_night_display"> <DropDownPreference @@ -60,4 +59,4 @@ settings:allowDividerAbove="true" settings:controller="com.android.settings.display.NightDisplayFooterPreferenceController"/> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/notification_access_settings.xml b/res/xml/notification_access_settings.xml index 4dbaf887f8..ca84f1b505 100644 --- a/res/xml/notification_access_settings.xml +++ b/res/xml/notification_access_settings.xml @@ -18,6 +18,5 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="notification_access_screen" android:title="@string/manage_notification_access_title" settings:controller="com.android.settings.applications.specialaccess.notificationaccess.NotificationAccessScreenPreferenceController" /> diff --git a/res/xml/physical_keyboard_settings.xml b/res/xml/physical_keyboard_settings.xml index a2d9a6b721..96946a9030 100644 --- a/res/xml/physical_keyboard_settings.xml +++ b/res/xml/physical_keyboard_settings.xml @@ -15,7 +15,6 @@ --> <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - android:key="physical_keyboard_screen" android:title="@string/physical_keyboard_title"> <!-- Additional preference screens are inserted here programmatically with low order values to set the key map of each attached keyboard. --> diff --git a/res/xml/pick_up_gesture_settings.xml b/res/xml/pick_up_gesture_settings.xml index 47f707a2c2..178ddf5fa5 100644 --- a/res/xml/pick_up_gesture_settings.xml +++ b/res/xml/pick_up_gesture_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" - android:key="gesture_pick_up_screen" android:title="@string/ambient_display_pickup_title"> <com.android.settings.widget.VideoPreference @@ -34,4 +33,4 @@ app:controller="com.android.settings.gestures.PickupGesturePreferenceController" app:allowDividerAbove="true" /> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/picture_in_picture_settings.xml b/res/xml/picture_in_picture_settings.xml index 35839cdc14..1f0824643c 100644 --- a/res/xml/picture_in_picture_settings.xml +++ b/res/xml/picture_in_picture_settings.xml @@ -18,6 +18,5 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="picture_in_picture_screen" android:title="@string/picture_in_picture_title" settings:controller="com.android.settings.applications.specialaccess.pictureinpicture.PictureInPictureScreenPreferenceController" /> diff --git a/res/xml/platform_compat_settings.xml b/res/xml/platform_compat_settings.xml index bee2324fb0..86e62fe224 100644 --- a/res/xml/platform_compat_settings.xml +++ b/res/xml/platform_compat_settings.xml @@ -18,6 +18,5 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="platform_compat_dashboard" android:title="@string/platform_compat_dashboard_title"> </PreferenceScreen> diff --git a/res/xml/power_usage_summary.xml b/res/xml/power_usage_summary.xml index 005ce17f36..869bb94f75 100644 --- a/res/xml/power_usage_summary.xml +++ b/res/xml/power_usage_summary.xml @@ -17,9 +17,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="power_usage_summary_screen" - android:title="@string/power_usage_summary_title" - settings:keywords="@string/keywords_battery"> + android:title="@string/power_usage_summary_title"> <com.android.settingslib.widget.LayoutPreference android:key="battery_header" diff --git a/res/xml/premium_sms_settings.xml b/res/xml/premium_sms_settings.xml index 17d12978b2..82aece3ead 100644 --- a/res/xml/premium_sms_settings.xml +++ b/res/xml/premium_sms_settings.xml @@ -18,6 +18,5 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="premium_sms_screen" android:title="@string/premium_sms_access" settings:controller="com.android.settings.applications.specialaccess.premiumsms.PremiumSmsScreenPreferenceController" /> diff --git a/res/xml/prevent_ringing_gesture_settings.xml b/res/xml/prevent_ringing_gesture_settings.xml index 4b0edc3617..cc2f234016 100644 --- a/res/xml/prevent_ringing_gesture_settings.xml +++ b/res/xml/prevent_ringing_gesture_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" - android:key="gesture_prevent_ringing_screen" android:title="@string/gesture_prevent_ringing_screen_title"> <com.android.settings.widget.VideoPreference @@ -33,4 +32,4 @@ <PreferenceCategory android:key="gesture_prevent_ringing_category" android:title="@string/gesture_prevent_ringing_title" /> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/previously_connected_devices.xml b/res/xml/previously_connected_devices.xml index 8c5509bc57..435ced7565 100644 --- a/res/xml/previously_connected_devices.xml +++ b/res/xml/previously_connected_devices.xml @@ -17,11 +17,10 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="connected_devices_screen_previously" android:title="@string/connected_device_previously_connected_screen_title"> <PreferenceCategory android:key="saved_device_list" settings:controller="com.android.settings.connecteddevice.SavedDeviceGroupController"/> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/print_settings.xml b/res/xml/print_settings.xml index 8d840d1fc6..1919e53a88 100644 --- a/res/xml/print_settings.xml +++ b/res/xml/print_settings.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="print_settings_screen" android:title="@string/print_settings" settings:keywords="@string/keywords_printing"> diff --git a/res/xml/privacy_dashboard_settings.xml b/res/xml/privacy_dashboard_settings.xml index 623460c5d3..abedc532be 100644 --- a/res/xml/privacy_dashboard_settings.xml +++ b/res/xml/privacy_dashboard_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="privacy_dashboard_page" android:title="@string/privacy_dashboard_title" settings:initialExpandedChildrenCount="4"> diff --git a/res/xml/reset_dashboard_fragment.xml b/res/xml/reset_dashboard_fragment.xml index 1b8dc6800f..ac4ccb5668 100644 --- a/res/xml/reset_dashboard_fragment.xml +++ b/res/xml/reset_dashboard_fragment.xml @@ -18,8 +18,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:title="@string/reset_dashboard_title" - android:key="reset_dashboard_fragment_screen"> + android:title="@string/reset_dashboard_title"> <!-- Network reset --> <com.android.settingslib.RestrictedPreference diff --git a/res/xml/screen_pinning_settings.xml b/res/xml/screen_pinning_settings.xml index 7ff7f1de34..04e537749a 100644 --- a/res/xml/screen_pinning_settings.xml +++ b/res/xml/screen_pinning_settings.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="screen_pinning_settings_screen" android:title="@string/screen_pinning_title"> <SwitchPreference diff --git a/res/xml/security_dashboard_settings.xml b/res/xml/security_dashboard_settings.xml index 6a896ced42..cf56d67e77 100644 --- a/res/xml/security_dashboard_settings.xml +++ b/res/xml/security_dashboard_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="security_dashboard_page" android:title="@string/security_settings_title" settings:initialExpandedChildrenCount="9"> @@ -147,4 +146,4 @@ android:summary="@string/summary_placeholder" android:fragment="com.android.settings.security.ScreenPinningSettings" /> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/security_lockscreen_settings.xml b/res/xml/security_lockscreen_settings.xml index 8cd4d76fbe..dfc5ce79b6 100644 --- a/res/xml/security_lockscreen_settings.xml +++ b/res/xml/security_lockscreen_settings.xml @@ -17,9 +17,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="security_lockscreen_settings_screen" - android:title="@string/lockscreen_settings_title" - settings:keywords="@string/keywords_ambient_display_screen"> + android:title="@string/lockscreen_settings_title"> <PreferenceCategory android:key="lockscreen_what_to_show" diff --git a/res/xml/sound_settings.xml b/res/xml/sound_settings.xml index a24a95f99a..c525ccd1f4 100644 --- a/res/xml/sound_settings.xml +++ b/res/xml/sound_settings.xml @@ -18,7 +18,6 @@ xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" android:title="@string/sound_settings" - android:key="sound_settings" settings:keywords="@string/keywords_sounds" settings:initialExpandedChildrenCount="9"> diff --git a/res/xml/special_access.xml b/res/xml/special_access.xml index 200f896c4b..ae3c9f8b33 100644 --- a/res/xml/special_access.xml +++ b/res/xml/special_access.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="special_app_access_screen" android:title="@string/special_access"> <Preference diff --git a/res/xml/storage_dashboard_fragment.xml b/res/xml/storage_dashboard_fragment.xml index 66447cdf48..51d49353fd 100644 --- a/res/xml/storage_dashboard_fragment.xml +++ b/res/xml/storage_dashboard_fragment.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="storage_dashboard_screen" android:title="@string/storage_settings" android:orderingFromXml="false"> <com.android.settings.deviceinfo.storage.StorageSummaryDonutPreference diff --git a/res/xml/system_dashboard_fragment.xml b/res/xml/system_dashboard_fragment.xml index 88b8d2f7e9..5d0fbcdf60 100644 --- a/res/xml/system_dashboard_fragment.xml +++ b/res/xml/system_dashboard_fragment.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="system_dashboard_screen" android:title="@string/header_category_system" settings:initialExpandedChildrenCount="4"> @@ -76,4 +75,4 @@ android:targetClass="@string/additional_system_update_menu"/> </Preference> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/system_navigation_gesture_settings.xml b/res/xml/system_navigation_gesture_settings.xml index b1045fcbd6..a75875bc74 100644 --- a/res/xml/system_navigation_gesture_settings.xml +++ b/res/xml/system_navigation_gesture_settings.xml @@ -18,6 +18,5 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="gesture_system_navigation_screen" android:title="@string/system_navigation_title" settings:keywords="@string/keywords_system_navigation"/> diff --git a/res/xml/tap_screen_gesture_settings.xml b/res/xml/tap_screen_gesture_settings.xml index 9c0610af36..fe3122543b 100644 --- a/res/xml/tap_screen_gesture_settings.xml +++ b/res/xml/tap_screen_gesture_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" - android:key="gesture_tap_screen" android:title="@string/ambient_display_tap_screen_title"> <com.android.settings.widget.VideoPreference @@ -34,4 +33,4 @@ app:controller="com.android.settings.gestures.TapScreenGesturePreferenceController" app:allowDividerAbove="true" /> -</PreferenceScreen>
\ No newline at end of file +</PreferenceScreen> diff --git a/res/xml/tether_prefs.xml b/res/xml/tether_prefs.xml index 54c49e8f1c..70d55aa512 100644 --- a/res/xml/tether_prefs.xml +++ b/res/xml/tether_prefs.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="tether_prefs_screen" android:title="@string/tether_settings_title_all"> <com.android.settings.widget.FixedLineSummaryPreference diff --git a/res/xml/time_zone_prefs.xml b/res/xml/time_zone_prefs.xml index 6fa43fa130..fa5cf972f3 100644 --- a/res/xml/time_zone_prefs.xml +++ b/res/xml/time_zone_prefs.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="time_zone_settings_screen" android:title="@string/date_time_set_timezone"> <PreferenceCategory diff --git a/res/xml/top_level_settings.xml b/res/xml/top_level_settings.xml index 367f426f5f..8f8d3d19ec 100644 --- a/res/xml/top_level_settings.xml +++ b/res/xml/top_level_settings.xml @@ -53,6 +53,7 @@ android:icon="@drawable/ic_homepage_battery" android:fragment="com.android.settings.fuelgauge.PowerUsageSummary" android:order="-90" + settings:keywords="@string/keywords_battery" settings:controller="com.android.settings.fuelgauge.TopLevelBatteryPreferenceController"/> <Preference @@ -79,6 +80,7 @@ android:icon="@drawable/ic_homepage_storage" android:order="-60" android:fragment="com.android.settings.deviceinfo.StorageSettings" + settings:keywords="@string/keywords_display" settings:controller="com.android.settings.deviceinfo.TopLevelStoragePreferenceController"/> <Preference @@ -96,6 +98,7 @@ android:icon="@drawable/ic_homepage_location" android:order="-50" android:fragment="com.android.settings.location.LocationSettings" + settings:keywords="@string/keywords_location" settings:controller="com.android.settings.location.TopLevelLocationPreferenceController"/> <Preference @@ -114,6 +117,7 @@ android:icon="@drawable/ic_homepage_accounts" android:order="-30" android:fragment="com.android.settings.accounts.AccountDashboardFragment" + settings:keywords="@string/keywords_accounts" settings:controller="com.android.settings.accounts.TopLevelAccountEntryPreferenceController"/> <Preference diff --git a/res/xml/trust_agent_settings.xml b/res/xml/trust_agent_settings.xml index c6539c4fde..88837b8170 100644 --- a/res/xml/trust_agent_settings.xml +++ b/res/xml/trust_agent_settings.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="trust_agents" android:title="@string/manage_trust_agents" settings:controller="com.android.settings.security.trustagent.TrustAgentsPreferenceController"> </PreferenceScreen> diff --git a/res/xml/tts_engine_picker.xml b/res/xml/tts_engine_picker.xml index 2550fe0ff5..fd431ce22b 100644 --- a/res/xml/tts_engine_picker.xml +++ b/res/xml/tts_engine_picker.xml @@ -15,7 +15,6 @@ --> <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - android:key="tts_engine_picker_screen" android:title="@string/tts_engine_preference_title"> </PreferenceScreen> diff --git a/res/xml/tts_settings.xml b/res/xml/tts_settings.xml index 92bf5d7c4d..bcc9c85f39 100644 --- a/res/xml/tts_settings.xml +++ b/res/xml/tts_settings.xml @@ -17,14 +17,12 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="tts_settings_screen" android:title="@string/tts_settings_title"> <com.android.settings.widget.GearPreference android:key="tts_engine_preference" android:title="@string/tts_engine_preference_title" - android:fragment="com.android.settings.tts.TtsEnginePreferenceFragment" - settings:searchable="false"/> + android:fragment="com.android.settings.tts.TtsEnginePreferenceFragment"/> <ListPreference android:key="tts_default_lang" diff --git a/res/xml/unrestricted_data_access_settings.xml b/res/xml/unrestricted_data_access_settings.xml index a386d1b57e..baefa65a60 100644 --- a/res/xml/unrestricted_data_access_settings.xml +++ b/res/xml/unrestricted_data_access_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="unrestricted_data_screen" android:title="@string/unrestricted_data_saver" settings:controller="com.android.settings.datausage.UnrestrictedDataAccessPreferenceController"> </PreferenceScreen> diff --git a/res/xml/usb_default_fragment.xml b/res/xml/usb_default_fragment.xml index b8d5e53b37..b062b8f894 100644 --- a/res/xml/usb_default_fragment.xml +++ b/res/xml/usb_default_fragment.xml @@ -16,6 +16,5 @@ --> <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - android:title="@string/usb_pref" - android:key="usb_default_fragment"> + android:title="@string/usb_pref"> </PreferenceScreen> diff --git a/res/xml/user_dictionary_list_fragment.xml b/res/xml/user_dictionary_list_fragment.xml index 46418c196a..2f921a0b28 100644 --- a/res/xml/user_dictionary_list_fragment.xml +++ b/res/xml/user_dictionary_list_fragment.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="user_dict_list" android:title="@string/user_dict_settings_title" settings:controller="com.android.settings.inputmethod.UserDictionaryListPreferenceController"> diff --git a/res/xml/virtual_keyboard_settings.xml b/res/xml/virtual_keyboard_settings.xml index f248236d3a..5a30082457 100644 --- a/res/xml/virtual_keyboard_settings.xml +++ b/res/xml/virtual_keyboard_settings.xml @@ -16,7 +16,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="virtual_keyboard_category" android:title="@string/virtual_keyboard_category"> <!-- Enabled input method list will be populated programmatically here. --> <Preference diff --git a/res/xml/vr_listeners_settings.xml b/res/xml/vr_listeners_settings.xml index ffd8545879..a35b98758f 100644 --- a/res/xml/vr_listeners_settings.xml +++ b/res/xml/vr_listeners_settings.xml @@ -18,6 +18,5 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="vr_listener_settings" android:title="@string/vr_listeners_title" settings:controller="com.android.settings.applications.specialaccess.vrlistener.VrListenerScreenPreferenceController" /> diff --git a/res/xml/wifi_configure_settings.xml b/res/xml/wifi_configure_settings.xml index 41d101bd7e..cc281fa876 100644 --- a/res/xml/wifi_configure_settings.xml +++ b/res/xml/wifi_configure_settings.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="wifi_configure_settings_screen" android:title="@string/wifi_configure_settings_preference_title"> <SwitchPreference diff --git a/res/xml/wifi_display_settings.xml b/res/xml/wifi_display_settings.xml index 769e9cef17..62b75c23a2 100644 --- a/res/xml/wifi_display_settings.xml +++ b/res/xml/wifi_display_settings.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="wifi_display_settings_screen" android:title="@string/wifi_display_settings_title" settings:keywords="@string/keywords_display_cast_screen"> diff --git a/res/xml/wifi_tether_settings.xml b/res/xml/wifi_tether_settings.xml index 3a3bdc4ba4..1f43bb5454 100644 --- a/res/xml/wifi_tether_settings.xml +++ b/res/xml/wifi_tether_settings.xml @@ -18,9 +18,7 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="wifi_tether_settings_screen" - android:title="@string/wifi_hotspot_checkbox_text" - settings:searchable="false"> + android:title="@string/wifi_hotspot_checkbox_text"> <com.android.settings.wifi.tether.WifiTetherSsidPreference android:key="wifi_tether_network_name" diff --git a/res/xml/zen_access_settings.xml b/res/xml/zen_access_settings.xml index 48dc1af213..35cfdb8e70 100644 --- a/res/xml/zen_access_settings.xml +++ b/res/xml/zen_access_settings.xml @@ -17,5 +17,4 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - android:key="zen_access_screen" android:title="@string/manage_zen_access_title" /> diff --git a/res/xml/zen_mode_automation_settings.xml b/res/xml/zen_mode_automation_settings.xml index 467331dc6d..f00865dcaa 100644 --- a/res/xml/zen_mode_automation_settings.xml +++ b/res/xml/zen_mode_automation_settings.xml @@ -16,7 +16,6 @@ --> <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - android:key="zen_mode_automation_settings_page" android:title="@string/zen_mode_automation_settings_page_title" > <PreferenceCategory diff --git a/res/xml/zen_mode_bypassing_apps.xml b/res/xml/zen_mode_bypassing_apps.xml index 0789839181..bd46c67d17 100644 --- a/res/xml/zen_mode_bypassing_apps.xml +++ b/res/xml/zen_mode_bypassing_apps.xml @@ -17,5 +17,4 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - android:key="zen_mode_bypassing_apps_screen" android:title="@string/zen_mode_bypassing_apps_title" /> diff --git a/res/xml/zen_mode_people_settings.xml b/res/xml/zen_mode_people_settings.xml index 140d1cde8d..7755bb7564 100644 --- a/res/xml/zen_mode_people_settings.xml +++ b/res/xml/zen_mode_people_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="zen_mode_people_settings_page" android:title="@string/zen_category_people" > <PreferenceCategory diff --git a/res/xml/zen_mode_restrict_notifications_settings.xml b/res/xml/zen_mode_restrict_notifications_settings.xml index b0705cbd10..ad574d8c8c 100644 --- a/res/xml/zen_mode_restrict_notifications_settings.xml +++ b/res/xml/zen_mode_restrict_notifications_settings.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - android:key="zen_mode_restrict_settings_page" android:title="@string/zen_mode_restrict_notifications_title"> <PreferenceCategory diff --git a/res/xml/zen_mode_settings.xml b/res/xml/zen_mode_settings.xml index 13cf945da3..a55c6be38f 100644 --- a/res/xml/zen_mode_settings.xml +++ b/res/xml/zen_mode_settings.xml @@ -18,7 +18,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto" - android:key="zen_mode_settings" android:title=" "> <!-- Turn on DND button --> diff --git a/res/xml/zen_mode_sound_vibration_settings.xml b/res/xml/zen_mode_sound_vibration_settings.xml index 4aacda3b89..26f003fcc7 100644 --- a/res/xml/zen_mode_sound_vibration_settings.xml +++ b/res/xml/zen_mode_sound_vibration_settings.xml @@ -17,7 +17,6 @@ <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" - android:key="zen_mode_sound_vibration_settings_page" android:title="@string/zen_category_exceptions" > <PreferenceCategory diff --git a/src/com/android/settings/accessibility/AutoclickPreferenceController.java b/src/com/android/settings/accessibility/AutoclickPreferenceController.java index 4d85b52c70..b354aa6f49 100644 --- a/src/com/android/settings/accessibility/AutoclickPreferenceController.java +++ b/src/com/android/settings/accessibility/AutoclickPreferenceController.java @@ -31,7 +31,7 @@ public class AutoclickPreferenceController extends BasePreferenceController { @Override public int getAvailabilityStatus() { - return AVAILABLE_UNSEARCHABLE; + return AVAILABLE; } @Override diff --git a/src/com/android/settings/accessibility/TopLevelAccessibilityPreferenceController.java b/src/com/android/settings/accessibility/TopLevelAccessibilityPreferenceController.java index 41040a0d8e..7a8ba2137c 100644 --- a/src/com/android/settings/accessibility/TopLevelAccessibilityPreferenceController.java +++ b/src/com/android/settings/accessibility/TopLevelAccessibilityPreferenceController.java @@ -31,8 +31,7 @@ public class TopLevelAccessibilityPreferenceController extends BasePreferenceCon @Override public int getAvailabilityStatus() { return mContext.getResources().getBoolean(R.bool.config_show_top_level_accessibility) - ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } } diff --git a/src/com/android/settings/accounts/TopLevelAccountEntryPreferenceController.java b/src/com/android/settings/accounts/TopLevelAccountEntryPreferenceController.java index a8d93d589d..e4e32e54d1 100644 --- a/src/com/android/settings/accounts/TopLevelAccountEntryPreferenceController.java +++ b/src/com/android/settings/accounts/TopLevelAccountEntryPreferenceController.java @@ -36,7 +36,7 @@ public class TopLevelAccountEntryPreferenceController extends BasePreferenceCont @Override public int getAvailabilityStatus() { - return AVAILABLE_UNSEARCHABLE; + return AVAILABLE; } @Override diff --git a/src/com/android/settings/applications/SpecialAppAccessPreferenceController.java b/src/com/android/settings/applications/SpecialAppAccessPreferenceController.java index 1763d84491..8c937bc17b 100644 --- a/src/com/android/settings/applications/SpecialAppAccessPreferenceController.java +++ b/src/com/android/settings/applications/SpecialAppAccessPreferenceController.java @@ -63,7 +63,7 @@ public class SpecialAppAccessPreferenceController extends BasePreferenceControll @Override public int getAvailabilityStatus() { - return AVAILABLE_UNSEARCHABLE; + return AVAILABLE; } @Override diff --git a/src/com/android/settings/applications/specialaccess/DataSaverController.java b/src/com/android/settings/applications/specialaccess/DataSaverController.java index c169d7fc89..d1fd202aae 100644 --- a/src/com/android/settings/applications/specialaccess/DataSaverController.java +++ b/src/com/android/settings/applications/specialaccess/DataSaverController.java @@ -31,7 +31,6 @@ public class DataSaverController extends BasePreferenceController { @AvailabilityStatus public int getAvailabilityStatus() { return mContext.getResources().getBoolean(R.bool.config_show_data_saver) - ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } -}
\ No newline at end of file +} diff --git a/src/com/android/settings/applications/specialaccess/notificationaccess/NotificationAccessController.java b/src/com/android/settings/applications/specialaccess/notificationaccess/NotificationAccessController.java index 6025da569d..32e2e7ecd1 100644 --- a/src/com/android/settings/applications/specialaccess/notificationaccess/NotificationAccessController.java +++ b/src/com/android/settings/applications/specialaccess/notificationaccess/NotificationAccessController.java @@ -31,9 +31,7 @@ public class NotificationAccessController extends BasePreferenceController { @Override public int getAvailabilityStatus() { - return !ActivityManager.isLowRamDeviceStatic() - ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + return !ActivityManager.isLowRamDeviceStatic() ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } public static boolean hasAccess(Context context, ComponentName cn) { diff --git a/src/com/android/settings/applications/specialaccess/pictureinpicture/PictureInPictureController.java b/src/com/android/settings/applications/specialaccess/pictureinpicture/PictureInPictureController.java index dc1dde163d..fa8afc96a0 100644 --- a/src/com/android/settings/applications/specialaccess/pictureinpicture/PictureInPictureController.java +++ b/src/com/android/settings/applications/specialaccess/pictureinpicture/PictureInPictureController.java @@ -32,7 +32,6 @@ public class PictureInPictureController extends BasePreferenceController { public int getAvailabilityStatus() { return !ActivityManager.isLowRamDeviceStatic() && mContext.getPackageManager().hasSystemFeature( - PackageManager.FEATURE_PICTURE_IN_PICTURE) ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + PackageManager.FEATURE_PICTURE_IN_PICTURE) ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } } diff --git a/src/com/android/settings/applications/specialaccess/premiumsms/PremiumSmsController.java b/src/com/android/settings/applications/specialaccess/premiumsms/PremiumSmsController.java index 158fe3cfd4..9c6ab8ca1c 100644 --- a/src/com/android/settings/applications/specialaccess/premiumsms/PremiumSmsController.java +++ b/src/com/android/settings/applications/specialaccess/premiumsms/PremiumSmsController.java @@ -30,7 +30,6 @@ public class PremiumSmsController extends BasePreferenceController { @AvailabilityStatus public int getAvailabilityStatus() { return mContext.getResources().getBoolean(R.bool.config_show_premium_sms) - ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } -}
\ No newline at end of file +} diff --git a/src/com/android/settings/applications/specialaccess/vrlistener/EnabledVrListenersController.java b/src/com/android/settings/applications/specialaccess/vrlistener/EnabledVrListenersController.java index fd59d8d3e3..adefec8140 100644 --- a/src/com/android/settings/applications/specialaccess/vrlistener/EnabledVrListenersController.java +++ b/src/com/android/settings/applications/specialaccess/vrlistener/EnabledVrListenersController.java @@ -34,8 +34,6 @@ public class EnabledVrListenersController extends BasePreferenceController { @AvailabilityStatus public int getAvailabilityStatus() { return mContext.getResources().getBoolean(R.bool.config_show_enabled_vr_listeners) - && !mActivityManager.isLowRamDevice() - ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + && !mActivityManager.isLowRamDevice() ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } -}
\ No newline at end of file +} diff --git a/src/com/android/settings/applications/specialaccess/zenaccess/ZenAccessController.java b/src/com/android/settings/applications/specialaccess/zenaccess/ZenAccessController.java index 9c99254292..727870c6d6 100644 --- a/src/com/android/settings/applications/specialaccess/zenaccess/ZenAccessController.java +++ b/src/com/android/settings/applications/specialaccess/zenaccess/ZenAccessController.java @@ -49,9 +49,7 @@ public class ZenAccessController extends BasePreferenceController { @Override public int getAvailabilityStatus() { - return isSupported(mActivityManager) - ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + return isSupported(mActivityManager) ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } public static boolean isSupported(ActivityManager activityManager) { diff --git a/src/com/android/settings/connecteddevice/BluetoothDashboardFragment.java b/src/com/android/settings/connecteddevice/BluetoothDashboardFragment.java index b16725e375..27b5c4a1ef 100644 --- a/src/com/android/settings/connecteddevice/BluetoothDashboardFragment.java +++ b/src/com/android/settings/connecteddevice/BluetoothDashboardFragment.java @@ -16,8 +16,6 @@ package com.android.settings.connecteddevice; import android.app.settings.SettingsEnums; -import android.bluetooth.BluetoothAdapter; -import android.bluetooth.BluetoothManager; import android.content.Context; import android.os.Bundle; @@ -25,19 +23,14 @@ import com.android.settings.R; import com.android.settings.SettingsActivity; import com.android.settings.bluetooth.BluetoothDeviceRenamePreferenceController; import com.android.settings.bluetooth.BluetoothSwitchPreferenceController; -import com.android.settings.core.TogglePreferenceController; import com.android.settings.dashboard.DashboardFragment; import com.android.settings.search.BaseSearchIndexProvider; import com.android.settings.widget.SwitchBar; import com.android.settings.widget.SwitchBarController; import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.search.SearchIndexable; -import com.android.settingslib.search.SearchIndexableRaw; import com.android.settingslib.widget.FooterPreference; -import java.util.ArrayList; -import java.util.List; - /** * Dedicated screen for allowing the user to toggle bluetooth which displays relevant information to * the user based on related settings such as bluetooth scanning. @@ -47,7 +40,6 @@ public class BluetoothDashboardFragment extends DashboardFragment { private static final String TAG = "BluetoothDashboardFrag"; private static final String KEY_BLUETOOTH_SCREEN_FOOTER = "bluetooth_screen_footer"; - public static final String KEY_BLUETOOTH_SCREEN = "bluetooth_switchbar_screen"; private FooterPreference mFooterPreference; private SwitchBar mSwitchBar; @@ -102,39 +94,5 @@ public class BluetoothDashboardFragment extends DashboardFragment { * For Search. */ public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = - new BaseSearchIndexProvider() { - @Override - public List<SearchIndexableRaw> getRawDataToIndex(Context context, - boolean enabled) { - final List<SearchIndexableRaw> result = new ArrayList<>(); - - // Add the activity title - final SearchIndexableRaw data = new SearchIndexableRaw(context); - data.title = context.getString(R.string.bluetooth_settings_title); - data.screenTitle = context.getString(R.string.bluetooth_settings_title); - data.keywords = context.getString(R.string.keywords_bluetooth_settings); - data.key = KEY_BLUETOOTH_SCREEN; - result.add(data); - - return result; - } - - @Override - public List<String> getNonIndexableKeys(Context context) { - final List<String> keys = super.getNonIndexableKeys(context); - BluetoothManager manager = - (BluetoothManager) context.getSystemService(Context.BLUETOOTH_SERVICE); - if (manager != null) { - BluetoothAdapter adapter = manager.getAdapter(); - final int status = adapter != null - ? TogglePreferenceController.AVAILABLE - : TogglePreferenceController.UNSUPPORTED_ON_DEVICE; - if (status != TogglePreferenceController.AVAILABLE) { - keys.add(KEY_BLUETOOTH_SCREEN); - } - } - - return keys; - } - }; + new BaseSearchIndexProvider(R.xml.bluetooth_screen); } diff --git a/src/com/android/settings/connecteddevice/PreviouslyConnectedDeviceDashboardFragment.java b/src/com/android/settings/connecteddevice/PreviouslyConnectedDeviceDashboardFragment.java index 741763871b..d3f5c28afb 100644 --- a/src/com/android/settings/connecteddevice/PreviouslyConnectedDeviceDashboardFragment.java +++ b/src/com/android/settings/connecteddevice/PreviouslyConnectedDeviceDashboardFragment.java @@ -17,17 +17,12 @@ package com.android.settings.connecteddevice; import android.app.settings.SettingsEnums; import android.content.Context; -import android.content.res.Resources; import com.android.settings.R; import com.android.settings.dashboard.DashboardFragment; import com.android.settings.search.BaseSearchIndexProvider; -import com.android.settingslib.search.SearchIndexableRaw; import com.android.settingslib.search.SearchIndexable; -import java.util.ArrayList; -import java.util.List; - /** * This fragment contains previously connected device */ @@ -67,22 +62,5 @@ public class PreviouslyConnectedDeviceDashboardFragment extends DashboardFragmen * For Search. */ public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = - new BaseSearchIndexProvider() { - @Override - public List<SearchIndexableRaw> getRawDataToIndex( - Context context, boolean enabled) { - final List<SearchIndexableRaw> result = new ArrayList<SearchIndexableRaw>(); - final Resources res = context.getResources(); - - // Add fragment title - SearchIndexableRaw data = new SearchIndexableRaw(context); - data.key = KEY_PREVIOUSLY_CONNECTED_DEVICES; - data.title = res.getString( - R.string.connected_device_previously_connected_title); - data.screenTitle = res.getString( - R.string.connected_device_previously_connected_title); - result.add(data); - return result; - } - }; + new BaseSearchIndexProvider(R.xml.previously_connected_devices); }
\ No newline at end of file diff --git a/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceController.java b/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceController.java index 21022838d2..fd36bca633 100644 --- a/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceController.java +++ b/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceController.java @@ -31,8 +31,7 @@ public class TopLevelConnectedDevicesPreferenceController extends BasePreference @Override public int getAvailabilityStatus() { return mContext.getResources().getBoolean(R.bool.config_show_top_level_connected_devices) - ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } @Override diff --git a/src/com/android/settings/deviceinfo/HardwareInfoPreferenceController.java b/src/com/android/settings/deviceinfo/HardwareInfoPreferenceController.java index 29f1391207..7ee6f891fc 100644 --- a/src/com/android/settings/deviceinfo/HardwareInfoPreferenceController.java +++ b/src/com/android/settings/deviceinfo/HardwareInfoPreferenceController.java @@ -44,7 +44,7 @@ public class HardwareInfoPreferenceController extends BasePreferenceController { @Override public int getAvailabilityStatus() { return mContext.getResources().getBoolean(R.bool.config_show_device_model) - ? AVAILABLE_UNSEARCHABLE : UNSUPPORTED_ON_DEVICE; + ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } @Override diff --git a/src/com/android/settings/deviceinfo/StorageSettings.java b/src/com/android/settings/deviceinfo/StorageSettings.java index 5925da9709..aedaa4cca5 100644 --- a/src/com/android/settings/deviceinfo/StorageSettings.java +++ b/src/com/android/settings/deviceinfo/StorageSettings.java @@ -50,13 +50,13 @@ import com.android.settings.SettingsPreferenceFragment; import com.android.settings.core.SubSettingLauncher; import com.android.settings.core.instrumentation.InstrumentedDialogFragment; import com.android.settings.search.BaseSearchIndexProvider; -import com.android.settingslib.search.Indexable; -import com.android.settingslib.search.SearchIndexableRaw; import com.android.settingslib.RestrictedLockUtils; import com.android.settingslib.RestrictedLockUtilsInternal; import com.android.settingslib.deviceinfo.PrivateStorageInfo; import com.android.settingslib.deviceinfo.StorageManagerVolumeProvider; +import com.android.settingslib.search.Indexable; import com.android.settingslib.search.SearchIndexable; +import com.android.settingslib.search.SearchIndexableRaw; import java.util.ArrayList; import java.util.Collections; @@ -550,13 +550,6 @@ public class StorageSettings extends SettingsPreferenceFragment implements Index final List<SearchIndexableRaw> result = new ArrayList<>(); SearchIndexableRaw data = new SearchIndexableRaw(context); - data.title = context.getString(R.string.storage_settings); - data.key = "storage_settings"; - data.screenTitle = context.getString(R.string.storage_settings); - data.keywords = context.getString(R.string.keywords_storage_settings); - result.add(data); - - data = new SearchIndexableRaw(context); data.title = context.getString(R.string.internal_storage); data.key = "storage_settings_internal_storage"; data.screenTitle = context.getString(R.string.storage_settings); diff --git a/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java b/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java index fdc5feb573..8a2d3babb8 100644 --- a/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java +++ b/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java @@ -43,7 +43,7 @@ public class TopLevelStoragePreferenceController extends BasePreferenceControlle @Override public int getAvailabilityStatus() { - return AVAILABLE_UNSEARCHABLE; + return AVAILABLE; } @Override diff --git a/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceController.java b/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceController.java index 41d9566760..a63c20600c 100644 --- a/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceController.java +++ b/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceController.java @@ -29,7 +29,7 @@ public class FirmwareVersionPreferenceController extends BasePreferenceControlle @Override public int getAvailabilityStatus() { - return AVAILABLE_UNSEARCHABLE; + return AVAILABLE; } @Override diff --git a/src/com/android/settings/display/ColorModePreferenceController.java b/src/com/android/settings/display/ColorModePreferenceController.java index 234cc98859..7a43e5c3d7 100644 --- a/src/com/android/settings/display/ColorModePreferenceController.java +++ b/src/com/android/settings/display/ColorModePreferenceController.java @@ -34,7 +34,7 @@ public class ColorModePreferenceController extends BasePreferenceController { return mContext.getSystemService(ColorDisplayManager.class) .isDeviceColorManaged() && !ColorDisplayManager.areAccessibilityTransformsEnabled(mContext) ? - AVAILABLE_UNSEARCHABLE : DISABLED_FOR_USER; + AVAILABLE : DISABLED_FOR_USER; } @Override diff --git a/src/com/android/settings/display/FontSizePreferenceController.java b/src/com/android/settings/display/FontSizePreferenceController.java index 680e378cc4..28c7922ea3 100644 --- a/src/com/android/settings/display/FontSizePreferenceController.java +++ b/src/com/android/settings/display/FontSizePreferenceController.java @@ -28,7 +28,7 @@ public class FontSizePreferenceController extends BasePreferenceController { @Override public int getAvailabilityStatus() { - return AVAILABLE_UNSEARCHABLE; + return AVAILABLE; } @Override diff --git a/src/com/android/settings/display/ScreenZoomSettings.java b/src/com/android/settings/display/ScreenZoomSettings.java index a30713661c..4c46f01893 100644 --- a/src/com/android/settings/display/ScreenZoomSettings.java +++ b/src/com/android/settings/display/ScreenZoomSettings.java @@ -20,21 +20,15 @@ import android.annotation.Nullable; import android.app.settings.SettingsEnums; import android.content.Context; import android.content.res.Configuration; -import android.content.res.Resources; import android.os.Bundle; import android.view.Display; import com.android.settings.R; import com.android.settings.search.BaseSearchIndexProvider; -import com.android.settingslib.search.Indexable; -import com.android.settingslib.search.SearchIndexableRaw; import com.android.settingslib.display.DisplayDensityConfiguration; import com.android.settingslib.display.DisplayDensityUtils; import com.android.settingslib.search.SearchIndexable; -import java.util.ArrayList; -import java.util.List; - /** * Preference fragment used to control screen zoom. */ @@ -121,18 +115,8 @@ public class ScreenZoomSettings extends PreviewSeekBarPreferenceFragment { public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = new BaseSearchIndexProvider() { @Override - public List<SearchIndexableRaw> getRawDataToIndex(Context context, - boolean enabled) { - final Resources res = context.getResources(); - final SearchIndexableRaw data = new SearchIndexableRaw(context); - data.title = res.getString(R.string.screen_zoom_title); - data.key = "screen_zoom_settings"; - data.screenTitle = res.getString(R.string.screen_zoom_title); - data.keywords = res.getString(R.string.screen_zoom_keywords); - - final List<SearchIndexableRaw> result = new ArrayList<>(1); - result.add(data); - return result; + protected boolean isPageSearchEnabled(Context context) { + return false; } }; } diff --git a/src/com/android/settings/display/ToggleFontSizePreferenceFragment.java b/src/com/android/settings/display/ToggleFontSizePreferenceFragment.java index d024685686..db4d899cbb 100644 --- a/src/com/android/settings/display/ToggleFontSizePreferenceFragment.java +++ b/src/com/android/settings/display/ToggleFontSizePreferenceFragment.java @@ -27,13 +27,8 @@ import android.provider.Settings; import com.android.settings.R; import com.android.settings.search.BaseSearchIndexProvider; -import com.android.settingslib.search.Indexable; -import com.android.settingslib.search.SearchIndexableRaw; import com.android.settingslib.search.SearchIndexable; -import java.util.ArrayList; -import java.util.List; - /** * Preference fragment used to control font size. */ @@ -118,16 +113,8 @@ public class ToggleFontSizePreferenceFragment extends PreviewSeekBarPreferenceFr public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = new BaseSearchIndexProvider() { @Override - public List<SearchIndexableRaw> getRawDataToIndex(Context context, - boolean enabled) { - final ArrayList<SearchIndexableRaw> result = new ArrayList<>(); - final SearchIndexableRaw data = new SearchIndexableRaw(context); - data.title = context.getString(R.string.title_font_size); - data.screenTitle = context.getString(R.string.title_font_size); - data.key = "font_size_setting_screen"; - data.keywords = context.getString(R.string.keywords_display_font_size); - result.add(data); - return result; + protected boolean isPageSearchEnabled(Context context) { + return false; } }; diff --git a/src/com/android/settings/enterprise/ManageDeviceAdminPreferenceController.java b/src/com/android/settings/enterprise/ManageDeviceAdminPreferenceController.java index 1b88e38583..00d17f1783 100644 --- a/src/com/android/settings/enterprise/ManageDeviceAdminPreferenceController.java +++ b/src/com/android/settings/enterprise/ManageDeviceAdminPreferenceController.java @@ -43,8 +43,7 @@ public class ManageDeviceAdminPreferenceController extends BasePreferenceControl @Override public int getAvailabilityStatus() { return mContext.getResources().getBoolean(R.bool.config_show_manage_device_admin) - ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } } diff --git a/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceController.java b/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceController.java index f6182f661e..88fd1ceeb6 100644 --- a/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceController.java +++ b/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceController.java @@ -48,8 +48,7 @@ public class TopLevelBatteryPreferenceController extends BasePreferenceControlle @Override public int getAvailabilityStatus() { return mContext.getResources().getBoolean(R.bool.config_show_top_level_battery) - ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } @Override diff --git a/src/com/android/settings/gestures/GestureSettings.java b/src/com/android/settings/gestures/GestureSettings.java index 763efaf9f1..76964e5e00 100644 --- a/src/com/android/settings/gestures/GestureSettings.java +++ b/src/com/android/settings/gestures/GestureSettings.java @@ -19,16 +19,12 @@ package com.android.settings.gestures; import android.app.settings.SettingsEnums; import android.content.Context; import android.hardware.display.AmbientDisplayConfiguration; -import android.provider.SearchIndexableResource; import com.android.settings.R; import com.android.settings.dashboard.DashboardFragment; import com.android.settings.search.BaseSearchIndexProvider; import com.android.settingslib.search.SearchIndexable; -import java.util.Arrays; -import java.util.List; - @SearchIndexable public class GestureSettings extends DashboardFragment { @@ -67,20 +63,5 @@ public class GestureSettings extends DashboardFragment { } public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = - new BaseSearchIndexProvider() { - @Override - public List<SearchIndexableResource> getXmlResourcesToIndex( - Context context, boolean enabled) { - final SearchIndexableResource sir = new SearchIndexableResource(context); - sir.xmlResId = R.xml.gestures; - return Arrays.asList(sir); - } - - @Override - protected boolean isPageSearchEnabled(Context context) { - // All rows in this screen can lead to a different page, so suppress everything - // from this page to remove duplicates. - return false; - } - }; + new BaseSearchIndexProvider(R.xml.gestures); } diff --git a/src/com/android/settings/gestures/PreventRingingParentPreferenceController.java b/src/com/android/settings/gestures/PreventRingingParentPreferenceController.java index afb3431526..7c7be09684 100644 --- a/src/com/android/settings/gestures/PreventRingingParentPreferenceController.java +++ b/src/com/android/settings/gestures/PreventRingingParentPreferenceController.java @@ -38,7 +38,7 @@ public class PreventRingingParentPreferenceController extends BasePreferenceCont public int getAvailabilityStatus() { return mContext.getResources().getBoolean( com.android.internal.R.bool.config_volumeHushGestureEnabled) - ? AVAILABLE_UNSEARCHABLE : UNSUPPORTED_ON_DEVICE; + ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } @Override diff --git a/src/com/android/settings/homepage/TopLevelSettings.java b/src/com/android/settings/homepage/TopLevelSettings.java index 8a7f4bdf43..e27e288716 100644 --- a/src/com/android/settings/homepage/TopLevelSettings.java +++ b/src/com/android/settings/homepage/TopLevelSettings.java @@ -100,12 +100,5 @@ public class TopLevelSettings extends DashboardFragment implements } public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = - new BaseSearchIndexProvider(R.xml.top_level_settings) { - - @Override - protected boolean isPageSearchEnabled(Context context) { - // Never searchable, all entries in this page are already indexed elsewhere. - return false; - } - }; + new BaseSearchIndexProvider(R.xml.top_level_settings); } diff --git a/src/com/android/settings/inputmethod/InputMethodPreferenceController.java b/src/com/android/settings/inputmethod/InputMethodPreferenceController.java index 5c5d0fb0e0..1b1103870b 100644 --- a/src/com/android/settings/inputmethod/InputMethodPreferenceController.java +++ b/src/com/android/settings/inputmethod/InputMethodPreferenceController.java @@ -30,10 +30,11 @@ import com.android.settingslib.core.lifecycle.LifecycleObserver; import com.android.settingslib.core.lifecycle.events.OnStart; import com.android.settingslib.inputmethod.InputMethodPreference; +import com.google.common.annotations.VisibleForTesting; + import java.text.Collator; import java.util.ArrayList; import java.util.List; -import com.google.common.annotations.VisibleForTesting; public class InputMethodPreferenceController extends BasePreferenceController implements LifecycleObserver, OnStart { @@ -52,7 +53,7 @@ public class InputMethodPreferenceController extends BasePreferenceController im @Override public int getAvailabilityStatus() { - return AVAILABLE_UNSEARCHABLE; + return AVAILABLE; } @Override diff --git a/src/com/android/settings/language/TtsPreferenceController.java b/src/com/android/settings/language/TtsPreferenceController.java index 7e34175ce9..6507785cda 100644 --- a/src/com/android/settings/language/TtsPreferenceController.java +++ b/src/com/android/settings/language/TtsPreferenceController.java @@ -38,7 +38,6 @@ public class TtsPreferenceController extends BasePreferenceController { public int getAvailabilityStatus() { return !mTtsEngines.getEngines().isEmpty() && mContext.getResources().getBoolean(R.bool.config_show_tts_settings_summary) - ? AVAILABLE_UNSEARCHABLE - : CONDITIONALLY_UNAVAILABLE; + ? AVAILABLE : CONDITIONALLY_UNAVAILABLE; } } diff --git a/src/com/android/settings/language/UserDictionaryPreferenceController.java b/src/com/android/settings/language/UserDictionaryPreferenceController.java index d7829c612b..27c47ed9b9 100644 --- a/src/com/android/settings/language/UserDictionaryPreferenceController.java +++ b/src/com/android/settings/language/UserDictionaryPreferenceController.java @@ -37,7 +37,7 @@ public class UserDictionaryPreferenceController extends BasePreferenceController @Override public int getAvailabilityStatus() { - return AVAILABLE_UNSEARCHABLE; + return AVAILABLE; } @Override diff --git a/src/com/android/settings/network/TopLevelNetworkEntryPreferenceController.java b/src/com/android/settings/network/TopLevelNetworkEntryPreferenceController.java index 11367367f7..f2e1312f0d 100644 --- a/src/com/android/settings/network/TopLevelNetworkEntryPreferenceController.java +++ b/src/com/android/settings/network/TopLevelNetworkEntryPreferenceController.java @@ -46,7 +46,7 @@ public class TopLevelNetworkEntryPreferenceController extends BasePreferenceCont @Override public int getAvailabilityStatus() { - return Utils.isDemoUser(mContext) ? UNSUPPORTED_ON_DEVICE : AVAILABLE_UNSEARCHABLE; + return Utils.isDemoUser(mContext) ? UNSUPPORTED_ON_DEVICE : AVAILABLE; } @Override diff --git a/src/com/android/settings/security/TopLevelSecurityEntryPreferenceController.java b/src/com/android/settings/security/TopLevelSecurityEntryPreferenceController.java index 4b00424068..4a4d34511d 100644 --- a/src/com/android/settings/security/TopLevelSecurityEntryPreferenceController.java +++ b/src/com/android/settings/security/TopLevelSecurityEntryPreferenceController.java @@ -32,7 +32,7 @@ public class TopLevelSecurityEntryPreferenceController extends BasePreferenceCon @Override public int getAvailabilityStatus() { - return AVAILABLE_UNSEARCHABLE; + return AVAILABLE; } @Override diff --git a/src/com/android/settings/security/screenlock/LockScreenPreferenceController.java b/src/com/android/settings/security/screenlock/LockScreenPreferenceController.java index 8cf0825d03..85854930dd 100644 --- a/src/com/android/settings/security/screenlock/LockScreenPreferenceController.java +++ b/src/com/android/settings/security/screenlock/LockScreenPreferenceController.java @@ -50,7 +50,7 @@ public class LockScreenPreferenceController extends BasePreferenceController imp @Override public int getAvailabilityStatus() { - return AVAILABLE_UNSEARCHABLE; + return AVAILABLE; } @Override diff --git a/src/com/android/settings/system/ResetPreferenceController.java b/src/com/android/settings/system/ResetPreferenceController.java index bbb5323ae6..09db32febb 100644 --- a/src/com/android/settings/system/ResetPreferenceController.java +++ b/src/com/android/settings/system/ResetPreferenceController.java @@ -38,8 +38,7 @@ public class ResetPreferenceController extends BasePreferenceController { @Override public int getAvailabilityStatus() { return mContext.getResources().getBoolean(R.bool.config_show_reset_dashboard) - ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } @Override diff --git a/src/com/android/settings/wfd/WifiDisplayPreferenceController.java b/src/com/android/settings/wfd/WifiDisplayPreferenceController.java index 32273878b7..a83a56b594 100644 --- a/src/com/android/settings/wfd/WifiDisplayPreferenceController.java +++ b/src/com/android/settings/wfd/WifiDisplayPreferenceController.java @@ -69,8 +69,7 @@ public class WifiDisplayPreferenceController extends BasePreferenceController im @Override public int getAvailabilityStatus() { - return WifiDisplaySettings.isAvailable(mContext) ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + return WifiDisplaySettings.isAvailable(mContext) ? AVAILABLE : UNSUPPORTED_ON_DEVICE; } @Override @@ -104,4 +103,4 @@ public class WifiDisplayPreferenceController extends BasePreferenceController im public void onStop() { mRouter.removeCallback(mRouterCallback); } -}
\ No newline at end of file +} diff --git a/src/com/android/settings/wifi/WifiSettings.java b/src/com/android/settings/wifi/WifiSettings.java index 488aadbafb..5b8bbe34e0 100644 --- a/src/com/android/settings/wifi/WifiSettings.java +++ b/src/com/android/settings/wifi/WifiSettings.java @@ -27,7 +27,6 @@ import android.content.ContentResolver; import android.content.Context; import android.content.DialogInterface; import android.content.Intent; -import android.content.res.Resources; import android.net.ConnectivityManager; import android.net.Network; import android.net.NetworkInfo; @@ -73,7 +72,6 @@ import com.android.settingslib.RestrictedLockUtils; import com.android.settingslib.RestrictedLockUtilsInternal; import com.android.settingslib.search.Indexable; import com.android.settingslib.search.SearchIndexable; -import com.android.settingslib.search.SearchIndexableRaw; import com.android.settingslib.wifi.AccessPoint; import com.android.settingslib.wifi.AccessPoint.AccessPointListener; import com.android.settingslib.wifi.AccessPointPreference; @@ -81,7 +79,6 @@ import com.android.settingslib.wifi.WifiSavedConfigUtils; import com.android.settingslib.wifi.WifiTracker; import com.android.settingslib.wifi.WifiTrackerFactory; -import java.util.ArrayList; import java.util.List; /** @@ -193,9 +190,6 @@ public class WifiSettings extends RestrictedSettingsFragment DataUsagePreference mDataUsagePreference; private LinkablePreference mStatusMessagePreference; - // For Search - public static final String DATA_KEY_REFERENCE = "main_toggle_wifi"; - /** * Tracks whether the user initiated a connection via clicking in order to autoscroll to the * network once connected. @@ -1244,24 +1238,6 @@ public class WifiSettings extends RestrictedSettingsFragment public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = new BaseSearchIndexProvider(R.xml.wifi_settings) { @Override - public List<SearchIndexableRaw> getRawDataToIndex(Context context, - boolean enabled) { - final List<SearchIndexableRaw> result = new ArrayList<>(); - final Resources res = context.getResources(); - - // Add fragment title if we are showing this fragment - if (res.getBoolean(R.bool.config_show_wifi_settings)) { - SearchIndexableRaw data = new SearchIndexableRaw(context); - data.title = res.getString(R.string.wifi_settings); - data.screenTitle = res.getString(R.string.wifi_settings); - data.keywords = res.getString(R.string.keywords_wifi); - data.key = DATA_KEY_REFERENCE; - result.add(data); - } - return result; - } - - @Override public List<String> getNonIndexableKeys(Context context) { final List<String> keys = super.getNonIndexableKeys(context); diff --git a/src/com/android/settings/wifi/WifiSettings2.java b/src/com/android/settings/wifi/WifiSettings2.java index 932f5d9177..d21cec0fe4 100644 --- a/src/com/android/settings/wifi/WifiSettings2.java +++ b/src/com/android/settings/wifi/WifiSettings2.java @@ -25,7 +25,6 @@ import android.content.ContentResolver; import android.content.Context; import android.content.DialogInterface; import android.content.Intent; -import android.content.res.Resources; import android.net.ConnectivityManager; import android.net.NetworkScoreManager; import android.net.NetworkTemplate; @@ -73,7 +72,6 @@ import com.android.settingslib.RestrictedLockUtils; import com.android.settingslib.RestrictedLockUtilsInternal; import com.android.settingslib.search.Indexable; import com.android.settingslib.search.SearchIndexable; -import com.android.settingslib.search.SearchIndexableRaw; import com.android.settingslib.wifi.LongPressWifiEntryPreference; import com.android.wifitrackerlib.WifiEntry; import com.android.wifitrackerlib.WifiEntry.ConnectCallback; @@ -81,7 +79,6 @@ import com.android.wifitrackerlib.WifiPickerTracker; import java.time.Clock; import java.time.ZoneOffset; -import java.util.ArrayList; import java.util.List; import java.util.Optional; @@ -198,9 +195,6 @@ public class WifiSettings2 extends RestrictedSettingsFragment DataUsagePreference mDataUsagePreference; private LinkablePreference mStatusMessagePreference; - // For Search - public static final String DATA_KEY_REFERENCE = "main_toggle_wifi"; - /** * Tracks whether the user initiated a connection via clicking in order to autoscroll to the * network once connected. @@ -1019,26 +1013,7 @@ public class WifiSettings2 extends RestrictedSettingsFragment }; public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = - new BaseSearchIndexProvider() { - @Override - public List<SearchIndexableRaw> getRawDataToIndex(Context context, - boolean enabled) { - final List<SearchIndexableRaw> result = new ArrayList<>(); - final Resources res = context.getResources(); - - // Add fragment title if we are showing this fragment - if (res.getBoolean(R.bool.config_show_wifi_settings)) { - SearchIndexableRaw data = new SearchIndexableRaw(context); - data.title = res.getString(R.string.wifi_settings); - data.screenTitle = res.getString(R.string.wifi_settings); - data.keywords = res.getString(R.string.keywords_wifi); - data.key = DATA_KEY_REFERENCE; - result.add(data); - } - - return result; - } - }; + new BaseSearchIndexProvider(R.xml.wifi_settings2); private class WifiEntryConnectCallback implements ConnectCallback { final WifiEntry mConnectWifiEntry; diff --git a/tests/robotests/src/com/android/settings/accessibility/AutoclickPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/accessibility/AutoclickPreferenceControllerTest.java index b8be23efff..d670ee8e78 100644 --- a/tests/robotests/src/com/android/settings/accessibility/AutoclickPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/accessibility/AutoclickPreferenceControllerTest.java @@ -46,7 +46,7 @@ public class AutoclickPreferenceControllerTest { @Test public void getAvailabilityStatus_shouldReturnAvailableUnsearchable() { assertThat(mController.getAvailabilityStatus()) - .isEqualTo(BasePreferenceController.AVAILABLE_UNSEARCHABLE); + .isEqualTo(BasePreferenceController.AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/accessibility/TopLevelAccessibilityPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/accessibility/TopLevelAccessibilityPreferenceControllerTest.java index 809d8b454a..3acc02c4c1 100644 --- a/tests/robotests/src/com/android/settings/accessibility/TopLevelAccessibilityPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/accessibility/TopLevelAccessibilityPreferenceControllerTest.java @@ -16,23 +16,19 @@ package com.android.settings.accessibility; -import static com.android.settings.core.BasePreferenceController.AVAILABLE_UNSEARCHABLE; +import static com.android.settings.core.BasePreferenceController.AVAILABLE; import static com.android.settings.core.BasePreferenceController.UNSUPPORTED_ON_DEVICE; import static com.google.common.truth.Truth.assertThat; import android.content.Context; -import com.android.settings.R; - import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; import org.robolectric.RobolectricTestRunner; import org.robolectric.RuntimeEnvironment; import org.robolectric.annotation.Config; -import org.robolectric.annotation.Implementation; -import org.robolectric.annotation.Implements; @RunWith(RobolectricTestRunner.class) public class TopLevelAccessibilityPreferenceControllerTest { @@ -48,7 +44,7 @@ public class TopLevelAccessibilityPreferenceControllerTest { @Test public void getAvailibilityStatus_availableByDefault() { - assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE); + assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/applications/SpecialAppAccessPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/applications/SpecialAppAccessPreferenceControllerTest.java index 75302d837c..00d3cb119f 100644 --- a/tests/robotests/src/com/android/settings/applications/SpecialAppAccessPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/applications/SpecialAppAccessPreferenceControllerTest.java @@ -16,7 +16,7 @@ package com.android.settings.applications; -import static com.android.settings.core.BasePreferenceController.AVAILABLE_UNSEARCHABLE; +import static com.android.settings.core.BasePreferenceController.AVAILABLE; import static com.google.common.truth.Truth.assertThat; @@ -83,7 +83,7 @@ public class SpecialAppAccessPreferenceControllerTest { @Test public void getAvailabilityState_unsearchable() { - assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE); + assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/applications/specialaccess/premiumsms/PremiumSmsControllerTest.java b/tests/robotests/src/com/android/settings/applications/specialaccess/premiumsms/PremiumSmsControllerTest.java index 0607e58985..4c4acc719a 100644 --- a/tests/robotests/src/com/android/settings/applications/specialaccess/premiumsms/PremiumSmsControllerTest.java +++ b/tests/robotests/src/com/android/settings/applications/specialaccess/premiumsms/PremiumSmsControllerTest.java @@ -16,7 +16,7 @@ package com.android.settings.applications.specialaccess.premiumsms; -import static com.android.settings.core.BasePreferenceController.AVAILABLE_UNSEARCHABLE; +import static com.android.settings.core.BasePreferenceController.AVAILABLE; import static com.google.common.truth.Truth.assertThat; @@ -47,7 +47,7 @@ public class PremiumSmsControllerTest { @Test public void getAvailability_byDefault_shouldBeShown() { - assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE); + assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/applications/specialaccess/vrlistener/EnabledVrListenersControllerTest.java b/tests/robotests/src/com/android/settings/applications/specialaccess/vrlistener/EnabledVrListenersControllerTest.java index 32b18efafe..5f102a01cb 100644 --- a/tests/robotests/src/com/android/settings/applications/specialaccess/vrlistener/EnabledVrListenersControllerTest.java +++ b/tests/robotests/src/com/android/settings/applications/specialaccess/vrlistener/EnabledVrListenersControllerTest.java @@ -16,7 +16,7 @@ package com.android.settings.applications.specialaccess.vrlistener; -import static com.android.settings.core.BasePreferenceController.AVAILABLE_UNSEARCHABLE; +import static com.android.settings.core.BasePreferenceController.AVAILABLE; import static com.android.settings.core.BasePreferenceController.UNSUPPORTED_ON_DEVICE; import static com.google.common.truth.Truth.assertThat; @@ -48,7 +48,7 @@ public class EnabledVrListenersControllerTest { @Test public void getAvailability_byDefault_unsearchable() { - assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE); + assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/connecteddevice/AdvancedConnectedDeviceDashboardFragmentTest.java b/tests/robotests/src/com/android/settings/connecteddevice/AdvancedConnectedDeviceDashboardFragmentTest.java index 3fa0e4d9aa..d6bcb12766 100644 --- a/tests/robotests/src/com/android/settings/connecteddevice/AdvancedConnectedDeviceDashboardFragmentTest.java +++ b/tests/robotests/src/com/android/settings/connecteddevice/AdvancedConnectedDeviceDashboardFragmentTest.java @@ -16,6 +16,7 @@ package com.android.settings.connecteddevice; import static com.google.common.truth.Truth.assertThat; + import static org.mockito.Mockito.spy; import static org.mockito.Mockito.when; @@ -23,6 +24,7 @@ import android.content.Context; import android.nfc.NfcAdapter; import android.provider.SearchIndexableResource; +import com.android.settings.nfc.AndroidBeamPreferenceController; import com.android.settings.testutils.shadow.ShadowConnectivityManager; import com.android.settings.testutils.shadow.ShadowUserManager; import com.android.settingslib.drawer.CategoryKey; @@ -85,6 +87,6 @@ public class AdvancedConnectedDeviceDashboardFragmentTest { AdvancedConnectedDeviceDashboardFragment.SEARCH_INDEX_DATA_PROVIDER .getNonIndexableKeys(context); - assertThat(niks).contains(AdvancedConnectedDeviceDashboardFragment.KEY_BLUETOOTH); + assertThat(niks).contains(AndroidBeamPreferenceController.KEY_ANDROID_BEAM_SETTINGS); } }
\ No newline at end of file diff --git a/tests/robotests/src/com/android/settings/connecteddevice/BluetoothDashboardFragmentTest.java b/tests/robotests/src/com/android/settings/connecteddevice/BluetoothDashboardFragmentTest.java deleted file mode 100644 index ed944cf2cd..0000000000 --- a/tests/robotests/src/com/android/settings/connecteddevice/BluetoothDashboardFragmentTest.java +++ /dev/null @@ -1,57 +0,0 @@ -/* - * Copyright (C) 2018 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License - */ - -package com.android.settings.connecteddevice; - -import static com.google.common.truth.Truth.assertThat; - -import android.content.Context; -import android.text.TextUtils; - -import com.android.settings.R; -import com.android.settingslib.search.SearchIndexableRaw; - -import org.junit.Before; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.robolectric.RobolectricTestRunner; -import org.robolectric.RuntimeEnvironment; - -import java.util.List; - -@RunWith(RobolectricTestRunner.class) -public class BluetoothDashboardFragmentTest { - - private Context mContext; - - @Before - public void setUp() { - mContext = RuntimeEnvironment.application; - } - - @Test - public void rawData_includesFragmentResult() { - final List<SearchIndexableRaw> rawList = - BluetoothDashboardFragment.SEARCH_INDEX_DATA_PROVIDER.getRawDataToIndex(mContext, - true /* enabled */); - - final SearchIndexableRaw fragmentResult = rawList.stream().filter( - raw -> TextUtils.equals(raw.title, - mContext.getString(R.string.bluetooth_settings))).findFirst().get(); - - assertThat(fragmentResult).isNotNull(); - } -} diff --git a/tests/robotests/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragmentTest.java b/tests/robotests/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragmentTest.java index 778bb79c5b..c4f1587450 100644 --- a/tests/robotests/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragmentTest.java +++ b/tests/robotests/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragmentTest.java @@ -52,6 +52,7 @@ import java.util.List; public class ConnectedDeviceDashboardFragmentTest { private static final String KEY_NEARBY_DEVICES = "bt_nearby_slice"; private static final String KEY_DISCOVERABLE_FOOTER = "discoverable_footer"; + private static final String KEY_SEE_ALL = "previously_connected_devices_see_all"; @Mock private PackageManager mPackageManager; @@ -82,7 +83,7 @@ public class ConnectedDeviceDashboardFragmentTest { .getNonIndexableKeys(mContext); assertThat(niks).containsExactly(KEY_CONNECTED_DEVICES, KEY_AVAILABLE_DEVICES, - KEY_NEARBY_DEVICES, KEY_DISCOVERABLE_FOOTER); + KEY_NEARBY_DEVICES, KEY_DISCOVERABLE_FOOTER, KEY_SEE_ALL); } @Test diff --git a/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java index ab733701cd..14fe4bd19e 100644 --- a/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java @@ -16,7 +16,7 @@ package com.android.settings.connecteddevice; -import static com.android.settings.core.BasePreferenceController.AVAILABLE_UNSEARCHABLE; +import static com.android.settings.core.BasePreferenceController.AVAILABLE; import static com.android.settings.core.BasePreferenceController.UNSUPPORTED_ON_DEVICE; import static com.google.common.truth.Truth.assertThat; @@ -48,7 +48,7 @@ public class TopLevelConnectedDevicesPreferenceControllerTest { @Test public void getAvailibilityStatus_availableByDefault() { - assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE); + assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/core/PreferenceXmlParserUtilsTest.java b/tests/robotests/src/com/android/settings/core/PreferenceXmlParserUtilsTest.java index 9ad6a7b9af..41e1ab181e 100644 --- a/tests/robotests/src/com/android/settings/core/PreferenceXmlParserUtilsTest.java +++ b/tests/robotests/src/com/android/settings/core/PreferenceXmlParserUtilsTest.java @@ -76,10 +76,11 @@ public class PreferenceXmlParserUtilsTest { @Test public void testDataKeywordsValid_ReturnsPreferenceKeywords() { - XmlResourceParser parser = getParentPrimedParser(R.xml.display_settings); + XmlResourceParser parser = getChildByType(R.xml.display_settings, + "com.android.settings.display.TimeoutListPreference"); final AttributeSet attrs = Xml.asAttributeSet(parser); String keywords = PreferenceXmlParserUtils.getDataKeywords(mContext, attrs); - String expKeywords = mContext.getString(R.string.keywords_display); + String expKeywords = mContext.getString(R.string.keywords_screen_timeout); assertThat(keywords).isEqualTo(expKeywords); } diff --git a/tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerTest.java index 77ae4e2589..d000c912b9 100644 --- a/tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionPreferenceControllerTest.java @@ -58,7 +58,7 @@ public class FirmwareVersionPreferenceControllerTest { @Test public void firmwareVersion_shouldAlwaysBeShown() { assertThat(mController.getAvailabilityStatus()) - .isEqualTo(BasePreferenceController.AVAILABLE_UNSEARCHABLE); + .isEqualTo(BasePreferenceController.AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/deviceinfo/hardwareinfo/HardwareInfoPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/deviceinfo/hardwareinfo/HardwareInfoPreferenceControllerTest.java index 413c4921bb..291f6e28fe 100644 --- a/tests/robotests/src/com/android/settings/deviceinfo/hardwareinfo/HardwareInfoPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/deviceinfo/hardwareinfo/HardwareInfoPreferenceControllerTest.java @@ -61,7 +61,7 @@ public class HardwareInfoPreferenceControllerTest { @Test public void isAvailable_returnTrueIfVisible() { assertThat(mController.getAvailabilityStatus()).isEqualTo( - BasePreferenceController.AVAILABLE_UNSEARCHABLE); + BasePreferenceController.AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/display/FontSizePreferenceControllerTest.java b/tests/robotests/src/com/android/settings/display/FontSizePreferenceControllerTest.java index 888b711efc..58e7ccd564 100644 --- a/tests/robotests/src/com/android/settings/display/FontSizePreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/display/FontSizePreferenceControllerTest.java @@ -49,7 +49,7 @@ public class FontSizePreferenceControllerTest { @Test public void isAlwaysAvailable() { assertThat(mController.getAvailabilityStatus()) - .isEqualTo(BasePreferenceController.AVAILABLE_UNSEARCHABLE); + .isEqualTo(BasePreferenceController.AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceControllerTest.java index 58ed6b46d7..37758029bc 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceControllerTest.java @@ -16,7 +16,7 @@ package com.android.settings.fuelgauge; -import static com.android.settings.core.BasePreferenceController.AVAILABLE_UNSEARCHABLE; +import static com.android.settings.core.BasePreferenceController.AVAILABLE; import static com.android.settings.core.BasePreferenceController.UNSUPPORTED_ON_DEVICE; import static com.android.settings.fuelgauge.TopLevelBatteryPreferenceController.getDashboardLabel; @@ -27,9 +27,9 @@ import android.content.Context; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; -import org.robolectric.annotation.Config; import org.robolectric.RobolectricTestRunner; import org.robolectric.RuntimeEnvironment; +import org.robolectric.annotation.Config; @RunWith(RobolectricTestRunner.class) public class TopLevelBatteryPreferenceControllerTest { @@ -44,7 +44,7 @@ public class TopLevelBatteryPreferenceControllerTest { @Test public void getAvailibilityStatus_availableByDefault() { - assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE); + assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/gestures/AssistGestureSettingsTest.java b/tests/robotests/src/com/android/settings/gestures/AssistGestureSettingsTest.java index d6c6a1f8f5..17db208f78 100644 --- a/tests/robotests/src/com/android/settings/gestures/AssistGestureSettingsTest.java +++ b/tests/robotests/src/com/android/settings/gestures/AssistGestureSettingsTest.java @@ -72,6 +72,6 @@ public class AssistGestureSettingsTest { assertThat(AssistGestureSettings.SEARCH_INDEX_DATA_PROVIDER.getNonIndexableKeys( RuntimeEnvironment.application)) - .contains("gesture_assist_settings_page"); + .isNotEmpty(); } } diff --git a/tests/robotests/src/com/android/settings/gestures/PreventRingingParentPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/gestures/PreventRingingParentPreferenceControllerTest.java index 07716859a1..c752eb9823 100644 --- a/tests/robotests/src/com/android/settings/gestures/PreventRingingParentPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/gestures/PreventRingingParentPreferenceControllerTest.java @@ -21,7 +21,7 @@ import static android.provider.Settings.Secure.VOLUME_HUSH_MUTE; import static android.provider.Settings.Secure.VOLUME_HUSH_OFF; import static android.provider.Settings.Secure.VOLUME_HUSH_VIBRATE; -import static com.android.settings.core.BasePreferenceController.AVAILABLE_UNSEARCHABLE; +import static com.android.settings.core.BasePreferenceController.AVAILABLE; import static com.google.common.truth.Truth.assertThat; @@ -64,7 +64,7 @@ public class PreventRingingParentPreferenceControllerTest { when(mResources.getBoolean( com.android.internal.R.bool.config_volumeHushGestureEnabled)).thenReturn(true); - assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE); + assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/nfc/PaymentSettingsTest.java b/tests/robotests/src/com/android/settings/nfc/PaymentSettingsTest.java index 513da65e3c..525f3efd3b 100644 --- a/tests/robotests/src/com/android/settings/nfc/PaymentSettingsTest.java +++ b/tests/robotests/src/com/android/settings/nfc/PaymentSettingsTest.java @@ -53,7 +53,6 @@ public class PaymentSettingsTest { static final String PAYMENT_KEY = "nfc_payment"; static final String FOREGROUND_KEY = "nfc_foreground"; - static final String PAYMENT_SCREEN_KEY = "nfc_payment_settings_screen"; private Context mContext; @@ -107,14 +106,14 @@ public class PaymentSettingsTest { } @Test - public void getNonIndexabkeKey_guestUser_returnsFalse() { + public void getNonIndexableKey_guestUser_returnsFalse() { when(mPackageManager.hasSystemFeature(PackageManager.FEATURE_NFC)).thenReturn(true); when(mUserInfo.isGuest()).thenReturn(true); final List<String> niks = PaymentSettings.SEARCH_INDEX_DATA_PROVIDER.getNonIndexableKeys(mContext); - assertThat(niks).containsAllOf(FOREGROUND_KEY, PAYMENT_KEY, PAYMENT_SCREEN_KEY); + assertThat(niks).containsAllOf(FOREGROUND_KEY, PAYMENT_KEY); } @Test diff --git a/tests/robotests/src/com/android/settings/security/InstallCertificateFromStorageTest.java b/tests/robotests/src/com/android/settings/security/InstallCertificateFromStorageTest.java index 03bdb08880..8484ebf365 100644 --- a/tests/robotests/src/com/android/settings/security/InstallCertificateFromStorageTest.java +++ b/tests/robotests/src/com/android/settings/security/InstallCertificateFromStorageTest.java @@ -62,7 +62,6 @@ public class InstallCertificateFromStorageTest { private void setUpTestKeys() { mTestKeys = new ArrayList<>(); - mTestKeys.add("install_certificate_from_storage"); mTestKeys.add("certificate_types"); mTestKeys.add("install_ca_certificate"); mTestKeys.add("install_user_certificate"); diff --git a/tests/robotests/src/com/android/settings/security/screenlock/LockScreenPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/security/screenlock/LockScreenPreferenceControllerTest.java index 36eadbac60..17bef3c4e9 100644 --- a/tests/robotests/src/com/android/settings/security/screenlock/LockScreenPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/security/screenlock/LockScreenPreferenceControllerTest.java @@ -21,7 +21,7 @@ import static android.app.admin.DevicePolicyManager.PASSWORD_QUALITY_UNSPECIFIED import static androidx.lifecycle.Lifecycle.Event.ON_RESUME; -import static com.android.settings.core.BasePreferenceController.AVAILABLE_UNSEARCHABLE; +import static com.android.settings.core.BasePreferenceController.AVAILABLE; import static com.google.common.truth.Truth.assertThat; @@ -90,7 +90,7 @@ public class LockScreenPreferenceControllerTest { when(mLockPatternUtils.isSecure(anyInt())).thenReturn(false); when(mLockPatternUtils.isLockScreenDisabled(anyInt())).thenReturn(true); - assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE); + assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test @@ -98,7 +98,7 @@ public class LockScreenPreferenceControllerTest { when(mLockPatternUtils.isSecure(anyInt())).thenReturn(false); when(mLockPatternUtils.isLockScreenDisabled(anyInt())).thenReturn(false); - assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE); + assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test @@ -107,7 +107,7 @@ public class LockScreenPreferenceControllerTest { when(mLockPatternUtils.getKeyguardStoredPasswordQuality(anyInt())) .thenReturn(PASSWORD_QUALITY_ALPHABETIC); - assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE); + assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test @@ -116,7 +116,7 @@ public class LockScreenPreferenceControllerTest { when(mLockPatternUtils.getKeyguardStoredPasswordQuality(anyInt())) .thenReturn(PASSWORD_QUALITY_UNSPECIFIED); - assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE); + assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test diff --git a/tests/robotests/src/com/android/settings/wifi/WifiSettings2Test.java b/tests/robotests/src/com/android/settings/wifi/WifiSettings2Test.java index eb4f3269dd..320d767dcd 100644 --- a/tests/robotests/src/com/android/settings/wifi/WifiSettings2Test.java +++ b/tests/robotests/src/com/android/settings/wifi/WifiSettings2Test.java @@ -49,7 +49,6 @@ import com.android.settings.R; import com.android.settings.datausage.DataUsagePreference; import com.android.settings.testutils.shadow.ShadowDataUsageUtils; import com.android.settings.testutils.shadow.ShadowFragment; -import com.android.settingslib.search.SearchIndexableRaw; import com.android.settingslib.wifi.LongPressWifiEntryPreference; import com.android.wifitrackerlib.WifiEntry; import com.android.wifitrackerlib.WifiPickerTracker; @@ -64,8 +63,6 @@ import org.robolectric.RobolectricTestRunner; import org.robolectric.RuntimeEnvironment; import org.robolectric.annotation.Config; -import java.util.List; - @RunWith(RobolectricTestRunner.class) public class WifiSettings2Test { @@ -95,26 +92,6 @@ public class WifiSettings2Test { } @Test - public void testSearchIndexProvider_shouldIndexFragmentTitle() { - final List<SearchIndexableRaw> indexRes = - WifiSettings.SEARCH_INDEX_DATA_PROVIDER.getRawDataToIndex(mContext, - true /* enabled */); - - assertThat(indexRes).isNotNull(); - assertThat(indexRes.get(0).key).isEqualTo(WifiSettings.DATA_KEY_REFERENCE); - } - - @Test - @Config(qualifiers = "mcc999") - public void testSearchIndexProvider_ifWifiSettingsNotVisible_shouldNotIndexFragmentTitle() { - final List<SearchIndexableRaw> indexRes = - WifiSettings.SEARCH_INDEX_DATA_PROVIDER.getRawDataToIndex(mContext, - true /* enabled */); - - assertThat(indexRes).isEmpty(); - } - - @Test public void addNetworkFragmentSendResult_onActivityResult_shouldHandleEvent() { final WifiSettings wifiSettings = spy(new WifiSettings()); final Intent intent = new Intent(); diff --git a/tests/robotests/src/com/android/settings/wifi/WifiSettingsTest.java b/tests/robotests/src/com/android/settings/wifi/WifiSettingsTest.java index 2fe7c5ca1b..5145cc15fc 100644 --- a/tests/robotests/src/com/android/settings/wifi/WifiSettingsTest.java +++ b/tests/robotests/src/com/android/settings/wifi/WifiSettingsTest.java @@ -52,7 +52,6 @@ import com.android.settings.R; import com.android.settings.datausage.DataUsagePreference; import com.android.settings.testutils.shadow.ShadowDataUsageUtils; import com.android.settings.testutils.shadow.ShadowFragment; -import com.android.settingslib.search.SearchIndexableRaw; import com.android.settingslib.wifi.AccessPoint; import com.android.settingslib.wifi.WifiTracker; @@ -100,26 +99,6 @@ public class WifiSettingsTest { } @Test - public void testSearchIndexProvider_shouldIndexFragmentTitle() { - final List<SearchIndexableRaw> indexRes = - WifiSettings.SEARCH_INDEX_DATA_PROVIDER.getRawDataToIndex(mContext, - true /* enabled */); - - assertThat(indexRes).isNotNull(); - assertThat(indexRes.get(0).key).isEqualTo(WifiSettings.DATA_KEY_REFERENCE); - } - - @Test - @Config(qualifiers = "mcc999") - public void testSearchIndexProvider_ifWifiSettingsNotVisible_shouldNotIndexFragmentTitle() { - final List<SearchIndexableRaw> indexRes = - WifiSettings.SEARCH_INDEX_DATA_PROVIDER.getRawDataToIndex(mContext, - true /* enabled */); - - assertThat(indexRes).isEmpty(); - } - - @Test public void addNetworkFragmentSendResult_onActivityResult_shouldHandleEvent() { final WifiSettings wifiSettings = spy(new WifiSettings()); final Intent intent = new Intent(); |