diff options
author | Arnd Bergmann <arnd@arndb.de> | 2021-01-25 12:36:42 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-02-17 11:02:25 +0100 |
commit | 3ade81db49bdb1e3b4a2495ba4ef1ccde7dde2c1 (patch) | |
tree | f1daefecf95a07c7de34afa10b126e9ced1de81a /kernel/trace/synth_event_gen_test.c | |
parent | c39cdf559d264f2fb0a450cd5dc18e534732b251 (diff) | |
download | kernel_replicant_linux-3ade81db49bdb1e3b4a2495ba4ef1ccde7dde2c1.tar.gz kernel_replicant_linux-3ade81db49bdb1e3b4a2495ba4ef1ccde7dde2c1.tar.bz2 kernel_replicant_linux-3ade81db49bdb1e3b4a2495ba4ef1ccde7dde2c1.zip |
ath9k: fix build error with LEDS_CLASS=m
[ Upstream commit b64acb28da8394485f0762e657470c9fc33aca4d ]
When CONFIG_ATH9K is built-in but LED support is in a loadable
module, both ath9k drivers fails to link:
x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function `ath_deinit_leds':
gpio.c:(.text+0x36): undefined reference to `led_classdev_unregister'
x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function `ath_init_leds':
gpio.c:(.text+0x179): undefined reference to `led_classdev_register_ext'
The problem is that the 'imply' keyword does not enforce any dependency
but is only a weak hint to Kconfig to enable another symbol from a
defconfig file.
Change imply to a 'depends on LEDS_CLASS' that prevents the incorrect
configuration but still allows building the driver without LED support.
The 'select MAC80211_LEDS' is now ensures that the LED support is
actually used if it is present, and the added Kconfig dependency
on MAC80211_LEDS ensures that it cannot be enabled manually when it
has no effect.
Fixes: 197f466e93f5 ("ath9k_htc: Do not select MAC80211_LEDS by default")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210125113654.2408057-1-arnd@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'kernel/trace/synth_event_gen_test.c')
0 files changed, 0 insertions, 0 deletions