diff options
| author | Nanyong Sun <sunnanyong@huawei.com> | 2021-09-07 20:00:15 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-26 14:09:01 +0200 |
| commit | 5acb21e30d85f90b658bae7fb3f53b5e42952292 (patch) | |
| tree | 5b36b2143dac5e78c358a3a4fb5423e4d016abb5 /fs/nilfs2/sysfs.c | |
| parent | 0480f7a480bccdd5e747e64365b703105ccae350 (diff) | |
| download | kernel_replicant_linux-5acb21e30d85f90b658bae7fb3f53b5e42952292.tar.gz kernel_replicant_linux-5acb21e30d85f90b658bae7fb3f53b5e42952292.tar.bz2 kernel_replicant_linux-5acb21e30d85f90b658bae7fb3f53b5e42952292.zip | |
nilfs2: fix memory leak in nilfs_sysfs_create_##name##_group
[ Upstream commit 24f8cb1ed057c840728167dab33b32e44147c86f ]
If kobject_init_and_add return with error, kobject_put() is needed here to
avoid memory leak, because kobject_init_and_add may return error without
freeing the memory associated with the kobject it allocated.
Link: https://lkml.kernel.org/r/20210629022556.3985106-4-sunnanyong@huawei.com
Link: https://lkml.kernel.org/r/1625651306-10829-4-git-send-email-konishi.ryusuke@gmail.com
Signed-off-by: Nanyong Sun <sunnanyong@huawei.com>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs/nilfs2/sysfs.c')
| -rw-r--r-- | fs/nilfs2/sysfs.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c index 43f660beb9b4..5dc468ff5903 100644 --- a/fs/nilfs2/sysfs.c +++ b/fs/nilfs2/sysfs.c @@ -92,8 +92,8 @@ static int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \ err = kobject_init_and_add(kobj, &nilfs_##name##_ktype, parent, \ #name); \ if (err) \ - return err; \ - return 0; \ + kobject_put(kobj); \ + return err; \ } \ static void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \ { \ |