diff options
| author | Jaegeuk Kim <jaegeuk@kernel.org> | 2021-08-30 13:30:45 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-18 13:40:16 +0200 |
| commit | bb8108546da97d7c66a8abe93af5ce04b68b509e (patch) | |
| tree | 4711cdc3c476ce7095e16a7278ae5a1cb9ca78a3 /fs/f2fs | |
| parent | d04925fb8d7081108fba1ea21ce7a6d14e64eabd (diff) | |
| download | kernel_replicant_linux-bb8108546da97d7c66a8abe93af5ce04b68b509e.tar.gz kernel_replicant_linux-bb8108546da97d7c66a8abe93af5ce04b68b509e.tar.bz2 kernel_replicant_linux-bb8108546da97d7c66a8abe93af5ce04b68b509e.zip | |
f2fs: should put a page beyond EOF when preparing a write
[ Upstream commit 9605f75cf36e0bcc0f4ada07b5be712d30107607 ]
The prepare_compress_overwrite() gets/locks a page to prepare a read, and calls
f2fs_read_multi_pages() which checks EOF first. If there's any page beyond EOF,
we unlock the page and set cc->rpages[i] = NULL, which we can't put the page
anymore. This makes page leak, so let's fix by putting that page.
Fixes: a949dc5f2c5c ("f2fs: compress: fix race condition of overwrite vs truncate")
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs/f2fs')
| -rw-r--r-- | fs/f2fs/data.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 70a91c47f72f..1b11a42847c4 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2219,6 +2219,8 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret, continue; } unlock_page(page); + if (for_write) + put_page(page); cc->rpages[i] = NULL; cc->nr_rpages--; } |