diff options
author | Arnd Bergmann <arnd@arndb.de> | 2019-03-22 15:25:49 +0100 |
---|---|---|
committer | Martin K. Petersen <martin.petersen@oracle.com> | 2019-03-25 22:17:26 -0400 |
commit | faf5a744f4f8d76e7c03912b5cd381ac8045f6ec (patch) | |
tree | f0468e4fdfd572c5686311a5f8e837480fca9275 /drivers/scsi/qla4xxx/ql4_os.c | |
parent | e7f7b6f38a44697428f5a2e7c606de028df2b0e3 (diff) | |
download | kernel_replicant_linux-faf5a744f4f8d76e7c03912b5cd381ac8045f6ec.tar.gz kernel_replicant_linux-faf5a744f4f8d76e7c03912b5cd381ac8045f6ec.tar.bz2 kernel_replicant_linux-faf5a744f4f8d76e7c03912b5cd381ac8045f6ec.zip |
scsi: lpfc: avoid uninitialized variable warning
clang -Wuninitialized incorrectly sees a variable being used without
initialization:
drivers/scsi/lpfc/lpfc_nvme.c:2102:37: error: variable 'localport' is uninitialized when used here
[-Werror,-Wuninitialized]
lport = (struct lpfc_nvme_lport *)localport->private;
^~~~~~~~~
drivers/scsi/lpfc/lpfc_nvme.c:2059:38: note: initialize the variable 'localport' to silence this warning
struct nvme_fc_local_port *localport;
^
= NULL
1 error generated.
This is clearly in dead code, as the condition leading up to it is always
false when CONFIG_NVME_FC is disabled, and the variable is always
initialized when nvme_fc_register_localport() got called successfully.
Change the preprocessor conditional to the equivalent C construct, which
makes the code more readable and gets rid of the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/qla4xxx/ql4_os.c')
0 files changed, 0 insertions, 0 deletions