diff options
| author | Srinivas Neeli <srinivas.neeli@xilinx.com> | 2021-04-09 19:38:06 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-07-20 16:05:43 +0200 |
| commit | b3d3a2466e749168410f92c574d0d0cacd98411b (patch) | |
| tree | 6d3f82f2a40612ffa828cc5681aa49545de23b70 /drivers/gpio | |
| parent | 3d2b0818daa421b1619cf3bf5f2b2a6788cebcf2 (diff) | |
| download | kernel_replicant_linux-b3d3a2466e749168410f92c574d0d0cacd98411b.tar.gz kernel_replicant_linux-b3d3a2466e749168410f92c574d0d0cacd98411b.tar.bz2 kernel_replicant_linux-b3d3a2466e749168410f92c574d0d0cacd98411b.zip | |
gpio: zynq: Check return value of irq_get_irq_data
[ Upstream commit 35d7b72a632bc7afb15356f44005554af8697904 ]
In two different instances the return value of "irq_get_irq_data"
API was neither captured nor checked.
Fixed it by capturing the return value and then checking for any error.
Addresses-Coverity: "returned_null"
Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-zynq.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index fb8684d70fe3..c288a7502de2 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers/gpio/gpio-zynq.c @@ -736,6 +736,11 @@ static int __maybe_unused zynq_gpio_suspend(struct device *dev) struct zynq_gpio *gpio = dev_get_drvdata(dev); struct irq_data *data = irq_get_irq_data(gpio->irq); + if (!data) { + dev_err(dev, "irq_get_irq_data() failed\n"); + return -EINVAL; + } + if (!device_may_wakeup(dev)) disable_irq(gpio->irq); @@ -753,6 +758,11 @@ static int __maybe_unused zynq_gpio_resume(struct device *dev) struct irq_data *data = irq_get_irq_data(gpio->irq); int ret; + if (!data) { + dev_err(dev, "irq_get_irq_data() failed\n"); + return -EINVAL; + } + if (!device_may_wakeup(dev)) enable_irq(gpio->irq); |