diff options
| author | Colin Ian King <colin.king@canonical.com> | 2020-08-19 12:14:52 +0100 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2020-08-31 18:16:38 +0300 |
| commit | b2c094582e38d667444a13404271752e5fafb2e2 (patch) | |
| tree | 7fcb5e1c6c8e46ba082a9f7c02bd6c52ab29c379 | |
| parent | bd5dd7aaa4c0834be98a532b16bc11335e1b26c1 (diff) | |
| download | kernel_replicant_linux-b2c094582e38d667444a13404271752e5fafb2e2.tar.gz kernel_replicant_linux-b2c094582e38d667444a13404271752e5fafb2e2.tar.bz2 kernel_replicant_linux-b2c094582e38d667444a13404271752e5fafb2e2.zip | |
ath11k: fix missing error check on call to ath11k_pci_get_user_msi_assignment
The return error check on the call to ath11k_pci_get_user_msi_assignment is
missing. If an error does occur, num_vectors is still set to zero and
later on a division by zero can occur when variable vector is being
calculated. Fix this by adding an error check after the call.
Addresses-Coverity: ("Division or modulo by zero")
Fixes: d4ecb90b3857 ("ath11k: enable DP interrupt setup for QCA6390")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200819111452.52419-1-colin.king@canonical.com
| -rw-r--r-- | drivers/net/wireless/ath/ath11k/pci.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c index ca7012d46c3f..058885776a3a 100644 --- a/drivers/net/wireless/ath/ath11k/pci.c +++ b/drivers/net/wireless/ath/ath11k/pci.c @@ -648,9 +648,12 @@ static int ath11k_pci_ext_irq_config(struct ath11k_base *ab) int i, j, ret, num_vectors = 0; u32 user_base_data = 0, base_vector = 0; - ath11k_pci_get_user_msi_assignment(ath11k_pci_priv(ab), "DP", - &num_vectors, &user_base_data, - &base_vector); + ret = ath11k_pci_get_user_msi_assignment(ath11k_pci_priv(ab), "DP", + &num_vectors, + &user_base_data, + &base_vector); + if (ret < 0) + return ret; for (i = 0; i < ATH11K_EXT_IRQ_GRP_NUM_MAX; i++) { struct ath11k_ext_irq_grp *irq_grp = &ab->ext_irq_grp[i]; |