aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhang Qilong <zhangqilong3@huawei.com>2020-11-06 09:52:17 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-12-30 11:53:03 +0100
commit26a19bbe6003b667da63f609307473df6b52d343 (patch)
treef534d50884e58eff20e169dae682749c0970c792
parent615bc1ba5b87843f932ea729b6c3304f58faf7bb (diff)
downloadkernel_replicant_linux-26a19bbe6003b667da63f609307473df6b52d343.tar.gz
kernel_replicant_linux-26a19bbe6003b667da63f609307473df6b52d343.tar.bz2
kernel_replicant_linux-26a19bbe6003b667da63f609307473df6b52d343.zip
spi: stm32: fix reference leak in stm32_spi_resume
[ Upstream commit 900ccdcb79bb61471df1566a70b2b39687a628d5 ] pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in stm32_spi_resume, so we should fix it. Fixes: db96bf976a4fc ("spi: stm32: fixes suspend/resume management") Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com> Reviewed-by: Alain Volmat <alain.volmat@st.com> Link: https://lore.kernel.org/r/20201106015217.140476-1-zhangqilong3@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/spi/spi-stm32.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
index 2cc850eb8922..471dedf3d339 100644
--- a/drivers/spi/spi-stm32.c
+++ b/drivers/spi/spi-stm32.c
@@ -2062,6 +2062,7 @@ static int stm32_spi_resume(struct device *dev)
ret = pm_runtime_get_sync(dev);
if (ret < 0) {
+ pm_runtime_put_noidle(dev);
dev_err(dev, "Unable to power device:%d\n", ret);
return ret;
}