summaryrefslogtreecommitdiffstats
path: root/post_proc
Commit message (Collapse)AuthorAgeFilesLines
* Equalizer: Check value size for get preset nameAndy Hung2017-09-151-0/+7
| | | | | | | | Test: see CTS testAllEffectsEqualizer_CVE_2017_0401 Bug: 37536407 Change-Id: Ifa515dea10c9293022b7d0971d097f0bd727ac6c (cherry picked from commit 8cf151a63177247a370ecdef6f2e1ec0b80901d5) CVE-2017-0767
* Fix security vulnerability: Equalizer setParameter memory overflowreplicant-6.0-0002rago2017-08-141-0/+20
| | | | | | | | Bug: 37563371 Test: use POC on bug or cts security test Change-Id: Ia04f172fb21b11463ffa9ea023d69a3db01e0731 (cherry picked from commit 617cd5c7f46c2312c7253001c46e7eea4c0315e0)
* Fix security vulnerability: Effect command might allow negative indexesrago2017-01-131-9/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 32588016 Bug: 32585400 Test: Use POC bug or cts security test Change-Id: I5ef8c756369d488ad5903c163584f24de63d73e3 (cherry picked from commit 500a9feaf816c719241de83f2ee65c8e2d7ff269) (cherry picked from commit ed79f2cc961d7d35fdbbafdd235c1436bcd74358) # Conflicts: # post_proc/equalizer.c Fix security vulnerability: Equalizer command might allow negative indexes Bug: 32247948 Bug: 32438598 Bug: 32436341 Test: use POC on bug or cts security test Change-Id: I56a92582687599b5b313dea1abcb8bcb19c7fc0e (cherry picked from commit 3f37d4ef89f4f0eef9e201c5a91b7b2c77ed1071) (cherry picked from commit ceb7b2d7a4c4cb8d03f166c61f5c7551c6c760aa) (cherry picked from commit d72ea85c78a1a68bf99fd5804ad9784b4102fe57)
* Merge remote-tracking branch 'remotes/android-6.0.1_r52' into HEADJessica Wagantall2016-07-071-2/+3
|\ | | | | | | | | | | Ticket: CYNGNOS-3020 Change-Id: Iafd7ca0e83097fd9bec0fe3e8ff4c05205d6410c
| * DO NOT MERGE Fix AudioEffect reply overflowAndy Hung2016-05-271-2/+3
| | | | | | | | | | Bug: 28173666 Change-Id: I055af37a721b20c5da0f1ec4b02f630dcd5aee02
| * post proc : volume listener : fix effect release crashEric Laurent2016-02-261-5/+18
| | | | | | | | | | | | | | | | Fix access to deleted effect context in vol_prc_lib_release() Bug: 25753245. Change-Id: I64ca99e4d5d09667be4c8c605f66700b9ae67949 (cherry picked from commit 93ab6fdda7b7557ccb34372670c30fa6178f8426)
* | post_proc: Misc cleanupsSteve Kondik2016-04-192-3/+10
| | | | | | | | Change-Id: I6a0a0d15bf196e6f5ffab6b68a96e341fc6fe3bf
* | post_proc: improve loggingDhananjay Kumar2016-04-196-142/+118
| | | | | | | | | | | | | | Make logs more meaningful and remove ones not necessary. Change-Id: I9562cf34a5dee406b1c0347a9004db08de9cd5df
* | post_proc: Fix bassboost/virtualizer not disabled on speakerwjiang2016-04-192-9/+2
| | | | | | | | | | | | | | | | | | When output is unintended device, there's no need to query enable_flag before setting effect to disabled state. There's possiblity that enable_flag is 0 as initialized value, which hinder effects from being disabled. Change-Id: Ib90c0ad0982dc8274129bb1bed7861e11670fbdb
* | volume_listener: Silence volume listener logAlexy Joseph2016-04-191-1/+1
| | | | | | | | | | | | Silence volume listener log for offload use case Change-Id: I1b6344dbb898d64ae52a7d3ef60d5666703516f9
* | post_proc: fix inconsistency in virtualizer state from set_strength callDhananjay Kumar2016-04-192-6/+11
| | | | | | | | | | | | | | | | | | | | | | - Virtualizer is getting applied just by setting strength even though it was kept disabled by client. - Enable/disable from strength context is not able to track state set by client, since internal state may not be same as one set by client. - Add a separate variable to track state set by client which would help avoid going into any such inconsistent state. Change-Id: I4985b2d12dc0ee3f62089423e3a71d530f66027c
* | post_proc: Squash upstream changeswjiang2016-03-238-34/+322
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | post_proc: disable effect immediately when routed to invalid devices Offload effect is still perceived when invalid output device is connected. We should send disable command immediately once phone is routed to unexpected device and forbid effect enablement during temporary disabled state. Change-Id: I26d4ccfd77037a879622b0437ae3916ff0071a69 CRs-Fixed: 630408 post_proc: disable Bassboost and Virtualizer for USB_ACCESSORY USB_ACCESSORY is not intended to be applied with SA+ bassboost and virtualizer, so add into invalid devices list. CRs-Fixed: 659191 Change-Id: If1f3421f9935ce624dc21895d9244d36d195b2bd post_proc: fix post and pre process KW issues KW issue fix includes: - handle memory allocation failure - array index boundary check Change-Id: I083952ba58d348a5b650601a83e6f492b0d686bb post_proc: Fix improper datatype of EQ preset band level value unsigned int causes negative band level turn out to be extreme large value, which results in EQ works abnormally due to unexpected parameter sent. Change-Id: I81120c604f4e9f23b25d5a45a7b0294fea63d207 CRs-Fixed: 696825 post_proc: add support for virtualizer capability query Add extra virtualizer interfaces to keep align with aosp design. Extended capabilities include: - Stub interface to allow querying speaker angles. - Force set output device as specific virtualize mode. - Query virtualize mode Stub function remains to be refined in sync with upcoming aosp changes. Change-Id: I3316f6d944db1c9954eda7643a5ce433defa1a6c CRs-Fixed: 810294 post_proc: remove unnecessary command size check Up bound check for command size of EFFECT_CMD_SET_PARAM is not applicable for DSP effect bundle. Remove the check to avoid parameter not taking effect. Change-Id: I7e8f73377699f11bdc1f62a05f6bea03c9c24151 CRs-Fixed: 816053 post_proc: explicitly disable virtualizer module if strength is 0 0 stength in DSP virtualizer is not equivalent to disable state as down mix is still happening for multichannel inputs. For better user experience, explicitly disable virtualizer module when strength is 0. Change-Id: Ic2884ac7010e4f835df871719d546c0c05173f4b CRs-Fixed: 872772 post_proc: fix reverb processing issue when preset is set to NONE Reverb effects are getting applied even after setting reverb preset to REVERB_PRESET_NONE. Preset NONE is used by client and is supposed to be equivalent to disabled state, even though this preset is not supported in DSP. Fix this issue by avoiding enable command from post processing HAL to DSP when preset NONE is in use. CRs-Fixed: 868041 Change-Id: Iad626a7400246e80a97a926234cfb7756ec6083e post_proc: fix crash in offload effect bundle during stop output Effect bundle stop() frees mixer contol before doing module stop(), whereas module's stop() still needs this control to send disable command down the layer. Crash is observed if memory associated with effect control is reused and gets altered by the time mixer control is completed. Move mixer control's deletion after module's stop() to fix this issue. CRs-Fixed: 860604 Change-Id: Ia8b6d5f847b69392afbda1ba77fc740a47aba25d
* | Merge tag 'android-6.0.1_r22' of ↵Steve Kondik2016-03-111-5/+18
|\ \ | | | | | | | | | | | | | | | https://android.googlesource.com/platform/hardware/qcom/audio into cm-13.0 Android 6.0.1 release 22
| * \ post proc : volume listener : fix effect release crashEric Laurent2015-12-091-5/+18
| |\ \ | | |/ | |/| | | | | | | | | | | | | am: ebbb823651 * commit 'ebbb82365172337c6c250c6cac4e326970a9e351': post proc : volume listener : fix effect release crash
| | * post proc : volume listener : fix effect release crashEric Laurent2015-12-091-5/+18
| | | | | | | | | | | | | | | | | | | | | | | | Fix access to deleted effect context in vol_prc_lib_release() Bug: 25753245. Change-Id: I64ca99e4d5d09667be4c8c605f66700b9ae67949 (cherry picked from commit 93ab6fdda7b7557ccb34372670c30fa6178f8426)
| | * DO NOT MERGE - volume_listener: fix releaseAndy Hung2015-09-161-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | use safe iteration of list when removing node. Bug: 23731264 Change-Id: I6d0c51638b6a3de684cf595833dc4d0fc7e8c8b5 (cherry picked from commit 591ef60fb95d863cb8f3a3923d59bc36c8cd4b8c)
* | | Merge tag 'android-6.0.0_r26' into cm-13.0Ricardo Cerqueira2015-11-051-8/+29
|\| | | | | | | | | | | Android 6.0.0 release 26
| * | volume listener: fix process() function for accumulate mode.Eric Laurent2015-09-101-2/+23
| | | | | | | | | | | | | | | | | | | | | Honor output buffer accumulation mode requested by config command. Bug: 23796255. Change-Id: I349682d5f76e343a16e4e41f7ad556ecbb697aa3
| * | volume_listener: fix releaseAndy Hung2015-09-081-2/+2
| | | | | | | | | | | | | | | | | | | | | use safe iteration of list when removing node. Bug: 23731264 Change-Id: I6d0c51638b6a3de684cf595833dc4d0fc7e8c8b5
| * | hal: MBDRC: send MBDRC step level only for speaker devicevivek mehta2015-08-201-6/+6
| |/ | | | | | | | | | | | | | | | | | | - set MBDRC level only for speaker device. Ignore combo device - this will fix printing wrong failure log in case Headphone is connect and alarm / notification is played. BUG=23362209 Change-Id: I675dfa1da0546483068f737d61ca0f2dd311ce52
* | Merge tag 'android-6.0.0_r5' into cm-13.0Ricardo Cerqueira2015-11-031-2/+2
|\ \ | | | | | | | | | Android 6.0.0 release 5
| * | DO NOT MERGE - volume_listener: fix releaseAndy Hung2015-09-281-2/+2
| |/ | | | | | | | | | | | | | | use safe iteration of list when removing node. Bug: 23731264 Change-Id: I6d0c51638b6a3de684cf595833dc4d0fc7e8c8b5 (cherry picked from commit 591ef60fb95d863cb8f3a3923d59bc36c8cd4b8c)
* / audio: Use kernel headersChirayu Desai2015-10-091-0/+6
|/ | | | Change-Id: I7a238b7c105d58eb6ec7794ec7a6af37f63c4cb0
* hal: post_proc: add volume based audio calibration supportvivek mehta2015-06-252-0/+786
| | | | | | | | | | | | - add new effect module to listen to volume and device change - based on volume levels of all streams active over speaker compute gain based calibration level and communicate with audio HAL to send the same to ACDB loader - make audio HAL singleton Bug: 22100304. Change-Id: If74bf66d32def85022d79ccb9f84c3b85c8a2dc9
* Enable support for msm8992 & msm8994 targetsAjay Dudani2015-04-161-3/+3
| | | | Change-Id: I8da8a5b9885c7202d858b181d610aadc12544852
* Fix build warnings on shamuGlenn Kasten2015-04-091-0/+1
| | | | | | for implicit and incompatible declarations of malloc, free, calloc Change-Id: I9bae9d032bbaea3955bef1073b9b8b7c187dec43
* Fix "hardware/qcom/audio/post_proc/effect_api.c:67:17: error: use of ↵Elliott Hughes2014-12-291-0/+1
| | | | | | undeclared identifier 'EINVAL'" Change-Id: I09c96c1a0b6f57c42969a375fedb0cb5b0b66c40
* audio: fix razor checkbuildEric Laurent2014-08-071-0/+3
| | | | | | Do not build post processing wrapper library on msm8960 platform. Change-Id: I9e08f4e0a994a1605a81109c2d498ad58f2606f6
* audio: compilation & warning fixes for offload effectsHaynes Mathew George2014-08-066-20/+15
| | | | | | | Fix compilation errors & unused param warnings in offload effect modules. Change-Id: I58fa250c413e07702cf4a4f96aa85f985883b343
* post_proc: Offload effects combined patchsetHaynes Mathew George2014-08-0613-0/+3559
* Support effects in DSP for tunnel mode playback Add interface to support configuring equlaizer, bass boost, virtualizer and reverb effects in DSP for tunnel mode of playback. (cherry-picked from CAF commit 3eedc004e9adf5967f393d65c22b7806d0c63e6c) * post_proc: Enable effects param in DSP to start effect -During switch to tunnel playback, offload effects-flags remain disabled. This stops effects being applied on tunnel playback. -Send effects enable params to DSP to start effects during switch. (cherry-picked from CAF commit d02f2cd710334cc2be6a866da537a595256ae623) * post_proc: disable adsp reverb when preset is 'None' Audio HAL set corresponding preset id into adsp, but doesn't disabe reverb explicitly when 'None' preset is chosen. However, preset=0 means custom preset in adsp, so adsp won't stop reverb processing. (cherry-picked from CAF commit b27e25f062edfeebb6860078013c7b413b8c4301) * post_proc: send ENABLE_FLAG directly to offload effect driver Enable flag should be sent directly through offload effect driver to adsp whenever bundle receives EFFECT_CMD_ENABLE. Otherwise enablement will only take effect in adsp after subsequent parameters being set, and that's not expected. (cherry-picked from CAF commit d45948e2153c03b41f55577debd943408f9c8280) * post_proc: reverb preset id is not mapped correctly Array index is not correct and causes uninitialized value being used when 'Plate' is chosen. Correct index to retrieve the right preset id. (cherry-picked from CAF commit ca2685b2a0a695a7c4ac78883e750a92dcad0515) * post_proc: disable Bassboost and Virtualizer for certain devices WFD, Hdmi and usb audio are not intended to be applied with SA+ bassboost and virtualizer, so add into invalid device list. (cherry-picked from CAF ee2ff9621d25d83151ccb24a416f21533fdfbd31) * post_proc: disable effect immediately when routed to invalid devices Offload effect is still perceived when invalid output device is connected. We should send disable command immediately once phone is routed to unexpected device and forbid effect enablement during temporary disabled state. (cherry-picked from CAF commit 95d74c2232721631f3a04f6ccf35760b37b33fea) * post_proc: Enable reverb in DSP to start effect During switch to tunnel playback, reverb enable command is not sent to DSP and causes reverb effect not applied continuously. Send reverb enable params to DSP to start effects during switch. (cherry-picked from CAF commit c37c260fa174453f4822261bcd531ddb2706ab2c) * post_proc: include audio_effects.h from kernel exported headers Currently, audio_effects.h header file is included with reference to the absolute path. Instead, reference it from the kernel exported headers. (cherry-picked from CAF commit 090a2aa3f38298196ad9f47e3b6578535e1f7e10) * hal: Add support for audio effects in DSP for tunnel mode playback Add support to enable or disable audio post processing effects in DSP for tunnel mode playback. (cherry-picked from CAF commit 1d0891672175d431e8872dd7dff21e0ce507361a) Change-Id: I7ead6da4c216fd87e8ca1884811c4e0155053f49