diff options
| author | Ethan Chen <intervigil@gmail.com> | 2020-04-11 21:55:46 -0700 |
|---|---|---|
| committer | Ethan Chen <intervigil@gmail.com> | 2020-04-11 22:00:05 -0700 |
| commit | 745cac87d2e86f4818488eaa72ea2645bd796646 (patch) | |
| tree | 49b0b5a4160212e503eea45d9cba74779afb8881 | |
| parent | 00d66345db7b48cf91a89e83a98630907389aa13 (diff) | |
| download | hardware_lineage_livedisplay-lineage-17.1.tar.gz hardware_lineage_livedisplay-lineage-17.1.tar.bz2 hardware_lineage_livedisplay-lineage-17.1.zip | |
livedisplay: sdm: Do not create intermediate stringHEADlineage-17.1
* hidl_string can be constructed from a C-string, don't bother creating
an intermediate object.
* Addresses a possible crash due to string construction.
Change-Id: I28fdf53fcd4dc6dbc97a22acf4d40526788a0548
| -rw-r--r-- | sdm/DisplayModes.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sdm/DisplayModes.cpp b/sdm/DisplayModes.cpp index 9121f5d..5ebb820 100644 --- a/sdm/DisplayModes.cpp +++ b/sdm/DisplayModes.cpp @@ -115,7 +115,7 @@ std::vector<DisplayMode> DisplayModes::getDisplayModesInternal() { if (disp_api_get_display_modes(mCookie, 0, 0, tmp, count, &flags) == 0) { for (int i = 0; i < count; i++) { - modes.push_back(DisplayMode{tmp[i].id, std::string(tmp[i].name)}); + modes.push_back(DisplayMode{tmp[i].id, tmp[i].name}); } } |