summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobin Lee <rgl@google.com>2018-11-29 14:38:30 +0100
committerRobin Lee <rgl@google.com>2018-11-29 19:11:41 +0100
commit41773b73ea02db5b2dc19b6077a5b965feeac374 (patch)
treea0c8f06d65bda3c31deee6bc755775b68e4324b2
parentedc46f4239c3f7410468c115d1604e5c871b8809 (diff)
downloadframeworks_base-41773b73ea02db5b2dc19b6077a5b965feeac374.tar.gz
frameworks_base-41773b73ea02db5b2dc19b6077a5b965feeac374.tar.bz2
frameworks_base-41773b73ea02db5b2dc19b6077a5b965feeac374.zip
Don't rely on fallthrough in incident_section_gen
Silences the following warning during build: frameworks/base/tools/incident_section_gen/main.cpp:265:13: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] default: ^ frameworks/base/tools/incident_section_gen/main.cpp:265:13: note: insert 'GOOGLE_FALLTHROUGH_INTENDED;' to silence this warning default: ^ GOOGLE_FALLTHROUGH_INTENDED; frameworks/base/tools/incident_section_gen/main.cpp:265:13: note: insert 'break;' to avoid fall-through default: ^ break; Test: make -j50 2>&1 | grep incident_section Change-Id: Ie59510025e59e96f0763726794ff19dae595c672
-rw-r--r--tools/incident_section_gen/main.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/incident_section_gen/main.cpp b/tools/incident_section_gen/main.cpp
index 639f98062b7..0c593fc0adc 100644
--- a/tools/incident_section_gen/main.cpp
+++ b/tools/incident_section_gen/main.cpp
@@ -258,8 +258,9 @@ static bool isDefaultMessageImpl(const Descriptor* descriptor, const Destination
return false;
case FieldDescriptor::TYPE_STRING:
if (getPrivacyFlags(field).patterns_size() != 0) return false;
+ break;
default:
- continue;
+ break;
}
}
parents->erase(descriptor->full_name());