summaryrefslogtreecommitdiffstats
path: root/drm
diff options
context:
space:
mode:
authorAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-13 00:23:52 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-13 00:23:52 +0000
commit58cc8f2c0254f03d66a28ae1cf0809c171d4ac7d (patch)
tree4f272e8c6416bac5e87c2633b0d286ffd1c2d24e /drm
parentc25b042720672d0943dec638b8287ab80bedbf5d (diff)
parentcadf7289e0dacf4a40422f0b36f97891649d398b (diff)
downloadframeworks_av-58cc8f2c0254f03d66a28ae1cf0809c171d4ac7d.tar.gz
frameworks_av-58cc8f2c0254f03d66a28ae1cf0809c171d4ac7d.tar.bz2
frameworks_av-58cc8f2c0254f03d66a28ae1cf0809c171d4ac7d.zip
Revert "BnCrypto: fix use-before-init in CREATE_PLUGIN" am: e4e7b91ec8 am: 36af5d0319 am: d0d078020e am: e492965229 am: cadf7289e0
Change-Id: I27c1cd22dfa0e5ec371f636ef00e6bd121cc73b7
Diffstat (limited to 'drm')
-rw-r--r--drm/libmediadrm/ICrypto.cpp13
1 files changed, 2 insertions, 11 deletions
diff --git a/drm/libmediadrm/ICrypto.cpp b/drm/libmediadrm/ICrypto.cpp
index 4707593b27..a2594aa2d8 100644
--- a/drm/libmediadrm/ICrypto.cpp
+++ b/drm/libmediadrm/ICrypto.cpp
@@ -264,12 +264,8 @@ status_t BnCrypto::onTransact(
{
CHECK_INTERFACE(ICrypto, data, reply);
- uint8_t uuid[16] = {0};
- if (data.read(uuid, sizeof(uuid)) != NO_ERROR) {
- android_errorWriteLog(0x534e4554, "144767096");
- reply->writeInt32(BAD_VALUE);
- return OK;
- }
+ uint8_t uuid[16];
+ data.read(uuid, sizeof(uuid));
size_t opaqueSize = data.readInt32();
void *opaqueData = NULL;
@@ -285,11 +281,6 @@ status_t BnCrypto::onTransact(
}
data.read(opaqueData, opaqueSize);
- if (data.read(opaqueData, opaqueSize) != NO_ERROR) {
- android_errorWriteLog(0x534e4554, "144767096");
- reply->writeInt32(BAD_VALUE);
- return OK;
- }
reply->writeInt32(createPlugin(uuid, opaqueData, opaqueSize));
free(opaqueData);