summaryrefslogtreecommitdiffstats
path: root/drm
diff options
context:
space:
mode:
authorJeff Tinker <jtinker@google.com>2018-08-15 01:23:12 -0700
committerandroid-build-merger <android-build-merger@google.com>2018-08-15 01:23:12 -0700
commit22fca9cd6248868e96cd3abb99b25d74948baada (patch)
tree4b7c1cd65b4ec7790293bd903e9f7a9092e84ae0 /drm
parent0c6fa04393feee62429a8d672f194f430c122dea (diff)
parentf19106c7cc11e62411677d8f4a4059e315bf8279 (diff)
downloadframeworks_av-22fca9cd6248868e96cd3abb99b25d74948baada.tar.gz
frameworks_av-22fca9cd6248868e96cd3abb99b25d74948baada.tar.bz2
frameworks_av-22fca9cd6248868e96cd3abb99b25d74948baada.zip
Merge "Fix information disclosure in mediadrmserver" into oc-dev am: f452267ae8 am: dd57ac5b26
am: f19106c7cc Change-Id: I793b94bfbb7305bffcdd1c8c44fa989a10f3a4af
Diffstat (limited to 'drm')
-rw-r--r--drm/libmediadrm/ICrypto.cpp9
1 files changed, 7 insertions, 2 deletions
diff --git a/drm/libmediadrm/ICrypto.cpp b/drm/libmediadrm/ICrypto.cpp
index 73ecda15a7..a2594aa2d8 100644
--- a/drm/libmediadrm/ICrypto.cpp
+++ b/drm/libmediadrm/ICrypto.cpp
@@ -225,8 +225,13 @@ IMPLEMENT_META_INTERFACE(Crypto, "android.hardware.ICrypto");
void BnCrypto::readVector(const Parcel &data, Vector<uint8_t> &vector) const {
uint32_t size = data.readInt32();
- vector.insertAt((size_t)0, size);
- data.read(vector.editArray(), size);
+ if (vector.insertAt((size_t)0, size) < 0) {
+ vector.clear();
+ }
+ if (data.read(vector.editArray(), size) != NO_ERROR) {
+ vector.clear();
+ android_errorWriteWithInfoLog(0x534e4554, "62872384", -1, NULL, 0);
+ }
}
void BnCrypto::writeVector(Parcel *reply, Vector<uint8_t> const &vector) const {