summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-12 23:59:54 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-12 23:59:54 +0000
commite492965229ce184a76eaffe2d9fdfcf9e3db7af2 (patch)
tree2926078ecc63d88d598b6e1541c9a267dbdf6596
parentdf156dc766918c12b1931eb79919b4db3c959b1a (diff)
parentd0d078020e26dd9ff1f870491bbfef0f9b9560de (diff)
downloadframeworks_av-e492965229ce184a76eaffe2d9fdfcf9e3db7af2.tar.gz
frameworks_av-e492965229ce184a76eaffe2d9fdfcf9e3db7af2.tar.bz2
frameworks_av-e492965229ce184a76eaffe2d9fdfcf9e3db7af2.zip
Revert "BnCrypto: fix use-before-init in CREATE_PLUGIN" am: e4e7b91ec8 am: 36af5d0319 am: d0d078020e
Change-Id: I38c304066ea808014e288dd4ed6a2f89a34492cb
-rw-r--r--drm/libmediadrm/ICrypto.cpp13
1 files changed, 2 insertions, 11 deletions
diff --git a/drm/libmediadrm/ICrypto.cpp b/drm/libmediadrm/ICrypto.cpp
index 4707593b27..a2594aa2d8 100644
--- a/drm/libmediadrm/ICrypto.cpp
+++ b/drm/libmediadrm/ICrypto.cpp
@@ -264,12 +264,8 @@ status_t BnCrypto::onTransact(
{
CHECK_INTERFACE(ICrypto, data, reply);
- uint8_t uuid[16] = {0};
- if (data.read(uuid, sizeof(uuid)) != NO_ERROR) {
- android_errorWriteLog(0x534e4554, "144767096");
- reply->writeInt32(BAD_VALUE);
- return OK;
- }
+ uint8_t uuid[16];
+ data.read(uuid, sizeof(uuid));
size_t opaqueSize = data.readInt32();
void *opaqueData = NULL;
@@ -285,11 +281,6 @@ status_t BnCrypto::onTransact(
}
data.read(opaqueData, opaqueSize);
- if (data.read(opaqueData, opaqueSize) != NO_ERROR) {
- android_errorWriteLog(0x534e4554, "144767096");
- reply->writeInt32(BAD_VALUE);
- return OK;
- }
reply->writeInt32(createPlugin(uuid, opaqueData, opaqueSize));
free(opaqueData);