diff options
| author | Paul Ganssle <pganssle@users.noreply.github.com> | 2019-04-22 11:52:09 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-04-22 11:52:09 -0400 |
| commit | 50a41c7005c81024cf66fcd1d940fd168dc4a83d (patch) | |
| tree | 12254137b69e3f7df5b51e3966d014304d204d5b /setuptools/tests | |
| parent | 2b5accfaa4cfe4a3638dedabce13a4991d955179 (diff) | |
| parent | e4f987b141104e709367cbe629f3cd6ef5153216 (diff) | |
| download | external_python_setuptools-50a41c7005c81024cf66fcd1d940fd168dc4a83d.tar.gz external_python_setuptools-50a41c7005c81024cf66fcd1d940fd168dc4a83d.tar.bz2 external_python_setuptools-50a41c7005c81024cf66fcd1d940fd168dc4a83d.zip | |
Merge pull request #1745 from shashanksingh28/master
Fix error with PEP 517 builds when wheel exists (GH #1761)
Diffstat (limited to 'setuptools/tests')
| -rw-r--r-- | setuptools/tests/test_build_meta.py | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/setuptools/tests/test_build_meta.py b/setuptools/tests/test_build_meta.py index e32cfb92..7612ebd7 100644 --- a/setuptools/tests/test_build_meta.py +++ b/setuptools/tests/test_build_meta.py @@ -157,7 +157,6 @@ class TestBuildMetaBackend: assert os.path.isfile(os.path.join(dist_dir, wheel_name)) - @pytest.mark.xfail(reason="Known error, see GH #1671") def test_build_wheel_with_existing_wheel_file_present(self, tmpdir_cwd): # Building a wheel should still succeed if there's already a wheel # in the wheel directory @@ -195,6 +194,12 @@ class TestBuildMetaBackend: assert os.path.isfile(os.path.join(dist_dir, wheel_one)) assert wheel_one != wheel_two + # and if rebuilding the same wheel? + open(os.path.join(dist_dir, wheel_two), 'w').close() + wheel_three = self.get_build_backend().build_wheel(dist_dir) + assert wheel_three == wheel_two + assert os.path.getsize(os.path.join(dist_dir, wheel_three)) > 0 + def test_build_sdist(self, build_backend): dist_dir = os.path.abspath('pip-sdist') os.makedirs(dist_dir) |