aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHugo <hugovk@users.noreply.github.com>2020-02-16 16:07:02 +0200
committerPaul Ganssle <paul@ganssle.io>2020-04-21 14:09:14 -0400
commit9bfc5fa5fd0da9254c2e95edb42da3fb65893f75 (patch)
treec81c7675051236b86224a8eb2e70e54d4a5da155
parent53c284b325959a6fd177e9d37d8b5dd5824db2b3 (diff)
downloadexternal_python_setuptools-9bfc5fa5fd0da9254c2e95edb42da3fb65893f75.tar.gz
external_python_setuptools-9bfc5fa5fd0da9254c2e95edb42da3fb65893f75.tar.bz2
external_python_setuptools-9bfc5fa5fd0da9254c2e95edb42da3fb65893f75.zip
Deprecate bdist_wininst
-rw-r--r--setuptools/command/bdist_wininst.py9
-rw-r--r--setuptools/tests/test_bdist_deprecations.py23
2 files changed, 32 insertions, 0 deletions
diff --git a/setuptools/command/bdist_wininst.py b/setuptools/command/bdist_wininst.py
index 073de97b..ff4b6345 100644
--- a/setuptools/command/bdist_wininst.py
+++ b/setuptools/command/bdist_wininst.py
@@ -1,4 +1,7 @@
import distutils.command.bdist_wininst as orig
+import warnings
+
+from setuptools import SetuptoolsDeprecationWarning
class bdist_wininst(orig.bdist_wininst):
@@ -14,6 +17,12 @@ class bdist_wininst(orig.bdist_wininst):
return cmd
def run(self):
+ warnings.warn(
+ "bdist_wininst is deprecated and will be removed in a future "
+ "version. Use bdist_wheel (wheel packages) instead.",
+ SetuptoolsDeprecationWarning
+ )
+
self._is_running = True
try:
orig.bdist_wininst.run(self)
diff --git a/setuptools/tests/test_bdist_deprecations.py b/setuptools/tests/test_bdist_deprecations.py
new file mode 100644
index 00000000..704164aa
--- /dev/null
+++ b/setuptools/tests/test_bdist_deprecations.py
@@ -0,0 +1,23 @@
+"""develop tests
+"""
+import mock
+
+import pytest
+
+from setuptools.dist import Distribution
+from setuptools import SetuptoolsDeprecationWarning
+
+
+@mock.patch("distutils.command.bdist_wininst.bdist_wininst")
+def test_bdist_wininst_warning(distutils_cmd):
+ dist = Distribution(dict(
+ script_name='setup.py',
+ script_args=['bdist_wininst'],
+ name='foo',
+ py_modules=['hi'],
+ ))
+ dist.parse_command_line()
+ with pytest.warns(SetuptoolsDeprecationWarning):
+ dist.run_commands()
+
+ distutils_cmd.run.assert_called_once()