midas.mk: mark sections topics to regroup things and enable more comments

This regroup statements in sections that are now indicated like that:
    ############
    # Graphics #
    ############

    PRODUCT_PACKAGE += [...]

Regrouping things in sections enable to avoid duplication like
we currently have with graphics for instance.

In addition, before the topic sections were using simple comments
like that:
    # Graphics
    PRODUCT_PACKAGE += [...]

And so it wasn't possible for an item to both add comments
detailing why it's done in this way and an indication of the
section it's in (like Graphics).

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>

1 files changed, 104 insertions, 16 deletions

diff --git a/midas.mk b/midas.mk
index de56090..7b7174e 100644
--- a/midas.mk
+++ b/midas.mk
@@ -14,7 +14,9 @@
 # limitations under the License.
 #
 
-# Graphics
+############
+# Graphics #
+############
 PRODUCT_PACKAGES += \
     gralloc.gbm \
     hwcomposer.drm \
@@ -25,30 +27,50 @@ PRODUCT_PACKAGES += \
     android.hardware.graphics.composer@2.1-impl \
     android.hardware.graphics.composer@2.1-service \
 
-# Lights
+##########
+# Lights #
+##########
 PRODUCT_PACKAGES += \
     android.hardware.light@2.0-service.samsung \
 
+############
+# Graphics #
+############
 PRODUCT_AAPT_CONFIG := normal
 PRODUCT_AAPT_PREF_CONFIG := xhdpi
 
-# USB HAL
+#######
+# USB #
+#######
+
+# HAL packages
 PRODUCT_PACKAGES += \
     android.hardware.usb@1.0-service
 
+##########
+# Health #
+##########
 PRODUCT_PACKAGES += \
 	android.hardware.health@2.1-service \
 	android.hardware.health@2.1-impl \
 
-# Power HAL
+#########
+# Power #
+#########
+
+# HAL packages
 PRODUCT_PACKAGES += \
 	android.hardware.power-service.example \
 
-# VNDK
+########
+# VNDK #
+########
 PRODUCT_PACKAGES += \
     vndk_package
 
-# Graphics
+############
+# Graphics #
+############
 PRODUCT_PACKAGES += \
     gralloc.gbm \
     hwcomposer.ranchu \
@@ -57,7 +79,9 @@ PRODUCT_PACKAGES += \
     android.hardware.graphics.composer@2.1-impl \
     android.hardware.graphics.composer@2.1-service \
 
-# Audio
+#########
+# Audio #
+#########
 PRODUCT_PACKAGES += \
     android.hardware.audio.effect@6.0-impl \
     android.hardware.audio@6.0-impl \
@@ -74,7 +98,6 @@ PRODUCT_PACKAGES += \
   audio.a2dp.default \
 
 PRODUCT_COPY_FILES += \
-	kernel/replicant/linux/zImage-dtb:kernel \
     frameworks/av/media/libeffects/data/audio_effects.xml:$(TARGET_COPY_OUT_VENDOR)/etc/audio_effects.xml \
     frameworks/av/services/audiopolicy/config/audio_policy_configuration_generic.xml:$(TARGET_COPY_OUT_VENDOR)/etc/audio_policy_configuration.xml \
     frameworks/av/services/audiopolicy/config/primary_audio_policy_configuration.xml:$(TARGET_COPY_OUT_VENDOR)/etc/primary_audio_policy_configuration.xml \
@@ -83,73 +106,138 @@ PRODUCT_COPY_FILES += \
     frameworks/av/services/audiopolicy/config/default_volume_tables.xml:$(TARGET_COPY_OUT_VENDOR)/etc/default_volume_tables.xml \
     frameworks/av/services/audiopolicy/config/surround_sound_configuration_5_0.xml:$(TARGET_COPY_OUT_VENDOR)/etc/surround_sound_configuration_5_0.xml
 
+##########
+# Kernel #
+##########
+PRODUCT_COPY_FILES += \
+	kernel/replicant/linux/zImage-dtb:kernel \
+
+###########################
+# unsupported HW features #
+###########################
+
 # Copy list of unsupported HW features
 PRODUCT_COPY_FILES += \
     $(LOCAL_PATH)/unsupported_hardware.xml:$(TARGET_COPY_OUT_VENDOR)/etc/permissions/unsupported_hardware.xml
 
-# DRM HAL packages
+########################################
+# DRM (Digital Restriction Management) #
+########################################
+
+# HAL packages
 PRODUCT_PACKAGES += \
     android.hardware.drm@1.0-service \
     android.hardware.drm@1.0-impl \
 
+############
+# Security #
+############
 # Keymaster HAL packages
 PRODUCT_PACKAGES += \
     android.hardware.keymaster@3.0-impl \
     android.hardware.keymaster@3.0-service \
 
-# Graphics HAL packages
+############
+# Graphics #
+############
+
+# HAL packages
 PRODUCT_PACKAGES += \
     android.hardware.graphics.mapper@2.0-impl \
     android.hardware.graphics.allocator@2.0-service \
     android.hardware.graphics.allocator@2.0-impl \
     android.hardware.renderscript@1.0-impl \
 
-# Vibrator HAL packages
+############
+# Vibrator #
+############
+
+# HAL packages
 PRODUCT_PACKAGES += \
     android.hardware.vibrator@1.0-impl \
 
-# Memory HAL packages
+##########
+# Memory #
+##########
+
+# HAL packages
 PRODUCT_PACKAGES += \
     android.hidl.memory@1.0-impl \
     android.hidl.memory@1.0-service \
 
-# Sensors HAL packages
+###########
+# Sensors #
+###########
+
+# HAL packages
 PRODUCT_PACKAGES += \
     android.hardware.sensors@1.0-impl \
 
-# VR HAL packages
+######
+# VR #
+######
+
+# HAL packages
 PRODUCT_PACKAGES += \
     android.hardware.vr@1.0-impl \
 
-# DRM – check if this needs to be removed!
+########################################
+# DRM (Digital Restriction Management) #
+########################################
+
+# TODO: check if this needs to be removed!
 PRODUCT_PACKAGES += \
     android.hardware.drm@1.0-impl \
     android.hardware.drm@1.0-service \
 
+############
+# Security #
+############
 PRODUCT_PACKAGES += \
 	android.hardware.gatekeeper@1.0-service.software
 
+#########
+# Debug #
+#########
+
 # Get root on the serial console for -eng builds
 # This can help debugging early boot issues
 ifeq ($(TARGET_BUILD_VARIANT),eng)
 PRODUCT_COPY_FILES += $(LOCAL_PATH)/console.rc:system/etc/init/console.rc
 endif
 
-# ADB support
+###############
+# ADB support #
+###############
 PRODUCT_PROPERTY_OVERRIDES += \
     persist.service.adb.enable=1 \
     persist.sys.usb.config=adb
 
+####################
+# Heimdall support #
+####################
+
 # Enable flashing through heimdall
 PRODUCT_COPY_FILES += $(LOCAL_PATH)/resize2fs_partitions.sh:system/bin/resize2fs_partitions.sh
 
+#########
+# Hacks #
+#########
+
 # HACK: prevent the device to go in suspend because it's annoying during early
 # development. Remove afterward as it consume way more energy this way.
 PRODUCT_COPY_FILES += $(LOCAL_PATH)/prevent_suspend.sh:system/bin/prevent_suspend.sh
 PRODUCT_COPY_FILES += $(LOCAL_PATH)/prevent_suspend.rc:system/etc/init/prevent_suspend.rc
 
+############
+# Graphics #
+############
 PRODUCT_COPY_FILES += $(LOCAL_PATH)/allocator/android.hardware.graphics.allocator@2.0-service.rc:$(TARGET_COPY_OUT_VENDOR)/etc/init/android.hardware.graphics.allocator@2.0-override-service.rc
 
+#######
+# USB #
+#######
+
 # Enable Hardware compoments on the framework level
 PRODUCT_COPY_FILES += \
     frameworks/native/data/etc/android.hardware.usb.host.xml:system/etc/permissions/android.hardware.usb.host.xml