diff options
| author | Andy McFadden <fadden@android.com> | 2009-12-01 12:37:26 -0800 |
|---|---|---|
| committer | Andy McFadden <fadden@android.com> | 2009-12-01 15:56:30 -0800 |
| commit | 3bfdcc979da0f857b014318f3df5d95a0f93eb27 (patch) | |
| tree | e7eb63b97631adb04937db7d97d6f157a25242a7 /debuggerd | |
| parent | e7629a3bea1ec3ebd50e436812f70e7626d0398a (diff) | |
| download | system_core-3bfdcc979da0f857b014318f3df5d95a0f93eb27.tar.gz system_core-3bfdcc979da0f857b014318f3df5d95a0f93eb27.tar.bz2 system_core-3bfdcc979da0f857b014318f3df5d95a0f93eb27.zip | |
Minor tweaks to debuggerd.
Changed "process has crashed" message:
- say ":5039" instead of ":port" so mouse-paste of command is trivial
- removed trailing spaces, which consume log buffer to little effect
- improved (I hope) the short explanation of what's going on and
what the HOME key does
Fixed typo ("ignorning").
Diffstat (limited to 'debuggerd')
| -rw-r--r-- | debuggerd/debuggerd.c | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/debuggerd/debuggerd.c b/debuggerd/debuggerd.c index 996e6c20..145135fc 100644 --- a/debuggerd/debuggerd.c +++ b/debuggerd/debuggerd.c @@ -606,15 +606,16 @@ static void wait_for_user_action(unsigned tid, struct ucred* cr) (void)tid; /* First log a helpful message */ LOG( "********************************************************\n" - "* process %d crashed. debuggerd waiting for gdbserver \n" - "* \n" - "* adb shell gdbserver :port --attach %d & \n" - "* \n" - "* and press the HOME key. \n" + "* Process %d has been suspended while crashing. To\n" + "* attach gdbserver for a gdb connection on port 5039:\n" + "*\n" + "* adb shell gdbserver :5039 --attach %d &\n" + "*\n" + "* Press HOME key to let the process continue crashing.\n" "********************************************************\n", cr->pid, cr->pid); - /* wait for HOME key */ + /* wait for HOME key (TODO: something useful for devices w/o HOME key) */ if (init_getevent() == 0) { int ms = 1200 / 10; int dit = 1; @@ -698,7 +699,7 @@ static void handle_crashing_process(int fd) sprintf(buf,"/proc/%d/task/%d", cr.pid, tid); if(stat(buf, &s)) { - LOG("tid %d does not exist in pid %d. ignorning debug request\n", + LOG("tid %d does not exist in pid %d. ignoring debug request\n", tid, cr.pid); close(fd); return; |