summaryrefslogtreecommitdiffstats
path: root/udrv
diff options
context:
space:
mode:
authorKim Schulz <k.schulz@samsung.com>2013-09-16 15:59:33 +0200
committerZhihai Xu <zhihaixu@google.com>2013-12-16 14:00:41 -0800
commit2a2701cdddac0859a95e58aec542742c450145b9 (patch)
treecbb4352c8816576e12ed34531fe3727fac0c033b /udrv
parent41b33913995e5baf53461fe50f836717c2a47db9 (diff)
downloadandroid_system_bt-2a2701cdddac0859a95e58aec542742c450145b9.tar.gz
android_system_bt-2a2701cdddac0859a95e58aec542742c450145b9.tar.bz2
android_system_bt-2a2701cdddac0859a95e58aec542742c450145b9.zip
Fixes for problems found with coverity analyzer
- fixed UNINITIALIZED variable (hdl) in bta_hh_act.c :220 - fixed possible RESOURCE LEAK in btif_config_util.cpp in relation to open_file_map() if file is fd size=0 - fixed possible RESOURCE LEAK in create_socket_server() in uipc:196 (s not closed) - fixed possible OVERRUN in l2c_csm.c, (l2c_csm_config), array "l2cb.fixed_reg" of 4 20-byte elements at element index 60 (byte offset 1200) using index "p_ccb->local_cid - 3" (which evaluates to 60) - fixed possible OVERRUN in btm_pm.c, (btm_pm_reset) array "btm_cb.acl_db" of 7 288-byte elements at element index 7 (byte offset 2016) using index "btm_cb.pm_pend_link" (which evaluates to 7). - fixed possible OVERRUN in btif_storage.c, (btif_storage_add_device_to_autopair_blacklist) array "input_value" of 20 bytes by passing it to a function which accesses it at byte offset 20 using argument "20U". patch set 2: - fixed {} Patch set 3: - fixed review commment in stack/btm/btm_pm.c:379 bug: 10777562 Change-Id: I2a6d57f93acaaf9b25c49a6a29cb60d0e1e3c5d8
Diffstat (limited to 'udrv')
-rw-r--r--udrv/ulinux/uipc.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/udrv/ulinux/uipc.c b/udrv/ulinux/uipc.c
index 1428c7d76..846fa176a 100644
--- a/udrv/ulinux/uipc.c
+++ b/udrv/ulinux/uipc.c
@@ -194,6 +194,7 @@ static inline int create_server_socket(const char* name)
if(socket_local_server_bind(s, name, ANDROID_SOCKET_NAMESPACE_ABSTRACT) < 0)
{
BTIF_TRACE_EVENT1("socket failed to create (%s)", strerror(errno));
+ close(s);
return -1;
}