diff options
| author | Jean Chalard <jchalard@google.com> | 2014-11-05 17:41:15 +0900 |
|---|---|---|
| committer | Jean Chalard <jchalard@google.com> | 2014-11-05 17:41:15 +0900 |
| commit | ab68143ad0fb784db38a3fd65612632fca90c789 (patch) | |
| tree | 32fa639a9b22aeb342a59ab9af55dbd2c0211c7b | |
| parent | ae55db95a74c72220961824c8054ec38b38492cb (diff) | |
| download | android_packages_inputmethods_LatinIME-ab68143ad0fb784db38a3fd65612632fca90c789.tar.gz android_packages_inputmethods_LatinIME-ab68143ad0fb784db38a3fd65612632fca90c789.tar.bz2 android_packages_inputmethods_LatinIME-ab68143ad0fb784db38a3fd65612632fca90c789.zip | |
Fix a bug where LatinIME would recorrect with no input view
Bug: 18071127
Change-Id: I634d1f63f7d5c5b7453ed7559f9b65fa0433dcd8
| -rw-r--r-- | java/src/com/android/inputmethod/latin/LatinIME.java | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/java/src/com/android/inputmethod/latin/LatinIME.java b/java/src/com/android/inputmethod/latin/LatinIME.java index c86d2b849..dc665471d 100644 --- a/java/src/com/android/inputmethod/latin/LatinIME.java +++ b/java/src/com/android/inputmethod/latin/LatinIME.java @@ -1077,11 +1077,12 @@ public class LatinIME extends InputMethodService implements KeyboardActionListen + ", cs=" + composingSpanStart + ", ce=" + composingSpanEnd); } - // This call happens when we have a hardware keyboard as well as when we don't. While we - // don't support hardware keyboards yet we should avoid doing the processing associated - // with cursor movement when we have a hardware keyboard since we are not in charge. + // This call happens whether our view is displayed or not, but if it's not then we should + // not attempt recorrection. This is true even with a hardware keyboard connected: if the + // view is not displayed we have no means of showing suggestions anyway, and if it is then + // we want to show suggestions anyway. final SettingsValues settingsValues = mSettings.getCurrent(); - if ((!settingsValues.mHasHardwareKeyboard || ProductionFlags.IS_HARDWARE_KEYBOARD_SUPPORTED) + if (isInputViewShown() && mInputLogic.onUpdateSelection(oldSelStart, oldSelEnd, newSelStart, newSelEnd, settingsValues)) { mKeyboardSwitcher.requestUpdatingShiftState(getCurrentAutoCapsState(), |