Unregister the SharedPreferenceListener when the MainFragment pauses.

am: bb47805b98

Change-Id: I559a163f44710c69ad874c89ebb8a01938e937a2

1 files changed, 8 insertions, 7 deletions

diff --git a/src/com/google/android/traceur/MainFragment.java b/src/com/google/android/traceur/MainFragment.java
index 5db3577..a3cd01f 100644
--- a/src/com/google/android/traceur/MainFragment.java
+++ b/src/com/google/android/traceur/MainFragment.java
@@ -181,9 +181,6 @@ public class MainFragment extends PreferenceFragment {
             }
         });
 
-        getPreferenceScreen().getSharedPreferences()
-            .registerOnSharedPreferenceChangeListener(mSharedPreferenceChangeListener);
-
         refreshUi();
 
         mRefreshReceiver = new BroadcastReceiver() {
@@ -202,14 +199,18 @@ public class MainFragment extends PreferenceFragment {
     }
 
     @Override
-    public void onResume() {
-        super.onResume();
+    public void onStart() {
+        super.onStart();
+        getPreferenceScreen().getSharedPreferences()
+            .registerOnSharedPreferenceChangeListener(mSharedPreferenceChangeListener);
         getActivity().registerReceiver(mRefreshReceiver, new IntentFilter(ACTION_REFRESH_TAGS));
         Receiver.updateTracing(getContext());
     }
 
     @Override
-    public void onPause() {
+    public void onStop() {
+        getPreferenceScreen().getSharedPreferences()
+            .unregisterOnSharedPreferenceChangeListener(mSharedPreferenceChangeListener);
         getActivity().unregisterReceiver(mRefreshReceiver);
 
         if (mAlertDialog != null) {
@@ -217,7 +218,7 @@ public class MainFragment extends PreferenceFragment {
             mAlertDialog = null;
         }
 
-        super.onPause();
+        super.onStop();
     }
 
     @Override