diff options
author | Ray Chen <raychen@google.com> | 2012-05-15 11:22:21 +0800 |
---|---|---|
committer | Ray Chen <raychen@google.com> | 2012-05-16 09:16:13 +0800 |
commit | 9ad7d738bd36217c85222865cf0bd539dd31a716 (patch) | |
tree | 8db52e134fbb362af774d9388bf8ca8c5c4a452e /src/com/android/gallery3d/ui | |
parent | d88db1dbe50b9e147d7d5796e82f0c7bffb03ccb (diff) | |
download | android_packages_apps_Snap-9ad7d738bd36217c85222865cf0bd539dd31a716.tar.gz android_packages_apps_Snap-9ad7d738bd36217c85222865cf0bd539dd31a716.tar.bz2 android_packages_apps_Snap-9ad7d738bd36217c85222865cf0bd539dd31a716.zip |
Fix 6046544: Deleting a photo takes multiple steps and the flow is inconsistent with other deleting flows on other core apps
Per request, change the confirm dialog message to "Delete the selected item(s)?"
b: 6046544
Change-Id: I46f7fd42a9f9fbf2399aca78ed9b2e67a15acb65
Diffstat (limited to 'src/com/android/gallery3d/ui')
-rw-r--r-- | src/com/android/gallery3d/ui/ActionModeHandler.java | 7 | ||||
-rw-r--r-- | src/com/android/gallery3d/ui/MenuExecutor.java | 8 |
2 files changed, 8 insertions, 7 deletions
diff --git a/src/com/android/gallery3d/ui/ActionModeHandler.java b/src/com/android/gallery3d/ui/ActionModeHandler.java index d8e60d3a2..c5773ed3e 100644 --- a/src/com/android/gallery3d/ui/ActionModeHandler.java +++ b/src/com/android/gallery3d/ui/ActionModeHandler.java @@ -125,14 +125,15 @@ public class ActionModeHandler implements ActionMode.Callback { } } ProgressListener listener = null; - boolean needsConfirm = false; + String confirmMsg = null; int action = item.getItemId(); if (action == R.id.action_import) { listener = new ImportCompleteListener(mActivity); } else if (item.getItemId() == R.id.action_delete) { - needsConfirm = true; + confirmMsg = mActivity.getResources().getQuantityString( + R.plurals.delete_selection, mSelectionManager.getSelectedCount()); } - mMenuExecutor.onMenuClicked(item, needsConfirm, listener); + mMenuExecutor.onMenuClicked(item, confirmMsg, listener); if (action == R.id.action_select_all) { updateSupportedOperation(); updateSelectionMenu(); diff --git a/src/com/android/gallery3d/ui/MenuExecutor.java b/src/com/android/gallery3d/ui/MenuExecutor.java index 636da3985..14bdc4d53 100644 --- a/src/com/android/gallery3d/ui/MenuExecutor.java +++ b/src/com/android/gallery3d/ui/MenuExecutor.java @@ -232,14 +232,14 @@ public class MenuExecutor { startAction(action, title, listener); } - public void onMenuClicked(MenuItem menuItem, boolean needsConfirm, + public void onMenuClicked(MenuItem menuItem, String confirmMsg, final ProgressListener listener) { final int action = menuItem.getItemId(); - if (needsConfirm) { + if (confirmMsg != null) { new AlertDialog.Builder(mActivity.getAndroidContext()) - .setMessage(R.string.confirm_action) - .setPositiveButton(R.string.confirm, new OnClickListener() { + .setMessage(confirmMsg) + .setPositiveButton(R.string.ok, new OnClickListener() { public void onClick(DialogInterface dialog, int which) { onMenuClicked(action, listener); } |