diff options
author | Axesh R. Ajmera <aajmera@codeaurora.org> | 2015-07-23 15:08:14 -0700 |
---|---|---|
committer | jrizzoli <joey@cyanogenmoditalia.it> | 2015-08-28 13:15:46 +0200 |
commit | 4a6838a6f0e18018663b6ecd69559090ef25cd73 (patch) | |
tree | 561f0a8db5f09670b875ec092e6b1352799680ce /src/com/android/browser/SnapshotTab.java | |
parent | ee99203941e22a7adac7cacd0ff126ec78921523 (diff) | |
download | android_packages_apps_Gello-4a6838a6f0e18018663b6ecd69559090ef25cd73.tar.gz android_packages_apps_Gello-4a6838a6f0e18018663b6ecd69559090ef25cd73.tar.bz2 android_packages_apps_Gello-4a6838a6f0e18018663b6ecd69559090ef25cd73.zip |
Fix issue when navigating on Snapshot Tab
- When navigating on snapshot tab, clicking on the links
in the snapshot tab causes navigation in the same tab to occur
This is wrong behaviour in terms of user experience and would
also cause issues with Edge navigation
Change-Id: I9b2f7eb27aed0209f0245ab71ee69fe087eb9161
Diffstat (limited to 'src/com/android/browser/SnapshotTab.java')
-rw-r--r-- | src/com/android/browser/SnapshotTab.java | 20 |
1 files changed, 6 insertions, 14 deletions
diff --git a/src/com/android/browser/SnapshotTab.java b/src/com/android/browser/SnapshotTab.java index 7471bca9..c63bf102 100644 --- a/src/com/android/browser/SnapshotTab.java +++ b/src/com/android/browser/SnapshotTab.java @@ -49,7 +49,6 @@ public class SnapshotTab extends Tab { private long mDateCreated; private boolean mIsLive; private String mLiveUrl; - private Bundle mSavedState; // Used for saving and restoring each Tab static final String SNAPSHOT_ID = "snapshotId"; @@ -65,6 +64,7 @@ public class SnapshotTab extends Tab { WebView web = mWebViewFactory.createWebView(false); setWebView(web); loadData(); + mIsLive = false; } @Override @@ -125,10 +125,11 @@ public class SnapshotTab extends Tab { return super.saveState(); } - mSavedState = new Bundle(); - mSavedState = super.saveState(); - mSavedState.putLong(SNAPSHOT_ID, mSnapshotId); - return mSavedState; + Bundle savedState = new Bundle(); + savedState.putLong(SNAPSHOT_ID, mSnapshotId); + savedState.putLong(ID, getId()); + + return savedState; } public long getDateCreated() { @@ -140,15 +141,6 @@ public class SnapshotTab extends Tab { } @Override - public void loadUrl(String url, Map<String, String> headers) { - if (!mIsLive) { - mIsLive = true; - getWebView().clearViewState(); - } - super.loadUrl(url, headers); - } - - @Override public boolean canGoBack() { return super.canGoBack() || mIsLive; } |