summaryrefslogtreecommitdiffstats
path: root/src/com/android/gallery3d
diff options
context:
space:
mode:
authorLikai Ding <likaid@codeaurora.org>2016-05-05 14:52:52 +0800
committerLikai Ding <likaid@codeaurora.org>2016-05-05 14:52:52 +0800
commit854893db2acad26a877a2d9c7061d0f3768f61bf (patch)
treee263b37901909843419733ff9f5f197dfc68296e /src/com/android/gallery3d
parentb04211110dce21e7c898352313f0416f6e2ac9d9 (diff)
downloadandroid_packages_apps_Gallery2-854893db2acad26a877a2d9c7061d0f3768f61bf.tar.gz
android_packages_apps_Gallery2-854893db2acad26a877a2d9c7061d0f3768f61bf.tar.bz2
android_packages_apps_Gallery2-854893db2acad26a877a2d9c7061d0f3768f61bf.zip
Gallery: fix a memory leak
If video playing is completed, not paused or cancelled, the Runnables posted are not removed from the Handler. Make sure they are removed. Change-Id: I4c27583e4305398b35188c494b6da15f809439b9 CRs-Fixed: 999702
Diffstat (limited to 'src/com/android/gallery3d')
-rw-r--r--src/com/android/gallery3d/app/MoviePlayer.java2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/com/android/gallery3d/app/MoviePlayer.java b/src/com/android/gallery3d/app/MoviePlayer.java
index 720c50428..47c9b128a 100644
--- a/src/com/android/gallery3d/app/MoviePlayer.java
+++ b/src/com/android/gallery3d/app/MoviePlayer.java
@@ -694,12 +694,14 @@ public class MoviePlayer implements
}
if (mMovieItem.getError()) {
Log.w(TAG, "error occured, exit the video player!");
+ mHandler.removeCallbacksAndMessages(null);
mActivityContext.finish();
return;
}
if (mPlayerExt.getLoop()) {
onReplay();
} else { //original logic
+ mHandler.removeCallbacksAndMessages(null);
mTState = TState.COMPELTED;
if (mCanReplay) {
mController.showEnded();