diff options
| author | Ruben Brunk <rubenbrunk@google.com> | 2013-03-18 22:23:43 -0700 |
|---|---|---|
| committer | Ruben Brunk <rubenbrunk@google.com> | 2013-03-18 23:53:26 -0700 |
| commit | f79f954f4eb23bce55061c683a07fc7b3a965451 (patch) | |
| tree | 55394501a361fa6fd14b5a332ab7783b1ec5cc1f /src/com/android/gallery3d/filtershow/filters/ImageFilterRS.java | |
| parent | b8270a94e539fc1944ae350c73b00b9df45832d5 (diff) | |
| download | android_packages_apps_Gallery2-f79f954f4eb23bce55061c683a07fc7b3a965451.tar.gz android_packages_apps_Gallery2-f79f954f4eb23bce55061c683a07fc7b3a965451.tar.bz2 android_packages_apps_Gallery2-f79f954f4eb23bce55061c683a07fc7b3a965451.zip | |
ImageFilterRS filters reset properly. FilterPipeline delay till after load.
Bug: 8293404
Bug: 8417804
Change-Id: I4e3fbbdb86bcb790d73455f21044e6dee9398a5d
Diffstat (limited to 'src/com/android/gallery3d/filtershow/filters/ImageFilterRS.java')
| -rw-r--r-- | src/com/android/gallery3d/filtershow/filters/ImageFilterRS.java | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/com/android/gallery3d/filtershow/filters/ImageFilterRS.java b/src/com/android/gallery3d/filtershow/filters/ImageFilterRS.java index 729aef806..246192c2d 100644 --- a/src/com/android/gallery3d/filtershow/filters/ImageFilterRS.java +++ b/src/com/android/gallery3d/filtershow/filters/ImageFilterRS.java @@ -199,11 +199,16 @@ public abstract class ImageFilterRS extends ImageFilter { mResourcesLoaded = resourcesLoaded; } - // TODO: - // Ideally, every filter would destroy _every_ renderscript allocation, - // script, and anything else that depends on a certain RS context here. + /** + * Bitmaps and RS Allocations should be cleared here + */ abstract protected void resetAllocations(); + /** + * RS Script objects (and all other RS objects) should be cleared here + */ + abstract protected void resetScripts(); + public void freeResources() { if (!isResourcesLoaded()) { return; |