diff options
| author | John Reck <jreck@google.com> | 2012-09-26 16:20:09 -0700 |
|---|---|---|
| committer | John Reck <jreck@google.com> | 2012-09-26 16:22:21 -0700 |
| commit | 2ce4bec82fd46ff71ee4a586719904a6313689bf (patch) | |
| tree | 6fa775cbe8f5172a7e548a0d5a2c81ff4473dc63 | |
| parent | 8fe22ecb8e744a09a2e0d867f876ecbf74c82298 (diff) | |
| download | android_packages_apps_Gallery2-2ce4bec82fd46ff71ee4a586719904a6313689bf.tar.gz android_packages_apps_Gallery2-2ce4bec82fd46ff71ee4a586719904a6313689bf.tar.bz2 android_packages_apps_Gallery2-2ce4bec82fd46ff71ee4a586719904a6313689bf.zip | |
Only create debugTag if necessary
Bug: 7238418
String concatenation isn't free
Change-Id: I510a89ef8b673efb631d6f8929ab3d9d9b454931
| -rw-r--r-- | src/com/android/gallery3d/data/ImageCacheRequest.java | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/src/com/android/gallery3d/data/ImageCacheRequest.java b/src/com/android/gallery3d/data/ImageCacheRequest.java index b977b1016..3f937e365 100644 --- a/src/com/android/gallery3d/data/ImageCacheRequest.java +++ b/src/com/android/gallery3d/data/ImageCacheRequest.java @@ -41,11 +41,14 @@ abstract class ImageCacheRequest implements Job<Bitmap> { mTargetSize = targetSize; } + private String debugTag() { + return mPath + "," + + ((mType == MediaItem.TYPE_THUMBNAIL) ? "THUMB" : + (mType == MediaItem.TYPE_MICROTHUMBNAIL) ? "MICROTHUMB" : "?"); + } + @Override public Bitmap run(JobContext jc) { - String debugTag = mPath + "," + - ((mType == MediaItem.TYPE_THUMBNAIL) ? "THUMB" : - (mType == MediaItem.TYPE_MICROTHUMBNAIL) ? "MICROTHUMB" : "?"); ImageCacheService cacheService = mApplication.getImageCacheService(); BytesBuffer buffer = MediaItem.getBytesBufferPool().get(); @@ -66,7 +69,7 @@ abstract class ImageCacheRequest implements Job<Bitmap> { MediaItem.getThumbPool()); } if (bitmap == null && !jc.isCancelled()) { - Log.w(TAG, "decode cached failed " + debugTag); + Log.w(TAG, "decode cached failed " + debugTag()); } return bitmap; } @@ -77,7 +80,7 @@ abstract class ImageCacheRequest implements Job<Bitmap> { if (jc.isCancelled()) return null; if (bitmap == null) { - Log.w(TAG, "decode orig failed " + debugTag); + Log.w(TAG, "decode orig failed " + debugTag()); return null; } |