diff options
author | Marc Blank <mblank@google.com> | 2010-07-08 10:08:47 -0700 |
---|---|---|
committer | Marc Blank <mblank@google.com> | 2010-07-21 19:01:41 -0700 |
commit | e6cc662abc0b5fffe223cda5e980b4f05a4e91dd (patch) | |
tree | 98b87c591883c4cc2b5c8cf0200a96cacf1b170e /tests/src/com/android/email/activity/setup/AccountSetupIncomingTests.java | |
parent | d6a2978857e0866d7441f8e140338477545d59a5 (diff) | |
download | android_packages_apps_Email-e6cc662abc0b5fffe223cda5e980b4f05a4e91dd.tar.gz android_packages_apps_Email-e6cc662abc0b5fffe223cda5e980b4f05a4e91dd.tar.bz2 android_packages_apps_Email-e6cc662abc0b5fffe223cda5e980b4f05a4e91dd.zip |
Use AccountManager for POP/IMAP; refactor setup classes
There are two major, interrelated parts to this CL:
1) Clean up the activities to reduce the use of Intents to pass
information between activities; instead, we use a common
SetupData structure that automatically saved/restored as necessary
during the setup flow. A fair amount of code and inconsistent
use of Bundle extras has been eliminated in the process.
* Create SetupData structure, setters/getters, and initialization
methods to simplify the preservation of state during setup flow
* Remove all state/flow extras from Intents; Intents now only
specify the Activity to be started, which should greatly simplify
the transition to Fragments.
* Remove all state/flow fields from Activities
* Modify existing setup activity unit tests and confirm tests pass
2) Create AccountManager accounts for POP/IMAP email accounts to
provide consistency in user experience. Also, internal flows are
now identical as between account types.
* Move account reconciliation from SyncManager to MailService, so
that reconciliation is consistent between email and exchange
accounts; move unit tests as appropriate
* Add a "Sync Email" setting for POP/IMAP/EAS
* Change MailService to respect the "Sync Email" setting in
Settings -> Accounts & sync
* Create PopImapSyncAdapterService to handle manual POP/IMAP sync as
requested by SyncManager; add EmailSyncAdapterService to perform
the same function for EAS
* Use new PopImapAuthenticatorService to add AccountManager accounts
for POP/IMAP accounts; setup appropriate stanzas in AndroidManifest
and add related xml files
* Update AccountSettings to use SetupData
Miscellaneous other changes:
* Only allow valid port numbers in incoming/outgoing setup
Bug: 1712475
Change-Id: Ibdac52fb2c5578b86bf3992ddb1acd10f162391a
Diffstat (limited to 'tests/src/com/android/email/activity/setup/AccountSetupIncomingTests.java')
-rw-r--r-- | tests/src/com/android/email/activity/setup/AccountSetupIncomingTests.java | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/tests/src/com/android/email/activity/setup/AccountSetupIncomingTests.java b/tests/src/com/android/email/activity/setup/AccountSetupIncomingTests.java index 96753f489..7498de2a2 100644 --- a/tests/src/com/android/email/activity/setup/AccountSetupIncomingTests.java +++ b/tests/src/com/android/email/activity/setup/AccountSetupIncomingTests.java @@ -28,14 +28,13 @@ import android.widget.EditText; /** * Tests of the basic UI logic in the Account Setup Incoming (IMAP / POP3) screen. + * You can run this entire test case with: + * runtest -c com.android.email.activity.setup.AccountSetupIncomingTests email */ @MediumTest public class AccountSetupIncomingTests extends ActivityInstrumentationTestCase2<AccountSetupIncoming> { - // borrowed from AccountSetupIncoming - private static final String EXTRA_ACCOUNT = "account"; - private AccountSetupIncoming mActivity; private EditText mServerView; private Button mNextButton; @@ -146,9 +145,8 @@ public class AccountSetupIncomingTests extends private Intent getTestIntent(String storeUriString) { EmailContent.Account account = new EmailContent.Account(); account.setStoreUri(getInstrumentation().getTargetContext(), storeUriString); - Intent i = new Intent(Intent.ACTION_MAIN); - i.putExtra(EXTRA_ACCOUNT, account); - return i; + SetupData.init(SetupData.FLOW_MODE_NORMAL, account); + return new Intent(Intent.ACTION_MAIN); } } |