Do not try to load nameless attachments.

Bug: 11347094
Change-Id: I46321755cebe25858c0188f35270d428dfe4a435

1 files changed, 7 insertions, 0 deletions

diff --git a/emailcommon/src/com/android/emailcommon/utility/AttachmentUtilities.java b/emailcommon/src/com/android/emailcommon/utility/AttachmentUtilities.java
index 2f807d737..e889f9774 100644
--- a/emailcommon/src/com/android/emailcommon/utility/AttachmentUtilities.java
+++ b/emailcommon/src/com/android/emailcommon/utility/AttachmentUtilities.java
@@ -395,6 +395,13 @@ public class AttachmentUtilities {
                 size = copyFile(in, resolver.openOutputStream(attUri));
                 contentUri = attUri.toString();
             } else if (Utility.isExternalStorageMounted()) {
+                if (attachment.mFileName == null) {
+                    // TODO: This will prevent a crash but does not surface the underlying problem
+                    // to the user correctly.
+                    LogUtils.w(Logging.LOG_TAG, "Trying to save an attachment with no name: %d",
+                            attachmentId);
+                    throw new IOException("Can't save an attachment with no name");
+                }
                 File downloads = Environment.getExternalStoragePublicDirectory(
                         Environment.DIRECTORY_DOWNLOADS);
                 downloads.mkdirs();