summaryrefslogtreecommitdiffstats
path: root/src/com/android/dialerbind
diff options
context:
space:
mode:
authorAndrew Lee <anwlee@google.com>2015-04-06 16:32:06 -0700
committerAndrew Lee <anwlee@google.com>2015-04-06 16:47:36 -0700
commitc6fde8d1b9a4e586ca65b82e9911089a9da14508 (patch)
tree39359b89dc0980fe551ae3134aca74c470285e48 /src/com/android/dialerbind
parent2370e85a8203b4dc3722f2e013124e1e88d15b7c (diff)
downloadandroid_packages_apps_Dialer-c6fde8d1b9a4e586ca65b82e9911089a9da14508.tar.gz
android_packages_apps_Dialer-c6fde8d1b9a4e586ca65b82e9911089a9da14508.tar.bz2
android_packages_apps_Dialer-c6fde8d1b9a4e586ca65b82e9911089a9da14508.zip
Remove expand/collapse animations in the Call Log.
- Remove animation logic in CallLogFragment. - Remove expand listener from CallLogAdapter. + Update tests and constructor. This preemptively removes expand/collapse behavior. While this will result in a janky short-term experience, this is an incremental step in shifting to RecyclerView and the new "Card" UI. I figured it would be most efficient to delete it straight up, rather than coding in intermediate logic to work with the RecyclerView because it will be made obsolete by the Cards UI anyways. In the long run, expand/collapse animation behavior will be restored once the call log is migrated to RecyclerView and converted to Cards. Bug: 19372817 Change-Id: Icbdc7dcb9f2f2223456c29334c826d38917b087a
Diffstat (limited to 'src/com/android/dialerbind')
-rw-r--r--src/com/android/dialerbind/ObjectFactory.java12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/com/android/dialerbind/ObjectFactory.java b/src/com/android/dialerbind/ObjectFactory.java
index e5c39d078..dfacd3f6d 100644
--- a/src/com/android/dialerbind/ObjectFactory.java
+++ b/src/com/android/dialerbind/ObjectFactory.java
@@ -42,15 +42,15 @@ public class ObjectFactory {
* @param context The context to use.
* @param callFetcher Instance of call fetcher to use.
* @param contactInfoHelper Instance of contact info helper class to use.
- * @param isCallLog Is this call log adapter being used on the call log?
* @return Instance of CallLogAdapter.
*/
- public static CallLogAdapter newCallLogAdapter(Context context,
- CallFetcher callFetcher, ContactInfoHelper contactInfoHelper,
- CallItemExpandedListener callItemExpandedListener,
+ public static CallLogAdapter newCallLogAdapter(
+ Context context,
+ CallFetcher callFetcher,
+ ContactInfoHelper contactInfoHelper,
OnReportButtonClickListener onReportButtonClickListener) {
- return new CallLogAdapter(context, callFetcher, contactInfoHelper,
- callItemExpandedListener, onReportButtonClickListener);
+ return new CallLogAdapter(
+ context, callFetcher, contactInfoHelper, onReportButtonClickListener);
}
public static DialogFragment getReportDialogFragment(String number) {