Fix broken contacts common unit tests

* Brian informs me that he (or Makoto) changed the
  external account type constructor to not abort
  if it doesn't parse the xml so I updated the test
  for unknown packages to expect to get initialized.

* Looks like an omission that SIP address does not
  have a maxOccurs set to 1 when initilized.  I tried
  to change the test data file contacts_fallback.xml
  to not include a maxOccurs attr but it needs one
  and it must be set to 1.

Bug 15413731

Change-Id: I4a8a297799686885eaa64868a2b8c0f25c177f4b

1 files changed, 1 insertions, 15 deletions

diff --git a/tests/src/com/android/contacts/common/model/account/ExternalAccountTypeTest.java b/tests/src/com/android/contacts/common/model/account/ExternalAccountTypeTest.java
index 7e799f2f..d508e0fc 100644
--- a/tests/src/com/android/contacts/common/model/account/ExternalAccountTypeTest.java
+++ b/tests/src/com/android/contacts/common/model/account/ExternalAccountTypeTest.java
@@ -69,27 +69,13 @@ public class ExternalAccountTypeTest extends AndroidTestCase {
     }
 
     /**
-     * Initialize with an invalid package name and see if type type will *not* be initialized.
+     * Initialize with an invalid package name and see if type will be initialized, but empty.
      */
     public void testNoPackage() {
         final ExternalAccountType type = new ExternalAccountType(getContext(),
                 "!!!no such package name!!!", false);
-        assertFalse(type.isInitialized());
-    }
-
-    /**
-     * Initialize with the name of an existing package, which has no contacts.xml metadata.
-     */
-    /*
-    public void testNoMetadata() {
-        // Use the main application package, which does exist, but has no contacts.xml in it.
-        String packageName = getContext().getPackageName();
-        Log.e("TEST", packageName);
-        final ExternalAccountType type = new ExternalAccountType(getContext(),
-                packageName, false);
         assertTrue(type.isInitialized());
     }
-    */
 
     /**
      * Initialize with the test package itself and see if EditSchema is correctly parsed.