diff options
author | jruesga <jorge@ruesga.com> | 2012-10-02 01:07:25 +0200 |
---|---|---|
committer | jruesga <jorge@ruesga.com> | 2012-10-02 01:07:25 +0200 |
commit | d7edde7b4df07c5582da8229cd7d7087d4874a77 (patch) | |
tree | 70aea6d76a76a58848205c3f9671a9dfc67739a2 | |
parent | f59d49db099be5e5a36840553cb2172f38d61a40 (diff) | |
download | android_packages_apps_CMFileManager-d7edde7b4df07c5582da8229cd7d7087d4874a77.tar.gz android_packages_apps_CMFileManager-d7edde7b4df07c5582da8229cd7d7087d4874a77.tar.bz2 android_packages_apps_CMFileManager-d7edde7b4df07c5582da8229cd7d7087d4874a77.zip |
Remove synthetic-access for better access performance
http://developer.android.com/guide/practices/performance.html#package_inner
25 files changed, 315 insertions, 154 deletions
diff --git a/src/com/cyanogenmod/explorer/activities/BookmarksActivity.java b/src/com/cyanogenmod/explorer/activities/BookmarksActivity.java index f7810f71..af28d0c7 100644 --- a/src/com/cyanogenmod/explorer/activities/BookmarksActivity.java +++ b/src/com/cyanogenmod/explorer/activities/BookmarksActivity.java @@ -135,7 +135,7 @@ public class BookmarksActivity extends Activity implements OnItemClickListener, /** * Method that makes the refresh of the data. */ - private void refresh() { + void refresh() { BookmarksAdapter adapter = (BookmarksAdapter)this.mBookmarksListView.getAdapter(); adapter.clear(); adapter.addAll(loadBookmarks()); @@ -196,7 +196,6 @@ public class BookmarksActivity extends Activity implements OnItemClickListener, InitialDirectoryDialog dialog = new InitialDirectoryDialog(this); dialog.setOnValueChangedListener(new InitialDirectoryDialog.OnValueChangedListener() { @Override - @SuppressWarnings("synthetic-access") public void onValueChanged(String newInitialDir) { refresh(); } diff --git a/src/com/cyanogenmod/explorer/activities/NavigationActivity.java b/src/com/cyanogenmod/explorer/activities/NavigationActivity.java index a894e10e..c982774b 100644 --- a/src/com/cyanogenmod/explorer/activities/NavigationActivity.java +++ b/src/com/cyanogenmod/explorer/activities/NavigationActivity.java @@ -903,7 +903,6 @@ public class NavigationActivity extends Activity final int itemId = (int)id; getCurrentNavigationView().post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { popup.dismiss(); switch (itemId) { @@ -1181,8 +1180,9 @@ public class NavigationActivity extends Activity /** * Method that opens the bookmarks activity. + * @hide */ - private void openBookmarks() { + void openBookmarks() { Intent bookmarksIntent = new Intent(this, BookmarksActivity.class); bookmarksIntent.addFlags(Intent.FLAG_ACTIVITY_TASK_ON_HOME); startActivityForResult(bookmarksIntent, INTENT_REQUEST_BOOKMARK); @@ -1190,8 +1190,9 @@ public class NavigationActivity extends Activity /** * Method that opens the history activity. + * @hide */ - private void openHistory() { + void openHistory() { Intent historyIntent = new Intent(this, HistoryActivity.class); historyIntent.putExtra(HistoryActivity.EXTRA_HISTORY_LIST, (Serializable)this.mHistory); historyIntent.addFlags(Intent.FLAG_ACTIVITY_TASK_ON_HOME); @@ -1200,8 +1201,9 @@ public class NavigationActivity extends Activity /** * Method that opens the search activity. + * @hide */ - private void openSearch() { + void openSearch() { onSearchRequested(); } diff --git a/src/com/cyanogenmod/explorer/activities/SearchActivity.java b/src/com/cyanogenmod/explorer/activities/SearchActivity.java index 88efc7b5..a71bf9cf 100644 --- a/src/com/cyanogenmod/explorer/activities/SearchActivity.java +++ b/src/com/cyanogenmod/explorer/activities/SearchActivity.java @@ -113,7 +113,6 @@ public class SearchActivity extends Activity private final BroadcastReceiver mOnSettingChangeReceiver = new BroadcastReceiver() { @Override - @SuppressWarnings("synthetic-access") public void onReceive(Context context, Intent intent) { if (intent != null && intent.getAction().compareTo(ExplorerSettings.INTENT_SETTING_CHANGED) == 0) { @@ -162,23 +161,51 @@ public class SearchActivity extends Activity } }; + /** + * @hide + */ + MessageProgressDialog mDialog = null; + /** + * @hide + */ + AsyncResultExecutable mExecutable = null; - private MessageProgressDialog mDialog = null; - private AsyncResultExecutable mExecutable = null; - - private ListView mSearchListView; - private ProgressBar mSearchWaiting; - private TextView mSearchFoundItems; - private TextView mSearchTerms; + /** + * @hide + */ + ListView mSearchListView; + /** + * @hide + */ + ProgressBar mSearchWaiting; + /** + * @hide + */ + TextView mSearchFoundItems; + /** + * @hide + */ + TextView mSearchTerms; private View mEmptyListMsg; -// private SearchResultAdapter mAdapter; - private DefaultLongClickAction mDefaultLongClickAction; + /** + * @hide + */ + DefaultLongClickAction mDefaultLongClickAction; private String mSearchDirectory; - private List<FileSystemObject> mResultList; - private Query mQuery; + /** + * @hide + */ + List<FileSystemObject> mResultList; + /** + * @hide + */ + Query mQuery; - private SearchInfoParcelable mRestoreState; + /** + * @hide + */ + SearchInfoParcelable mRestoreState; private SearchResultDrawingAsyncTask mDrawingSearchResultTask; @@ -463,7 +490,6 @@ public class SearchActivity extends Activity this, R.string.search_few_characters_msg, new DialogInterface.OnClickListener() { @Override - @SuppressWarnings("synthetic-access") public void onClick(DialogInterface alertDialog, int which) { if (which == DialogInterface.BUTTON_NEGATIVE) { doSearch(voiceQuery, query, searchDirectory); @@ -483,8 +509,9 @@ public class SearchActivity extends Activity * @param voiceQuery Indicates if the query is from voice recognition * @param query The terms of the search * @param searchDirectory The directory of the search + * @hide */ - private void doSearch( + void doSearch( final boolean voiceQuery, final Query query, final String searchDirectory) { // Recovers the user preferences about save suggestions @@ -522,7 +549,6 @@ public class SearchActivity extends Activity //Now, do the search in background this.mSearchListView.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { try { //Retrieve the terms of the search @@ -599,7 +625,6 @@ public class SearchActivity extends Activity private void loadFromCacheData() { this.mSearchListView.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { //Toggle results List<SearchResult> list = SearchActivity.this.mRestoreState.getSearchResultList(); @@ -673,8 +698,9 @@ public class SearchActivity extends Activity /** * Method that removes all items and display a message. + * @hide */ - private void removeAll() { + void removeAll() { SearchResultAdapter adapter = (SearchResultAdapter)this.mSearchListView.getAdapter(); adapter.clear(); adapter.notifyDataSetChanged(); @@ -687,8 +713,9 @@ public class SearchActivity extends Activity * * @param hasResults Indicates if there are results * @param showEmpty Show the empty list message + * @hide */ - private void toggleResults(boolean hasResults, boolean showEmpty) { + void toggleResults(boolean hasResults, boolean showEmpty) { this.mSearchListView.setVisibility(hasResults ? View.VISIBLE : View.INVISIBLE); this.mEmptyListMsg.setVisibility(!hasResults && showEmpty ? View.VISIBLE : View.INVISIBLE); } @@ -698,12 +725,12 @@ public class SearchActivity extends Activity * * @param items The number of items * @param searchDirectory The search directory path + * @hide */ - private void setFoundItems(final int items, final String searchDirectory) { + void setFoundItems(final int items, final String searchDirectory) { if (this.mSearchFoundItems != null) { this.mSearchFoundItems.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { String foundItems = getResources(). @@ -903,8 +930,9 @@ public class SearchActivity extends Activity * * @param canceled Indicates if the activity was canceled * @param directory The directory to which navigate to + * @hide */ - private void back(final boolean canceled, String directory) { + void back(final boolean canceled, String directory) { Intent intent = new Intent(); if (canceled) { if (SearchActivity.this.mDrawingSearchResultTask != null @@ -934,7 +962,6 @@ public class SearchActivity extends Activity public void onAsyncStart() { runOnUiThread(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { SearchActivity.this.toggleResults(false, false); } @@ -948,7 +975,6 @@ public class SearchActivity extends Activity public void onAsyncEnd(boolean cancelled) { this.mSearchListView.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { try { //Dismiss the dialog @@ -982,7 +1008,6 @@ public class SearchActivity extends Activity //Notify progress this.mSearchListView.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { if (SearchActivity.this.mDialog != null) { SearchActivity.this.mDialog.setProgress( @@ -1003,8 +1028,9 @@ public class SearchActivity extends Activity /** * Method that draw the results in the listview + * @hide */ - private void drawResults() { + void drawResults() { //Toggle results this.toggleResults(this.mResultList.size() > 0, true); setFoundItems(this.mResultList.size(), this.mSearchDirectory); diff --git a/src/com/cyanogenmod/explorer/activities/preferences/SettingsPreferences.java b/src/com/cyanogenmod/explorer/activities/preferences/SettingsPreferences.java index 4f990aaf..1e2bbb6d 100644 --- a/src/com/cyanogenmod/explorer/activities/preferences/SettingsPreferences.java +++ b/src/com/cyanogenmod/explorer/activities/preferences/SettingsPreferences.java @@ -121,12 +121,14 @@ public class SettingsPreferences extends PreferenceActivity { private CheckBoxPreference mComputeFolderStatistics; private CheckBoxPreference mAllowConsoleSelection; - private boolean mLoaded = false; + /** + * @hide + */ + boolean mLoaded = false; private final OnPreferenceChangeListener mOnChangeListener = new OnPreferenceChangeListener() { @Override - @SuppressWarnings("synthetic-access") public boolean onPreferenceChange(Preference preference, Object newValue) { String key = preference.getKey(); if (DEBUG) Log.d(LOG_TAG, @@ -241,12 +243,14 @@ public class SettingsPreferences extends PreferenceActivity { private CheckBoxPreference mSaveSearchTerms; private Preference mRemoveSearchTerms; - private boolean mLoaded = false; + /** + * @hide + */ + boolean mLoaded = false; private final OnPreferenceChangeListener mOnChangeListener = new OnPreferenceChangeListener() { @Override - @SuppressWarnings("synthetic-access") public boolean onPreferenceChange(Preference preference, Object newValue) { String key = preference.getKey(); if (DEBUG) Log.d(LOG_TAG, @@ -288,7 +292,6 @@ public class SettingsPreferences extends PreferenceActivity { private final OnPreferenceClickListener mOnClickListener = new Preference.OnPreferenceClickListener() { @Override - @SuppressWarnings("synthetic-access") public boolean onPreferenceClick(Preference preference) { if (preference.getKey().compareTo(REMOVE_SEARCH_TERMS_KEY) == 0) { // Remove search terms @@ -359,8 +362,9 @@ public class SettingsPreferences extends PreferenceActivity { /** * Method that removes the recent suggestions on search activity + * @hide */ - private void clearRecentSearchTerms() { + void clearRecentSearchTerms() { SearchRecentSuggestions suggestions = new SearchRecentSuggestions(getActivity(), RecentSearchesContentProvider.AUTHORITY, diff --git a/src/com/cyanogenmod/explorer/commands/shell/AsyncResultProgram.java b/src/com/cyanogenmod/explorer/commands/shell/AsyncResultProgram.java index c35f056d..e765369a 100644 --- a/src/com/cyanogenmod/explorer/commands/shell/AsyncResultProgram.java +++ b/src/com/cyanogenmod/explorer/commands/shell/AsyncResultProgram.java @@ -33,9 +33,15 @@ public abstract class AsyncResultProgram private final AsyncResultListener mAsyncResultListener; private AsyncResultProgramThread mWorkerThread; - private final List<String> mPartialData; + /** + * @hide + */ + final List<String> mPartialData; private final Object mSync = new Object(); - private final Object mTerminateSync = new Object(); + /** + * @hide + */ + final Object mTerminateSync = new Object(); private boolean mCanceled; private OnCancelListener mOnCancelListener; @@ -249,7 +255,6 @@ public abstract class AsyncResultProgram * {@inheritDoc} */ @Override - @SuppressWarnings("synthetic-access") public void run() { try { this.mAlive = true; diff --git a/src/com/cyanogenmod/explorer/console/shell/ShellConsole.java b/src/com/cyanogenmod/explorer/console/shell/ShellConsole.java index fade8484..5e691143 100644 --- a/src/com/cyanogenmod/explorer/console/shell/ShellConsole.java +++ b/src/com/cyanogenmod/explorer/console/shell/ShellConsole.java @@ -81,25 +81,46 @@ public abstract class ShellConsole extends Console { //Process References private final Object mSync = new Object(); private final Object mPartialSync = new Object(); - private boolean mActive = false; + /** + * @hide + */ + boolean mActive = false; private boolean mFinished = true; private Process mProc = null; - private Program mActiveCommand = null; - private boolean mCancelled; - private boolean mStarted; + /** + * @hide + */ + Program mActiveCommand = null; + /** + * @hide + */ + boolean mCancelled; + /** + * @hide + */ + boolean mStarted; //Buffers private InputStream mIn = null; private InputStream mErr = null; private OutputStream mOut = null; - private StringBuffer mSbIn = null; - private StringBuffer mSbErr = null; + /** + * @hide + */ + StringBuffer mSbIn = null; + /** + * @hide + */ + StringBuffer mSbErr = null; private final SecureRandom mRandom; private String mStartControlPattern; private String mEndControlPattern; - private int mBufferSize; + /** + * @hide + */ + int mBufferSize; private final ShellExecutableFactory mExecutableFactory; @@ -355,7 +376,6 @@ public abstract class ShellConsole extends Console { if (executable instanceof AsyncResultExecutable) { Thread asyncThread = new Thread(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { //Synchronous execution (but asynchronous running in a thread) //This way syncExecute is locked until this thread ends @@ -396,8 +416,9 @@ public abstract class ShellConsole extends Console { * @throws OperationTimeoutException If the operation exceeded the maximum time of wait * @throws ExecutionException If the operation returns a invalid exit code * @throws ReadOnlyFilesystemException If the operation writes in a read-only filesystem + * @hide */ - private synchronized boolean syncExecute(final Program program, boolean reallocate) + synchronized boolean syncExecute(final Program program, boolean reallocate) throws ConsoleAllocException, InsufficientPermissionsException, CommandNotFoundException, NoSuchFileOrDirectory, OperationTimeoutException, ExecutionException, ReadOnlyFilesystemException { @@ -571,7 +592,6 @@ public abstract class ShellConsole extends Console { private Thread createStdInThread(final InputStream in) { Thread t = new Thread(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { int read = 0; try { @@ -691,7 +711,6 @@ public abstract class ShellConsole extends Console { private Thread createStdErrThread(final InputStream err) { Thread t = new Thread(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { int read = 0; try { @@ -780,8 +799,9 @@ public abstract class ShellConsole extends Console { /** * Method that verifies if the process had exited. + * @hide */ - private void checkIfProcessExits() { + void checkIfProcessExits() { try { if (this.mProc != null) { synchronized (ShellConsole.this.mSync) { @@ -799,8 +819,9 @@ public abstract class ShellConsole extends Console { * * @param ex The exception, only if the process exit with a exception. * Otherwise null + * @hide */ - private void notifyProcessExit(Exception ex) { + void notifyProcessExit(Exception ex) { synchronized (ShellConsole.this.mSync) { if (this.mActive) { this.mSync.notify(); @@ -815,8 +836,9 @@ public abstract class ShellConsole extends Console { /** * Method that notifies the ending of the command execution. + * @hide */ - private void notifyProcessFinished() { + void notifyProcessFinished() { synchronized (ShellConsole.this.mSync) { if (this.mActive) { this.mSync.notify(); @@ -832,8 +854,9 @@ public abstract class ShellConsole extends Console { * * @param stdin The standard in buffer * @return boolean If the command has started + * @hide */ - private boolean isCommandStarted(StringBuffer stdin) { + boolean isCommandStarted(StringBuffer stdin) { Pattern pattern = Pattern.compile(this.mStartControlPattern); Matcher matcher = pattern.matcher(stdin.toString()); if (matcher.find()) { @@ -849,8 +872,9 @@ public abstract class ShellConsole extends Console { * * @param stdin The standard in buffer * @return boolean If the command has finished + * @hide */ - private boolean isCommandFinished(StringBuffer stdin) { + boolean isCommandFinished(StringBuffer stdin) { Pattern pattern = Pattern.compile(this.mEndControlPattern); Matcher matcher = pattern.matcher(stdin.toString()); return matcher.find(); @@ -889,9 +913,9 @@ public abstract class ShellConsole extends Console { * text to ensure that the exit code is in there. * * @param sb The buffer to trim + * @hide */ - @SuppressWarnings("static-method") - private void trimBuffer(StringBuffer sb) { + @SuppressWarnings("static-method") void trimBuffer(StringBuffer sb) { final int bufferSize = 200; if (sb.length() > bufferSize) { sb.delete(0, sb.length() - bufferSize); diff --git a/src/com/cyanogenmod/explorer/model/Bookmark.java b/src/com/cyanogenmod/explorer/model/Bookmark.java index c7e318f0..5ff0c745 100644 --- a/src/com/cyanogenmod/explorer/model/Bookmark.java +++ b/src/com/cyanogenmod/explorer/model/Bookmark.java @@ -122,8 +122,9 @@ public class Bookmark implements Serializable, Comparable<Bookmark>, Parcelable * @param type The type of the bookmark * @param name The name of the bookmark * @param directory The directory that the bookmark points to + * @hide */ - private Bookmark(int id, BOOKMARK_TYPE type, String name, String directory) { + Bookmark(int id, BOOKMARK_TYPE type, String name, String directory) { super(); this.mId = id; this.mType = type; @@ -231,7 +232,6 @@ public class Bookmark implements Serializable, Comparable<Bookmark>, Parcelable */ public static final Parcelable.Creator<Bookmark> CREATOR = new Parcelable.Creator<Bookmark>() { @Override - @SuppressWarnings("synthetic-access") public Bookmark createFromParcel(Parcel in) { int id = in.readInt(); BOOKMARK_TYPE type = BOOKMARK_TYPE.valueOf(in.readString()); diff --git a/src/com/cyanogenmod/explorer/tasks/FilesystemAsyncTask.java b/src/com/cyanogenmod/explorer/tasks/FilesystemAsyncTask.java index 449ce6db..e98162dd 100644 --- a/src/com/cyanogenmod/explorer/tasks/FilesystemAsyncTask.java +++ b/src/com/cyanogenmod/explorer/tasks/FilesystemAsyncTask.java @@ -34,13 +34,28 @@ import com.cyanogenmod.explorer.util.MountPointHelper; */ public class FilesystemAsyncTask extends AsyncTask<String, Integer, Boolean> { - private final ImageView mMountPointInfo; - private final ProgressBar mDiskUsageInfo; - private final int mFreeDiskSpaceWarningLevel; + /** + * @hide + */ + final ImageView mMountPointInfo; + /** + * @hide + */ + final ProgressBar mDiskUsageInfo; + /** + * @hide + */ + final int mFreeDiskSpaceWarningLevel; private boolean mRunning; - private static int sColorFilterNormal; - private static int sColorFilterWarning; + /** + * @hide + */ + static int sColorFilterNormal; + /** + * @hide + */ + static int sColorFilterWarning; /** * Constructor of <code>FilesystemAsyncTask</code>. @@ -99,7 +114,6 @@ public class FilesystemAsyncTask extends AsyncTask<String, Integer, Boolean> { } this.mMountPointInfo.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { FilesystemAsyncTask.this.mMountPointInfo.setImageResource( R.drawable.ic_holo_light_fs_warning); @@ -113,7 +127,6 @@ public class FilesystemAsyncTask extends AsyncTask<String, Integer, Boolean> { } this.mMountPointInfo.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { FilesystemAsyncTask.this.mMountPointInfo.setImageResource( MountPointHelper.isReadOnly(mp) @@ -129,7 +142,6 @@ public class FilesystemAsyncTask extends AsyncTask<String, Integer, Boolean> { } this.mDiskUsageInfo.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { final DiskUsage du = MountPointHelper.getMountPointDiskUsage(mp); int usage = 0; diff --git a/src/com/cyanogenmod/explorer/tasks/SearchResultDrawingAsyncTask.java b/src/com/cyanogenmod/explorer/tasks/SearchResultDrawingAsyncTask.java index 3f48379b..2215ba8d 100644 --- a/src/com/cyanogenmod/explorer/tasks/SearchResultDrawingAsyncTask.java +++ b/src/com/cyanogenmod/explorer/tasks/SearchResultDrawingAsyncTask.java @@ -45,12 +45,24 @@ import java.util.List; */ public class SearchResultDrawingAsyncTask extends AsyncTask<Object, Integer, Boolean> { - private final ListView mSearchListView; - private final ProgressBar mSearchWaiting; + /** + * @hide + */ + final ListView mSearchListView; + /** + * @hide + */ + final ProgressBar mSearchWaiting; private final List<FileSystemObject> mFiles; - private final Query mQueries; + /** + * @hide + */ + final Query mQueries; private boolean mRunning; - private final OnRequestMenuListener mOnRequestMenuListener; + /** + * @hide + */ + final OnRequestMenuListener mOnRequestMenuListener; /** * Constructor of <code>SearchResultDrawingAsyncTask</code>. @@ -120,7 +132,6 @@ public class SearchResultDrawingAsyncTask extends AsyncTask<Object, Integer, Boo this.mSearchListView.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { //Add list to the listview if (SearchResultDrawingAsyncTask.this.mSearchListView.getAdapter() != null) { @@ -186,7 +197,6 @@ public class SearchResultDrawingAsyncTask extends AsyncTask<Object, Integer, Boo if (this.mSearchWaiting != null) { this.mSearchWaiting.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { SearchResultDrawingAsyncTask.this.mSearchWaiting.setVisibility( show ? View.VISIBLE : View.GONE); diff --git a/src/com/cyanogenmod/explorer/ui/dialogs/ActionsDialog.java b/src/com/cyanogenmod/explorer/ui/dialogs/ActionsDialog.java index daa52a93..f3e3b065 100644 --- a/src/com/cyanogenmod/explorer/ui/dialogs/ActionsDialog.java +++ b/src/com/cyanogenmod/explorer/ui/dialogs/ActionsDialog.java @@ -51,7 +51,10 @@ public class ActionsDialog implements OnItemClickListener, OnItemLongClickListen private final Context mContext; private final boolean mGlobal; - private AlertDialog mDialog; + /** + * @hide + */ + AlertDialog mDialog; private ListView mListView; private final FileSystemObject mFso; @@ -233,7 +236,6 @@ public class ActionsDialog implements OnItemClickListener, OnItemLongClickListen menuItem.getTitle().toString()); inputNameDialog.setOnCancelListener(new DialogInterface.OnCancelListener() { @Override - @SuppressWarnings("synthetic-access") public void onCancel(DialogInterface dialog) { //Show the menu again ActionsDialog.this.mDialog.show(); @@ -241,7 +243,6 @@ public class ActionsDialog implements OnItemClickListener, OnItemLongClickListen }); inputNameDialog.setOnDismissListener(new DialogInterface.OnDismissListener() { @Override - @SuppressWarnings("synthetic-access") public void onDismiss(DialogInterface dialog) { //Retrieve the name an execute the action try { @@ -274,8 +275,9 @@ public class ActionsDialog implements OnItemClickListener, OnItemLongClickListen * * @param menuId The menu identifier (need to determine the fso type) * @param name The name of the file system object + * @hide */ - private void createNewFileSystemObject(final int menuId, final String name) { + void createNewFileSystemObject(final int menuId, final String name) { switch (menuId) { case R.id.mnu_actions_new_directory: ActionsPolicy.createNewDirectory( diff --git a/src/com/cyanogenmod/explorer/ui/dialogs/FilesystemInfoDialog.java b/src/com/cyanogenmod/explorer/ui/dialogs/FilesystemInfoDialog.java index 04576dd8..aa5dfc49 100644 --- a/src/com/cyanogenmod/explorer/ui/dialogs/FilesystemInfoDialog.java +++ b/src/com/cyanogenmod/explorer/ui/dialogs/FilesystemInfoDialog.java @@ -61,7 +61,10 @@ public class FilesystemInfoDialog implements OnClickListener { private static final String TAG = "FilesystemInfoDialog"; //$NON-NLS-1$ private final MountPoint mMountPoint; - private final DiskUsage mDiskUsage; + /** + * @hide + */ + final DiskUsage mDiskUsage; private final Context mContext; private final AlertDialog mDialog; @@ -70,7 +73,10 @@ public class FilesystemInfoDialog implements OnClickListener { private View mInfoView; private View mDiskUsageView; private Switch mSwStatus; - private DiskUsageGraph mDiskUsageGraph; + /** + * @hide + */ + DiskUsageGraph mDiskUsageGraph; private TextView mInfoMsgView; private OnMountListener mOnMountListener; @@ -245,7 +251,6 @@ public class FilesystemInfoDialog implements OnClickListener { } this.mDiskUsageGraph.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { //Animate disk usage graph FilesystemInfoDialog.this.mDiskUsageGraph.drawDiskUsage( diff --git a/src/com/cyanogenmod/explorer/ui/dialogs/FsoPropertiesDialog.java b/src/com/cyanogenmod/explorer/ui/dialogs/FsoPropertiesDialog.java index 1b8522a1..fe596a64 100644 --- a/src/com/cyanogenmod/explorer/ui/dialogs/FsoPropertiesDialog.java +++ b/src/com/cyanogenmod/explorer/ui/dialogs/FsoPropertiesDialog.java @@ -79,24 +79,42 @@ public class FsoPropertiesDialog private static final String AID_FORMAT = "%05d - %s"; //$NON-NLS-1$ private static final String AID_SEPARATOR = " - "; //$NON-NLS-1$ - private final FileSystemObject mFso; + /** + * @hide + */ + final FileSystemObject mFso; private boolean mHasChanged; - private final Context mContext; + /** + * @hide + */ + final Context mContext; private final AlertDialog mDialog; private final View mContentView; private View mInfoViewTab; private View mPermissionsViewTab; private View mInfoView; private View mPermissionsView; - private Spinner mSpnOwner; - private Spinner mSpnGroup; + /** + * @hide + */ + Spinner mSpnOwner; + /** + * @hide + */ + Spinner mSpnGroup; private CheckBox[] mChkUserPermission; private CheckBox[] mChkGroupPermission; private CheckBox[] mChkOthersPermission; private TextView mInfoMsgView; - private TextView mTvSize; - private TextView mTvContains; + /** + * @hide + */ + TextView mTvSize; + /** + * @hide + */ + TextView mTvContains; private boolean mIgnoreCheckEvents; private boolean mHasPrivileged; @@ -104,7 +122,10 @@ public class FsoPropertiesDialog private final boolean mComputeFolderStatistics; private AsyncResultExecutable mFolderUsageExecutable; private FolderUsage mFolderUsage; - private boolean mDrawingFolderUsage; + /** + * @hide + */ + boolean mDrawingFolderUsage; private DialogInterface.OnDismissListener mOnDismissListener; @@ -282,13 +303,11 @@ public class FsoPropertiesDialog AsyncTask<Void, Void, SparseArray<AID>> aidsTask = new AsyncTask<Void, Void, SparseArray<AID>>() { @Override - @SuppressWarnings("synthetic-access") protected SparseArray<AID> doInBackground(Void...params) { return AIDHelper.getAIDs(FsoPropertiesDialog.this.mContext); } @Override - @SuppressWarnings("synthetic-access") protected void onPostExecute(SparseArray<AID> aids) { if (!isCancelled()) { // Ensure that at least one AID was loaded @@ -486,14 +505,12 @@ public class FsoPropertiesDialog ExceptionUtil.translateException( this.mContext, ex, true, true, new ExceptionUtil.OnRelaunchCommandResult() { @Override - @SuppressWarnings("synthetic-access") public void onSuccess() { // Hide the message setMsg(null); } @Override - @SuppressWarnings("synthetic-access") public void onCancelled() { // Update the permissions with the previous information updatePermissions(); @@ -501,7 +518,6 @@ public class FsoPropertiesDialog } @Override - @SuppressWarnings("synthetic-access") public void onFailed() { // Show the warning message setMsg(FsoPropertiesDialog.this.mContext.getString( @@ -592,14 +608,12 @@ public class FsoPropertiesDialog ExceptionUtil.translateException( this.mContext, ex, true, true, new ExceptionUtil.OnRelaunchCommandResult() { @Override - @SuppressWarnings("synthetic-access") public void onSuccess() { // Hide the message setMsg(null); } @Override - @SuppressWarnings("synthetic-access") public void onCancelled() { // Update the information of owner and group updateSpinnerFromAid( @@ -612,7 +626,6 @@ public class FsoPropertiesDialog } @Override - @SuppressWarnings("synthetic-access") public void onFailed() { setMsg(txtMsg); @@ -642,8 +655,9 @@ public class FsoPropertiesDialog * @param ctx The current context * @param spinner The spinner * @param msg The message + * @hide */ - private static void setSpinnerMsg(Context ctx, Spinner spinner, String msg) { + static void setSpinnerMsg(Context ctx, Spinner spinner, String msg) { ArrayAdapter<String> loadingAdapter = new ArrayAdapter<String>( ctx, R.layout.spinner_item, new String[]{msg}); @@ -659,8 +673,9 @@ public class FsoPropertiesDialog * @param spinner The spinner * @param data The data * @param selection The object to select + * @hide */ - private void setSpinnerData( + void setSpinnerData( Context ctx, Spinner spinner, String[] data, int selection) { ArrayAdapter<String> adapter = new ArrayAdapter<String>( @@ -688,8 +703,9 @@ public class FsoPropertiesDialog /** * Method that refresh the information of permissions + * @hide */ - private void updatePermissions() { + void updatePermissions() { // Update the permissions with the previous information FsoPropertiesDialog.this.mIgnoreCheckEvents = true; try { @@ -846,8 +862,9 @@ public class FsoPropertiesDialog * the view is hidden * * @param msg The message to show. {@link null} to hide the dialog + * @hide */ - private void setMsg(String msg) { + void setMsg(String msg) { this.mInfoMsgView.setText(msg); this.mInfoMsgView.setVisibility( this.mHasPrivileged && msg == null ? View.GONE : View.VISIBLE); @@ -955,7 +972,6 @@ public class FsoPropertiesDialog // Update the dialog ((Activity)this.mContext).runOnUiThread(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { if (computing) { FsoPropertiesDialog.this.mTvSize.setText( diff --git a/src/com/cyanogenmod/explorer/ui/dialogs/InitialDirectoryDialog.java b/src/com/cyanogenmod/explorer/ui/dialogs/InitialDirectoryDialog.java index 9306169a..54c854ee 100644 --- a/src/com/cyanogenmod/explorer/ui/dialogs/InitialDirectoryDialog.java +++ b/src/com/cyanogenmod/explorer/ui/dialogs/InitialDirectoryDialog.java @@ -54,7 +54,10 @@ public class InitialDirectoryDialog implements DialogInterface.OnClickListener { private static final String TAG = "InitialDirectoryDialog"; //$NON-NLS-1$ private final Context mContext; - private final AlertDialog mDialog; + /** + * @hide + */ + final AlertDialog mDialog; private final DirectoryInlineAutocompleteTextView mAutocomplete; private OnValueChangedListener mOnValueChangedListener; @@ -85,7 +88,6 @@ public class InitialDirectoryDialog implements DialogInterface.OnClickListener { this.mAutocomplete.setOnValidationListener( new DirectoryInlineAutocompleteTextView.OnValidationListener() { @Override - @SuppressWarnings("synthetic-access") public void onVoidValue() { msgView.setVisibility(View.GONE); //The first invocation is valid. Can be ignore safely @@ -95,7 +97,6 @@ public class InitialDirectoryDialog implements DialogInterface.OnClickListener { } } @Override - @SuppressWarnings("synthetic-access") public void onValidValue() { msgView.setVisibility(View.GONE); //The first invocation is valid. Can be ignore safely @@ -105,7 +106,6 @@ public class InitialDirectoryDialog implements DialogInterface.OnClickListener { } } @Override - @SuppressWarnings("synthetic-access") public void onInvalidValue() { msgView.setVisibility(View.VISIBLE); //The first invocation is valid. Can be ignore safely diff --git a/src/com/cyanogenmod/explorer/ui/dialogs/InputNameDialog.java b/src/com/cyanogenmod/explorer/ui/dialogs/InputNameDialog.java index aadef61d..13b7268a 100644 --- a/src/com/cyanogenmod/explorer/ui/dialogs/InputNameDialog.java +++ b/src/com/cyanogenmod/explorer/ui/dialogs/InputNameDialog.java @@ -43,12 +43,18 @@ public class InputNameDialog private final Context mContext; private final AlertDialog mDialog; private final TextView mMsg; - private final EditText mEditText; + /** + * @hide + */ + final EditText mEditText; private final List<FileSystemObject> mFiles; private DialogInterface.OnCancelListener mOnCancelListener; private DialogInterface.OnDismissListener mOnDismissListener; - private boolean mCancelled; + /** + * @hide + */ + boolean mCancelled; /** * Constructor of <code>InputNameDialog</code>. @@ -91,14 +97,12 @@ public class InputNameDialog context.getString(android.R.string.ok), new DialogInterface.OnClickListener() { @Override - @SuppressWarnings("synthetic-access") public void onClick(DialogInterface dialog, int which) { InputNameDialog.this.mCancelled = false; } }); this.mDialog.setOnShowListener(new DialogInterface.OnShowListener() { @Override - @SuppressWarnings("synthetic-access") public void onShow(DialogInterface dialog) { InputMethodManager mgr = (InputMethodManager)context.getSystemService(Context.INPUT_METHOD_SERVICE); diff --git a/src/com/cyanogenmod/explorer/ui/dialogs/MessageProgressDialog.java b/src/com/cyanogenmod/explorer/ui/dialogs/MessageProgressDialog.java index d9494cd5..145b1535 100644 --- a/src/com/cyanogenmod/explorer/ui/dialogs/MessageProgressDialog.java +++ b/src/com/cyanogenmod/explorer/ui/dialogs/MessageProgressDialog.java @@ -45,11 +45,17 @@ public class MessageProgressDialog implements DialogInterface.OnClickListener { boolean onCancel(); } - private final Context mContext; + /** + * @hide + */ + final Context mContext; private final AlertDialog mDialog; private final TextView mProgress; private final int mProgressResourceId; - private OnCancelListener mOnCancelListener; + /** + * @hide + */ + OnCancelListener mOnCancelListener; /** * Constructor of <code>MessageProgressDialog</code>. @@ -108,7 +114,6 @@ public class MessageProgressDialog implements DialogInterface.OnClickListener { DialogInterface.BUTTON_NEUTRAL, context.getString(android.R.string.cancel), this); this.mDialog.setOnCancelListener(new DialogInterface.OnCancelListener() { @Override - @SuppressWarnings("synthetic-access") public void onCancel(DialogInterface dialog) { if (MessageProgressDialog.this.mOnCancelListener != null) { if (!MessageProgressDialog.this.mOnCancelListener.onCancel()) { diff --git a/src/com/cyanogenmod/explorer/ui/policy/ActionsPolicy.java b/src/com/cyanogenmod/explorer/ui/policy/ActionsPolicy.java index 11e2e8af..ba509e39 100644 --- a/src/com/cyanogenmod/explorer/ui/policy/ActionsPolicy.java +++ b/src/com/cyanogenmod/explorer/ui/policy/ActionsPolicy.java @@ -63,6 +63,8 @@ public final class ActionsPolicy { */ FileSystemObject mFso; + RemoveItemListenter() {/**NON BLOCK**/} + @Override public void onSuccess() { //Operation complete. Refresh @@ -357,7 +359,6 @@ public final class ActionsPolicy { ctx, msg, new DialogInterface.OnClickListener() { @Override - @SuppressWarnings("synthetic-access") public void onClick(DialogInterface alertDialog, int which) { if (which == DialogInterface.BUTTON_POSITIVE) { try { diff --git a/src/com/cyanogenmod/explorer/ui/widgets/BreadcrumbView.java b/src/com/cyanogenmod/explorer/ui/widgets/BreadcrumbView.java index a7ff5bc4..7cea04fc 100644 --- a/src/com/cyanogenmod/explorer/ui/widgets/BreadcrumbView.java +++ b/src/com/cyanogenmod/explorer/ui/widgets/BreadcrumbView.java @@ -43,11 +43,23 @@ import java.util.List; */ public class BreadcrumbView extends RelativeLayout implements Breadcrumb, OnClickListener { - private HorizontalScrollView mScrollView; + /** + * @hide + */ + HorizontalScrollView mScrollView; private ViewGroup mBreadcrumbBar; - private ImageView mFilesystemInfo; - private ProgressBar mDiskUsageInfo; - private View mLoading; + /** + * @hide + */ + ImageView mFilesystemInfo; + /** + * @hide + */ + ProgressBar mDiskUsageInfo; + /** + * @hide + */ + View mLoading; private FilesystemAsyncTask mFilesystemAsyncTask; private int mFreeDiskSpaceWarningLevel = 95; @@ -144,7 +156,6 @@ public class BreadcrumbView extends RelativeLayout implements Breadcrumb, OnClic //Show/Hide views this.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { BreadcrumbView.this.mFilesystemInfo.setVisibility(View.INVISIBLE); BreadcrumbView.this.mDiskUsageInfo.setVisibility(View.INVISIBLE); @@ -161,7 +172,6 @@ public class BreadcrumbView extends RelativeLayout implements Breadcrumb, OnClic //Show/Hide views this.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { BreadcrumbView.this.mLoading.setVisibility(View.INVISIBLE); BreadcrumbView.this.mFilesystemInfo.setVisibility(View.VISIBLE); @@ -197,7 +207,6 @@ public class BreadcrumbView extends RelativeLayout implements Breadcrumb, OnClic //Set scrollbar at the end this.mScrollView.post(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { BreadcrumbView.this.mScrollView.fullScroll(View.FOCUS_RIGHT); } diff --git a/src/com/cyanogenmod/explorer/ui/widgets/DiskUsageGraph.java b/src/com/cyanogenmod/explorer/ui/widgets/DiskUsageGraph.java index 56f34064..5cd1204a 100644 --- a/src/com/cyanogenmod/explorer/ui/widgets/DiskUsageGraph.java +++ b/src/com/cyanogenmod/explorer/ui/widgets/DiskUsageGraph.java @@ -40,10 +40,16 @@ public class DiskUsageGraph extends View { private static int sColorFilterNormal; private static int sColorFilterWarning; - private int mDiskWarningAngle = (360 * 95) / 100; + /** + * @hide + */ + int mDiskWarningAngle = (360 * 95) / 100; private AnimationDrawingThread mThread; - private final List<DrawingObject> mDrawingObjects = + /** + * @hide + */ + final List<DrawingObject> mDrawingObjects = Collections.synchronizedList(new ArrayList<DiskUsageGraph.DrawingObject>(2)); /** @@ -161,7 +167,7 @@ public class DiskUsageGraph extends View { * {@inheritDoc} */ @Override - @SuppressWarnings({ "synthetic-access", "null" }) + @SuppressWarnings("null") public void run() { //Get information about the drawing zone, and adjust the size Rect rect = new Rect(); @@ -279,7 +285,6 @@ public class DiskUsageGraph extends View { * @param stroke The stroke width * @return DrawingObject The drawing object */ - @SuppressWarnings("synthetic-access") private DrawingObject createDrawingObject(Rect rect, int colorResourceId, int stroke) { DrawingObject out = new DrawingObject(); out.mSweepAngle = 0; @@ -297,6 +302,7 @@ public class DiskUsageGraph extends View { * A class with information about a drawing object. */ private class DrawingObject { + DrawingObject() {/**NON BLOCK**/} int mStartAngle = -180; int mSweepAngle = 0; Paint mPaint = new Paint(Paint.ANTI_ALIAS_FLAG); diff --git a/src/com/cyanogenmod/explorer/ui/widgets/InlineAutocompleteTextView.java b/src/com/cyanogenmod/explorer/ui/widgets/InlineAutocompleteTextView.java index 47e8e0b8..45a3d4d8 100644 --- a/src/com/cyanogenmod/explorer/ui/widgets/InlineAutocompleteTextView.java +++ b/src/com/cyanogenmod/explorer/ui/widgets/InlineAutocompleteTextView.java @@ -110,7 +110,6 @@ public class InlineAutocompleteTextView extends RelativeLayout * Method that initializes the view. This method loads all the necessary * information and create an appropriate layout for the view */ - @SuppressWarnings("synthetic-access") private void init() { //Initialize data this.mData = new ArrayList<String>(); @@ -297,7 +296,13 @@ public class InlineAutocompleteTextView extends RelativeLayout return false; } - private void onTextChanged(String value) { + /** + * Method that need to be invoked when a string was changed + * + * @param value The new string + * @hide + */ + void onTextChanged(String value) { this.mFilter = 0; if (this.mOnTextChangedListener != null) { //Communicate the change @@ -337,8 +342,9 @@ public class InlineAutocompleteTextView extends RelativeLayout /** * Method invoked when a tab key event is requested (button or keyboard) + * @hide */ - private void doTab() { + void doTab() { //Complete with current text String current = this.mForegroundText.getText().toString(); if (current.length() == 0) { @@ -386,8 +392,9 @@ public class InlineAutocompleteTextView extends RelativeLayout * Method invoked when a enter key event is requested (button or keyboard) * * @param fromEditorAction It this method was invoked from editor action + * @hide */ - private void doDone(boolean fromEditorAction) { + void doDone(boolean fromEditorAction) { if (fromEditorAction) { // Hide the soft keyboard Configuration config = getContext().getResources().getConfiguration(); @@ -410,6 +417,8 @@ public class InlineAutocompleteTextView extends RelativeLayout private int mStart; private int mCount; + public FilteredTextWatcher() {/**NON BLOCK**/} + /** * {@inheritDoc} */ @@ -431,7 +440,6 @@ public class InlineAutocompleteTextView extends RelativeLayout * {@inheritDoc} */ @Override - @SuppressWarnings("synthetic-access") public void afterTextChanged(Editable s) { // Enter and Tab are not allowed, and have their own treatment final String orig = s.toString(); diff --git a/src/com/cyanogenmod/explorer/ui/widgets/NavigationView.java b/src/com/cyanogenmod/explorer/ui/widgets/NavigationView.java index d0ea4b78..b447c254 100644 --- a/src/com/cyanogenmod/explorer/ui/widgets/NavigationView.java +++ b/src/com/cyanogenmod/explorer/ui/widgets/NavigationView.java @@ -97,7 +97,10 @@ public class NavigationView extends RelativeLayout implements private int mId; private String mCurrentDir; private NavigationLayoutMode mCurrentMode; - private List<FileSystemObject> mFiles; + /** + * @hide + */ + List<FileSystemObject> mFiles; private FileSystemObjectAdapter mAdapter; private DefaultLongClickAction mDefaultLongClickAction; @@ -107,10 +110,18 @@ public class NavigationView extends RelativeLayout implements private OnNavigationSelectionChangedListener mOnNavigationSelectionChangedListener; private OnNavigationRequestMenuListener mOnNavigationRequestMenuListener; - - private Breadcrumb mBreadcrumb; - private NavigationCustomTitleView mTitle; - private AdapterView<?> mAdapterView; + /** + * @hide + */ + Breadcrumb mBreadcrumb; + /** + * @hide + */ + NavigationCustomTitleView mTitle; + /** + * @hide + */ + AdapterView<?> mAdapterView; //The layout for icons mode private static final int RESOURCE_MODE_ICONS_LAYOUT = R.layout.navigation_view_icons; @@ -521,7 +532,6 @@ public class NavigationView extends RelativeLayout implements * {@inheritDoc} */ @Override - @SuppressWarnings("synthetic-access") protected List<FileSystemObject> doInBackground(String... params) { try { //Reset the custom title view and returns to breadcrumb @@ -592,7 +602,6 @@ public class NavigationView extends RelativeLayout implements * {@inheritDoc} */ @Override - @SuppressWarnings("synthetic-access") protected void onPostExecute(List<FileSystemObject> files) { onPostExecuteTask( files, addToHistory, isNewHistory, @@ -614,8 +623,9 @@ public class NavigationView extends RelativeLayout implements * @param searchInfo The search information (if calling activity is {@link "SearchActivity"}) * @param newDir The new directory * @param scrollTo If not null, then listview must scroll to this item + * @hide */ - private void onPostExecuteTask( + void onPostExecuteTask( List<FileSystemObject> files, boolean addToHistory, boolean isNewHistory, boolean hasChanged, SearchInfoParcelable searchInfo, String newDir, final FileSystemObject scrollTo) { diff --git a/src/com/cyanogenmod/explorer/ui/widgets/SelectionView.java b/src/com/cyanogenmod/explorer/ui/widgets/SelectionView.java index e0801041..4401fc4a 100644 --- a/src/com/cyanogenmod/explorer/ui/widgets/SelectionView.java +++ b/src/com/cyanogenmod/explorer/ui/widgets/SelectionView.java @@ -38,7 +38,10 @@ import java.util.List; */ public class SelectionView extends LinearLayout { - private int mViewHeight; + /** + * @hide + */ + int mViewHeight; private TextView mStatus; private int mEffectDuration; @@ -82,7 +85,6 @@ public class SelectionView extends LinearLayout { getViewTreeObserver().addOnGlobalLayoutListener( new ViewTreeObserver.OnGlobalLayoutListener() { @Override - @SuppressWarnings("synthetic-access") public void onGlobalLayout() { SelectionView.this.mViewHeight = getHeight(); getViewTreeObserver().removeOnGlobalLayoutListener(this); @@ -185,7 +187,6 @@ public class SelectionView extends LinearLayout { effect); animation.setAnimationListener(new Animation.AnimationListener() { @Override - @SuppressWarnings("synthetic-access") public void onAnimationStart(Animation anim) { LayoutParams params = (LayoutParams)getLayoutParams(); if (effect.compareTo(ExpandCollapseAnimation.ANIMATION_TYPE.EXPAND) == 0) { @@ -200,7 +201,6 @@ public class SelectionView extends LinearLayout { public void onAnimationRepeat(Animation anim) {/**NON BLOCK**/} @Override - @SuppressWarnings("synthetic-access") public void onAnimationEnd(Animation anim) { LayoutParams params = (LayoutParams)getLayoutParams(); if (effect.compareTo(ExpandCollapseAnimation.ANIMATION_TYPE.COLLAPSE) == 0) { diff --git a/src/com/cyanogenmod/explorer/util/ExceptionUtil.java b/src/com/cyanogenmod/explorer/util/ExceptionUtil.java index 6031eddc..55553eec 100644 --- a/src/com/cyanogenmod/explorer/util/ExceptionUtil.java +++ b/src/com/cyanogenmod/explorer/util/ExceptionUtil.java @@ -191,7 +191,6 @@ public final class ExceptionUtil { if (ex instanceof RelaunchableException && askUser) { ((Activity)context).runOnUiThread(new Runnable() { @Override - @SuppressWarnings("synthetic-access") public void run() { askUser(context, (RelaunchableException)ex, quiet, listener); } @@ -225,8 +224,9 @@ public final class ExceptionUtil { * @param context The current context * @param relaunchable The exception that contains the command that must be re-executed. * @param listener The listener where return the relaunch result + * @hide */ - private static void askUser( + static void askUser( final Context context, final RelaunchableException relaunchable, final boolean quiet, @@ -263,7 +263,6 @@ public final class ExceptionUtil { relaunchable.getQuestionResourceId(), new DialogInterface.OnClickListener() { @Override - @SuppressWarnings("synthetic-access") public void onClick(DialogInterface dialog, int which) { if (which == DialogInterface.BUTTON_POSITIVE) { //Run the executable again @@ -318,8 +317,9 @@ public final class ExceptionUtil { * * @param context The current context * @param relaunchable The {@link RelaunchableException} reference + * @hide */ - private static void prepare(final Context context, final RelaunchableException relaunchable) { + static void prepare(final Context context, final RelaunchableException relaunchable) { //- This exception need change the console before re-execute if (relaunchable instanceof InsufficientPermissionsException) { ConsoleBuilder.changeToPrivilegedConsole(context); diff --git a/src/com/cyanogenmod/explorer/util/MimeTypeHelper.java b/src/com/cyanogenmod/explorer/util/MimeTypeHelper.java index 958037fd..31b3e421 100644 --- a/src/com/cyanogenmod/explorer/util/MimeTypeHelper.java +++ b/src/com/cyanogenmod/explorer/util/MimeTypeHelper.java @@ -118,6 +118,7 @@ public final class MimeTypeHelper { * An internal class for holding the mime/type database structure */ private static class MimeTypeInfo { + MimeTypeInfo() {/**NON BLOCK**/} public MimeTypeCategory mCategory; public String mMimeType; public String mDrawable; @@ -305,7 +306,6 @@ public final class MimeTypeHelper { * @param context The current context */ //IMP! This must be invoked from the main activity creation - @SuppressWarnings("synthetic-access") public static synchronized void loadMimeTypes(Context context) { if (sMimeTypes == null) { try { diff --git a/tests/src/com/cyanogenmod/explorer/commands/shell/FindCommandTest.java b/tests/src/com/cyanogenmod/explorer/commands/shell/FindCommandTest.java index 664e141d..e382292e 100644 --- a/tests/src/com/cyanogenmod/explorer/commands/shell/FindCommandTest.java +++ b/tests/src/com/cyanogenmod/explorer/commands/shell/FindCommandTest.java @@ -34,8 +34,14 @@ public class FindCommandTest extends AbstractConsoleTest { private static final String FIND_PATH = "/"; //$NON-NLS-1$ private static final String FIND_TERM_PARTIAL = "xml"; //$NON-NLS-1$ - private final Object mSync = new Object(); - private boolean mNewPartialData; + /** + * @hide + */ + final Object mSync = new Object(); + /** + * @hide + */ + boolean mNewPartialData; /** * {@inheritDoc} @@ -50,7 +56,6 @@ public class FindCommandTest extends AbstractConsoleTest { * * @throws Exception If test failed */ - @SuppressWarnings("synthetic-access") public void testFindWithPartialResult() throws Exception { this.mNewPartialData = false; Query query = new Query().setSlot(FIND_TERM_PARTIAL, 0); diff --git a/tests/src/com/cyanogenmod/explorer/commands/shell/FolderUsageCommandTest.java b/tests/src/com/cyanogenmod/explorer/commands/shell/FolderUsageCommandTest.java index 29b43546..a41617c2 100644 --- a/tests/src/com/cyanogenmod/explorer/commands/shell/FolderUsageCommandTest.java +++ b/tests/src/com/cyanogenmod/explorer/commands/shell/FolderUsageCommandTest.java @@ -34,9 +34,18 @@ public class FolderUsageCommandTest extends AbstractConsoleTest { private static final String PATH = "/system"; //$NON-NLS-1$ - private final Object mSync = new Object(); - private boolean mNewPartialData; - private FolderUsage mUsage; + /** + * @hide + */ + final Object mSync = new Object(); + /** + * @hide + */ + boolean mNewPartialData; + /** + * @hide + */ + FolderUsage mUsage; /** * {@inheritDoc} @@ -51,7 +60,6 @@ public class FolderUsageCommandTest extends AbstractConsoleTest { * * @throws Exception If test failed */ - @SuppressWarnings("synthetic-access") public void testFolderUsageWithPartialResult() throws Exception { this.mNewPartialData = false; this.mUsage = null; |