summaryrefslogtreecommitdiffstats
path: root/sdm
diff options
context:
space:
mode:
authorPullakavi Srinivas <spullaka@codeaurora.org>2018-03-07 15:15:14 +0530
committerGurpreet Singh Dhami <gdhami@codeaurora.org>2018-05-08 18:06:56 -0400
commit648ef743024c5ed1a5787a7bf9a2ee6cad9e659e (patch)
tree06b6d84a4d193b426b9f46c1f04483392a415ba1 /sdm
parent670b4e577ca2984196c3ba6198ec2f70340bab6b (diff)
downloadandroid_hardware_qcom_sdm710_display-648ef743024c5ed1a5787a7bf9a2ee6cad9e659e.tar.gz
android_hardware_qcom_sdm710_display-648ef743024c5ed1a5787a7bf9a2ee6cad9e659e.tar.bz2
android_hardware_qcom_sdm710_display-648ef743024c5ed1a5787a7bf9a2ee6cad9e659e.zip
hwc2: Avoid overwriting metadata refresh rate.
-- Compute sanitized metadata refresh rate. -- Populate display's operating refresh rate to all the layers that donot support metadata refresh rate. Change-Id: Iaf17e4e10da543e110fcf6ba7648d60807069f98
Diffstat (limited to 'sdm')
-rw-r--r--sdm/libs/hwc2/hwc_display.cpp16
-rw-r--r--sdm/libs/hwc2/hwc_display.h1
-rw-r--r--sdm/libs/hwc2/hwc_layers.cpp1
-rw-r--r--sdm/libs/hwc2/hwc_layers.h2
4 files changed, 17 insertions, 3 deletions
diff --git a/sdm/libs/hwc2/hwc_display.cpp b/sdm/libs/hwc2/hwc_display.cpp
index 28a2a5ef..8888f114 100644
--- a/sdm/libs/hwc2/hwc_display.cpp
+++ b/sdm/libs/hwc2/hwc_display.cpp
@@ -596,11 +596,10 @@ void HWCDisplay::BuildLayerStack() {
layer->src_rect.bottom = layer_buffer->height;
}
- if (layer->frame_rate > metadata_refresh_rate_) {
+ if (hwc_layer->HasMetaDataRefreshRate() && layer->frame_rate > metadata_refresh_rate_) {
metadata_refresh_rate_ = SanitizeRefreshRate(layer->frame_rate);
- } else {
- layer->frame_rate = current_refresh_rate_;
}
+
display_rect_ = Union(display_rect_, layer->dst_rect);
geometry_changes_ |= hwc_layer->GetGeometryChanges();
@@ -1054,6 +1053,7 @@ HWC2::Error HWCDisplay::PrepareLayerStack(uint32_t *out_num_types, uint32_t *out
return HWC2::Error::BadDisplay;
}
+ UpdateRefreshRate();
if (!skip_prepare_) {
DisplayError error = display_intf_->Prepare(&layer_stack_);
if (error != kErrorNone) {
@@ -2145,4 +2145,14 @@ HWC2::Error HWCDisplay::GetValidateDisplayOutput(uint32_t *out_num_types,
return ((*out_num_types > 0) ? HWC2::Error::HasChanges : HWC2::Error::None);
}
+void HWCDisplay::UpdateRefreshRate() {
+ for (auto hwc_layer : layer_set_) {
+ if (hwc_layer->HasMetaDataRefreshRate()) {
+ continue;
+ }
+ auto layer = hwc_layer->GetSDMLayer();
+ layer->frame_rate = current_refresh_rate_;
+ }
+}
+
} // namespace sdm
diff --git a/sdm/libs/hwc2/hwc_display.h b/sdm/libs/hwc2/hwc_display.h
index d2620efb..86d9462f 100644
--- a/sdm/libs/hwc2/hwc_display.h
+++ b/sdm/libs/hwc2/hwc_display.h
@@ -328,6 +328,7 @@ class HWCDisplay : public DisplayEventHandler {
private:
void DumpInputBuffers(void);
+ void UpdateRefreshRate();
qService::QService *qservice_ = NULL;
DisplayClass display_class_;
uint32_t geometry_changes_ = GeometryChanges::kNone;
diff --git a/sdm/libs/hwc2/hwc_layers.cpp b/sdm/libs/hwc2/hwc_layers.cpp
index 4250335e..aa4fb063 100644
--- a/sdm/libs/hwc2/hwc_layers.cpp
+++ b/sdm/libs/hwc2/hwc_layers.cpp
@@ -735,6 +735,7 @@ DisplayError HWCLayer::SetMetaData(const private_handle_t *pvt_handle, Layer *la
uint32_t frame_rate = layer->frame_rate;
if (getMetaData(handle, GET_REFRESH_RATE, &fps) == 0) {
frame_rate = (fps != 0) ? RoundToStandardFPS(fps) : layer->frame_rate;
+ has_metadata_refresh_rate_ = true;
}
int32_t interlaced = 0;
diff --git a/sdm/libs/hwc2/hwc_layers.h b/sdm/libs/hwc2/hwc_layers.h
index 92267445..41ec6ede 100644
--- a/sdm/libs/hwc2/hwc_layers.h
+++ b/sdm/libs/hwc2/hwc_layers.h
@@ -99,6 +99,7 @@ class HWCLayer {
bool IsScalingPresent();
bool IsRotationPresent();
bool IsNonIntegralSourceCrop() { return non_integral_source_crop_; }
+ bool HasMetaDataRefreshRate() { return has_metadata_refresh_rate_; }
private:
Layer *layer_ = nullptr;
@@ -115,6 +116,7 @@ class HWCLayer {
bool single_buffer_ = false;
int buffer_fd_ = -1;
bool non_integral_source_crop_ = false;
+ bool has_metadata_refresh_rate_ = false;
// Composition requested by client(SF)
HWC2::Composition client_requested_ = HWC2::Composition::Device;