diff options
| author | Stephen Hines <srhines@google.com> | 2018-09-06 09:04:07 -0700 |
|---|---|---|
| committer | Michael Bestas <mkbestas@lineageos.org> | 2019-02-26 14:44:09 +0100 |
| commit | 125f38c753284ee15f6258782b41fcaffa41f42c (patch) | |
| tree | 06d24c04ce4be3f7fc50dd2a5f73933418f940d0 /CleanSpec.mk | |
| parent | 9a441ee9c4c23862febce735c215a6a9efd9cbe3 (diff) | |
| download | android_hardware_qcom_media-lineage-16.0-caf-8998.tar.gz android_hardware_qcom_media-lineage-16.0-caf-8998.tar.bz2 android_hardware_qcom_media-lineage-16.0-caf-8998.zip | |
Fix invalid logical constant creation.lineage-16.0-caf-8998
This code incorrectly uses || to combine a bunch of state constants. The
next Clang warns on this buggy pattern.
hardware/qcom/media/msm8996/mm-video-v4l2/vidc/venc/src/omx_video_base.cpp:1130:40:
error: use of logical '||' with constant operand
[-Werror,-Wconstant-logical-operand]
if (eState == (OMX_StateLoaded || OMX_StateWaitForResources
^ ~~~~~~~~~~~~~~~~~~~~~~~~~
hardware/qcom/media/msm8996/mm-video-v4l2/vidc/venc/src/omx_video_base.cpp:1130:40:
note: use '|' for a bitwise operation
if (eState == (OMX_StateLoaded || OMX_StateWaitForResources
^~
|
Bug: http://b/110779387
Test: ./test_compiler.py --build-only --target aosp_sailfish-eng --no-clean-built-target ../../ --clang-path ../../prebuilts/clang/host/linux-x86/llvm-toolchain-dev/
Change-Id: I7332508f0f9827c7968a4680fe42eedffb3714e7
Signed-off-by: D. Andrei Măceș <andrei@unlegacy-android.org>
Diffstat (limited to 'CleanSpec.mk')
0 files changed, 0 insertions, 0 deletions