summaryrefslogtreecommitdiffstats
path: root/post_proc
diff options
context:
space:
mode:
authorAndy Hung <hunga@google.com>2015-09-08 17:31:36 -0700
committerAndy Hung <hunga@google.com>2015-09-08 17:31:36 -0700
commit591ef60fb95d863cb8f3a3923d59bc36c8cd4b8c (patch)
treeb81e8271602e09b7d234a294d9dd2a72db384303 /post_proc
parent88e6fb26adb91de5c914713a820a2fe21048d1b5 (diff)
downloadandroid_hardware_qcom_audio-591ef60fb95d863cb8f3a3923d59bc36c8cd4b8c.tar.gz
android_hardware_qcom_audio-591ef60fb95d863cb8f3a3923d59bc36c8cd4b8c.tar.bz2
android_hardware_qcom_audio-591ef60fb95d863cb8f3a3923d59bc36c8cd4b8c.zip
volume_listener: fix release
use safe iteration of list when removing node. Bug: 23731264 Change-Id: I6d0c51638b6a3de684cf595833dc4d0fc7e8c8b5
Diffstat (limited to 'post_proc')
-rw-r--r--post_proc/volume_listener.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/post_proc/volume_listener.c b/post_proc/volume_listener.c
index 2759bea6..62acd6f5 100644
--- a/post_proc/volume_listener.c
+++ b/post_proc/volume_listener.c
@@ -664,7 +664,7 @@ static int vol_prc_lib_create(const effect_uuid_t *uuid,
static int vol_prc_lib_release(effect_handle_t handle)
{
- struct listnode *node = NULL;
+ struct listnode *node, *temp_node_next;
vol_listener_context_t *context = NULL;
vol_listener_context_t *recv_contex = (vol_listener_context_t *)handle;
int status = -1;
@@ -674,7 +674,7 @@ static int vol_prc_lib_release(effect_handle_t handle)
pthread_mutex_lock(&vol_listner_init_lock);
// check if the handle/context provided is valid
- list_for_each(node, &vol_effect_list) {
+ list_for_each_safe(node, temp_node_next, &vol_effect_list) {
context = node_to_item(node, struct vol_listener_context_s, effect_list_node);
if ((memcmp(&(context->desc->uuid), &(recv_contex->desc->uuid), sizeof(effect_uuid_t)) == 0)
&& (context->session_id == recv_contex->session_id)