diff options
| author | Steven Moreland <smoreland@google.com> | 2018-09-06 17:58:16 -0700 |
|---|---|---|
| committer | Steven Moreland <smoreland@google.com> | 2018-09-09 12:31:05 -0700 |
| commit | 146405b58a876d1bb50e0520409cff71f376cd84 (patch) | |
| tree | 634115c3ac27a87779e54901cc8b8f3e9d6acf9c /usb | |
| parent | 0a0fa7209e8079a20bbac432d2073be672ea5b31 (diff) | |
| download | android_hardware_interfaces-146405b58a876d1bb50e0520409cff71f376cd84.tar.gz android_hardware_interfaces-146405b58a876d1bb50e0520409cff71f376cd84.tar.bz2 android_hardware_interfaces-146405b58a876d1bb50e0520409cff71f376cd84.zip | |
Note confusion-causing breaks in HIDL convention.
These were either made at a time when the convention was not fully
formed or missed during review.
It is somewhat misleading since method overloading isn't supported
and method names need this kind of prefix, but nothing else does.
The reason for this is that everything is namespaced, but methods are
all in the same namespace. The reason method overloading is not supported
in HIDL is because the HIDL types may map to types that collide in the
target languages, and this would cause any sort of overloading rules
to require complicated machinery.
Bug: N/A
Test: hidl-gen -Lcheck android.hardware.usb@1.1 android.hardware.vibrator@1.1 && echo ":)"
:)
Change-Id: Iac23c9311925ed140ff1e15d1366829b078c8866
Diffstat (limited to 'usb')
| -rw-r--r-- | usb/1.1/types.hal | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/usb/1.1/types.hal b/usb/1.1/types.hal index 2261e09cf..c9cc29230 100644 --- a/usb/1.1/types.hal +++ b/usb/1.1/types.hal @@ -18,6 +18,8 @@ package android.hardware.usb@1.1; import android.hardware.usb@1.0; +// NOTE: suffix '_1_1' is for legacy ABI compatibility. It cannot be +// changed to 'PortMode' which the convention dictates. @export enum PortMode_1_1 : PortMode { /* @@ -37,6 +39,8 @@ enum PortMode_1_1 : PortMode { * Used as the container to report data back to the caller. * Represents the current connection status of a single USB port. */ +// NOTE: suffix '_1_1' is for legacy ABI compatibility. It cannot be +// changed to 'PortStatus' which the convention dictates. struct PortStatus_1_1 { /* * The supportedModes and the currentMode fields of the status |