diff options
author | Emilian Peev <epeev@google.com> | 2020-02-18 10:16:06 -0800 |
---|---|---|
committer | Emilian Peev <epeev@google.com> | 2020-02-18 10:20:02 -0800 |
commit | aa5673385a4aad41f6f4de961365cb741f6dc7a8 (patch) | |
tree | e608c935ca64ea9af4db3bcf8d41a81ac70bb14d | |
parent | 984b3069bc9b77ad400af47ba60f860e77f5638d (diff) | |
download | android_hardware_interfaces-aa5673385a4aad41f6f4de961365cb741f6dc7a8.tar.gz android_hardware_interfaces-aa5673385a4aad41f6f4de961365cb741f6dc7a8.tar.bz2 android_hardware_interfaces-aa5673385a4aad41f6f4de961365cb741f6dc7a8.zip |
Camera: Fix possible ExifUtils heap corruption
Both EXIF_TAG_IMAGE_WIDTH and EXIF_TAG_IMAGE_LENGTH
expect short values as per EXIF spec. Call appropriate
libexif function to avoid possible heap corruption.
Bug: 148223871
Test: Successful build
Change-Id: Ib16bf1ae8ab2093da529efe6ff0778331c3e9eb3
-rw-r--r-- | camera/common/1.0/default/Exif.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/camera/common/1.0/default/Exif.cpp b/camera/common/1.0/default/Exif.cpp index 6054999a0..b04c8084f 100644 --- a/camera/common/1.0/default/Exif.cpp +++ b/camera/common/1.0/default/Exif.cpp @@ -632,13 +632,13 @@ bool ExifUtilsImpl::setGpsTimestamp(const struct tm& t) { } bool ExifUtilsImpl::setImageHeight(uint32_t length) { - SET_LONG(EXIF_IFD_0, EXIF_TAG_IMAGE_LENGTH, length); + SET_SHORT(EXIF_IFD_0, EXIF_TAG_IMAGE_LENGTH, length); SET_LONG(EXIF_IFD_EXIF, EXIF_TAG_PIXEL_Y_DIMENSION, length); return true; } bool ExifUtilsImpl::setImageWidth(uint32_t width) { - SET_LONG(EXIF_IFD_0, EXIF_TAG_IMAGE_WIDTH, width); + SET_SHORT(EXIF_IFD_0, EXIF_TAG_IMAGE_WIDTH, width); SET_LONG(EXIF_IFD_EXIF, EXIF_TAG_PIXEL_X_DIMENSION, width); return true; } |