aboutsummaryrefslogtreecommitdiffstats
path: root/videocodec/securevideo
diff options
context:
space:
mode:
authorSuneel Kandru <suneel.kandru@intel.com>2014-03-27 11:31:42 -0700
committerPatrick Tjin <pattjin@google.com>2014-07-21 22:02:58 -0700
commit3ee0cc149c46154d3a5318d1c6cbe861d65c389d (patch)
tree3b2ced2eb04ea8c14b2b0e40e58e3e78c4e2f3a1 /videocodec/securevideo
parent354e38d88215e6d1c3c22bd15c8c7a1b1b0e029b (diff)
downloadandroid_hardware_intel_common_omx-components-3ee0cc149c46154d3a5318d1c6cbe861d65c389d.tar.gz
android_hardware_intel_common_omx-components-3ee0cc149c46154d3a5318d1c6cbe861d65c389d.tar.bz2
android_hardware_intel_common_omx-components-3ee0cc149c46154d3a5318d1c6cbe861d65c389d.zip
WIDEVINE: Increased the buffer size and fix the Klocwork issues
BZ: 182607 Increased the buffer size in OMX and liboemcrypto modules Fixed the klocwork issue by initializing the ret value Change-Id: I71f3087eda8f8cd0963adb7f33fa801f42d9c2ff Signed-off-by: Suneel Kandru <suneel.kandru@intel.com>
Diffstat (limited to 'videocodec/securevideo')
-rwxr-xr-xvideocodec/securevideo/merrifield/OMXVideoDecoderAVCSecure.cpp19
-rwxr-xr-xvideocodec/securevideo/merrifield/OMXVideoDecoderAVCSecure.h2
2 files changed, 12 insertions, 9 deletions
diff --git a/videocodec/securevideo/merrifield/OMXVideoDecoderAVCSecure.cpp b/videocodec/securevideo/merrifield/OMXVideoDecoderAVCSecure.cpp
index c391e42..e271b20 100755
--- a/videocodec/securevideo/merrifield/OMXVideoDecoderAVCSecure.cpp
+++ b/videocodec/securevideo/merrifield/OMXVideoDecoderAVCSecure.cpp
@@ -226,15 +226,10 @@ OMX_ERRORTYPE OMXVideoDecoderAVCSecure::PrepareConfigBuffer(VideoConfigBuffer *p
}
OMX_ERRORTYPE OMXVideoDecoderAVCSecure::PrepareClassicWVDecodeBuffer(OMX_BUFFERHEADERTYPE *buffer, buffer_retain_t *retain, VideoDecodeBuffer *p){
- OMX_ERRORTYPE ret;
- // OMX_BUFFERFLAG_CODECCONFIG is an optional flag
- // if flag is set, buffer will only contain codec data.
+ OMX_ERRORTYPE ret = OMX_ErrorNone;
+
- if (buffer->nFlags & OMX_BUFFERFLAG_CODECCONFIG) {
- LOGV("Received AVC codec data.");
- return ret;
- }
p->flag |= HAS_COMPLETE_FRAME;
if (buffer->nOffset != 0) {
@@ -333,8 +328,16 @@ OMX_ERRORTYPE OMXVideoDecoderAVCSecure::PrepareDecodeBuffer(OMX_BUFFERHEADERTYPE
}
DataBuffer *dataBuffer = (DataBuffer *)buffer->pBuffer;
- if(dataBuffer->drmScheme == DRM_SCHEME_WV_CLASSIC)
+ if(dataBuffer->drmScheme == DRM_SCHEME_WV_CLASSIC){
+
+ // OMX_BUFFERFLAG_CODECCONFIG is an optional flag
+ // if flag is set, buffer will only contain codec data.
+ if (buffer->nFlags & OMX_BUFFERFLAG_CODECCONFIG) {
+ LOGV("Received AVC codec data.");
+ return ret;
+ }
return PrepareClassicWVDecodeBuffer(buffer, retain, p);
+ }
else if(dataBuffer->drmScheme == DRM_SCHEME_WV_MODULAR)
return PrepareModularWVDecodeBuffer(buffer, retain, p);
return ret;
diff --git a/videocodec/securevideo/merrifield/OMXVideoDecoderAVCSecure.h b/videocodec/securevideo/merrifield/OMXVideoDecoderAVCSecure.h
index 0d8d028..497db0f 100755
--- a/videocodec/securevideo/merrifield/OMXVideoDecoderAVCSecure.h
+++ b/videocodec/securevideo/merrifield/OMXVideoDecoderAVCSecure.h
@@ -62,7 +62,7 @@ private:
// OMX_PARAM_PORTDEFINITIONTYPE
INPORT_MIN_BUFFER_COUNT = 1,
INPORT_ACTUAL_BUFFER_COUNT = 5,
- INPORT_BUFFER_SIZE = 1382400,
+ INPORT_BUFFER_SIZE = 1572864,
// for OMX_VIDEO_PARAM_INTEL_AVC_DECODE_SETTINGS
// default number of reference frame