summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteve Kondik <steve@cyngn.com>2016-03-10 18:19:17 -0800
committerSteve Kondik <steve@cyngn.com>2016-03-10 18:19:17 -0800
commitd52d625faa1abe72f25d1699361b69c079b1eb96 (patch)
treef21d903e1a208b4467e26d13faf2b580ca13386a
parent04c1a6e545336540689b5700291fa7f521a769de (diff)
parent82462cd0a0d7fa58d5497c39534380ad3987fdd1 (diff)
downloadandroid_frameworks_volley-stable/cm-13.0-ZNH2KB.tar.gz
android_frameworks_volley-stable/cm-13.0-ZNH2KB.tar.bz2
android_frameworks_volley-stable/cm-13.0-ZNH2KB.zip
Android 6.0.1 release 22
-rw-r--r--src/main/java/com/android/volley/toolbox/ImageRequest.java22
-rw-r--r--src/test/java/com/android/volley/toolbox/ImageRequestTest.java4
2 files changed, 15 insertions, 11 deletions
diff --git a/src/main/java/com/android/volley/toolbox/ImageRequest.java b/src/main/java/com/android/volley/toolbox/ImageRequest.java
index 27c1fe2..d663f5f 100644
--- a/src/main/java/com/android/volley/toolbox/ImageRequest.java
+++ b/src/main/java/com/android/volley/toolbox/ImageRequest.java
@@ -16,6 +16,11 @@
package com.android.volley.toolbox;
+import android.graphics.Bitmap;
+import android.graphics.Bitmap.Config;
+import android.graphics.BitmapFactory;
+import android.widget.ImageView.ScaleType;
+
import com.android.volley.DefaultRetryPolicy;
import com.android.volley.NetworkResponse;
import com.android.volley.ParseError;
@@ -23,24 +28,19 @@ import com.android.volley.Request;
import com.android.volley.Response;
import com.android.volley.VolleyLog;
-import android.graphics.Bitmap;
-import android.graphics.Bitmap.Config;
-import android.graphics.BitmapFactory;
-import android.widget.ImageView.ScaleType;
-
/**
* A canned request for getting an image at a given URL and calling
* back with a decoded Bitmap.
*/
public class ImageRequest extends Request<Bitmap> {
/** Socket timeout in milliseconds for image requests */
- private static final int IMAGE_TIMEOUT_MS = 1000;
+ public static final int DEFAULT_IMAGE_TIMEOUT_MS = 1000;
/** Default number of retries for image requests */
- private static final int IMAGE_MAX_RETRIES = 2;
+ public static final int DEFAULT_IMAGE_MAX_RETRIES = 2;
/** Default backoff multiplier for image requests */
- private static final float IMAGE_BACKOFF_MULT = 2f;
+ public static final float DEFAULT_IMAGE_BACKOFF_MULT = 2f;
private final Response.Listener<Bitmap> mListener;
private final Config mDecodeConfig;
@@ -71,9 +71,9 @@ public class ImageRequest extends Request<Bitmap> {
*/
public ImageRequest(String url, Response.Listener<Bitmap> listener, int maxWidth, int maxHeight,
ScaleType scaleType, Config decodeConfig, Response.ErrorListener errorListener) {
- super(Method.GET, url, errorListener);
- setRetryPolicy(
- new DefaultRetryPolicy(IMAGE_TIMEOUT_MS, IMAGE_MAX_RETRIES, IMAGE_BACKOFF_MULT));
+ super(Method.GET, url, errorListener);
+ setRetryPolicy(new DefaultRetryPolicy(DEFAULT_IMAGE_TIMEOUT_MS, DEFAULT_IMAGE_MAX_RETRIES,
+ DEFAULT_IMAGE_BACKOFF_MULT));
mListener = listener;
mDecodeConfig = decodeConfig;
mMaxWidth = maxWidth;
diff --git a/src/test/java/com/android/volley/toolbox/ImageRequestTest.java b/src/test/java/com/android/volley/toolbox/ImageRequestTest.java
index 0ae774e..7154d01 100644
--- a/src/test/java/com/android/volley/toolbox/ImageRequestTest.java
+++ b/src/test/java/com/android/volley/toolbox/ImageRequestTest.java
@@ -22,6 +22,7 @@ import android.widget.ImageView;
import android.widget.ImageView.ScaleType;
import com.android.volley.NetworkResponse;
import com.android.volley.Response;
+
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.RobolectricTestRunner;
@@ -168,5 +169,8 @@ public class ImageRequestTest {
assertNotNull(ImageRequest.class.getConstructor(String.class, Response.Listener.class,
int.class, int.class, ImageView.ScaleType.class, Bitmap.Config.class,
Response.ErrorListener.class));
+ assertEquals(ImageRequest.DEFAULT_IMAGE_TIMEOUT_MS, 1000);
+ assertEquals(ImageRequest.DEFAULT_IMAGE_MAX_RETRIES, 2);
+ assertEquals(ImageRequest.DEFAULT_IMAGE_BACKOFF_MULT, 2f);
}
}