aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorfionaxu <fionaxu@google.com>2016-06-20 19:11:57 -0700
committerThe Android Automerger <android-build@android.com>2016-06-24 16:58:17 -0700
commitf47bc301ccbc5e6d8110afab5a1e9bac1d4ef058 (patch)
tree2269fe3961180d8c4c0b60529dc9b68fd27b25d3
parentc078223146c667cea03b090444efee76ce1a8ec0 (diff)
downloadandroid_frameworks_opt_telephony-f47bc301ccbc5e6d8110afab5a1e9bac1d4ef058.tar.gz
android_frameworks_opt_telephony-f47bc301ccbc5e6d8110afab5a1e9bac1d4ef058.tar.bz2
android_frameworks_opt_telephony-f47bc301ccbc5e6d8110afab5a1e9bac1d4ef058.zip
backport security fix: avoid set NITZ time to 2038
Bug: 29083635 Change-Id: I21c5f4147d8146f92b7e33f0967a179ae644a263
-rw-r--r--src/java/com/android/internal/telephony/cdma/CdmaServiceStateTracker.java6
-rwxr-xr-xsrc/java/com/android/internal/telephony/gsm/GsmServiceStateTracker.java6
2 files changed, 12 insertions, 0 deletions
diff --git a/src/java/com/android/internal/telephony/cdma/CdmaServiceStateTracker.java b/src/java/com/android/internal/telephony/cdma/CdmaServiceStateTracker.java
index e6b0867ab..85980e99c 100644
--- a/src/java/com/android/internal/telephony/cdma/CdmaServiceStateTracker.java
+++ b/src/java/com/android/internal/telephony/cdma/CdmaServiceStateTracker.java
@@ -101,6 +101,8 @@ public class CdmaServiceStateTracker extends ServiceStateTracker {
private static final int NITZ_UPDATE_DIFF_DEFAULT = 2000;
private int mNitzUpdateDiff = SystemProperties.getInt("ro.nitz_update_diff",
NITZ_UPDATE_DIFF_DEFAULT);
+ /** Time stamp after 19 January 2038 is not supported under 32 bit */
+ private static final int MAX_NITZ_YEAR = 2037;
private int mRoamingIndicator;
private boolean mIsInPrl;
@@ -1614,6 +1616,10 @@ public class CdmaServiceStateTracker extends ServiceStateTracker {
String[] nitzSubs = nitz.split("[/:,+-]");
int year = 2000 + Integer.parseInt(nitzSubs[0]);
+ if (year > MAX_NITZ_YEAR) {
+ if (DBG) loge("NITZ year: " + year + " exceeds limit, skip NITZ time update");
+ return;
+ }
c.set(Calendar.YEAR, year);
// month is 0 based!
diff --git a/src/java/com/android/internal/telephony/gsm/GsmServiceStateTracker.java b/src/java/com/android/internal/telephony/gsm/GsmServiceStateTracker.java
index 8d3a84d41..03fbd7f76 100755
--- a/src/java/com/android/internal/telephony/gsm/GsmServiceStateTracker.java
+++ b/src/java/com/android/internal/telephony/gsm/GsmServiceStateTracker.java
@@ -136,6 +136,8 @@ final class GsmServiceStateTracker extends ServiceStateTracker {
/** Boolean is true is setTimeFromNITZString was called */
private boolean mNitzUpdatedTime = false;
+ /** Time stamp after 19 January 2038 is not supported under 32 bit */
+ private static final int MAX_NITZ_YEAR = 2037;
String mSavedTimeZone;
long mSavedTime;
@@ -1739,6 +1741,10 @@ final class GsmServiceStateTracker extends ServiceStateTracker {
String[] nitzSubs = nitz.split("[/:,+-]");
int year = 2000 + Integer.parseInt(nitzSubs[0]);
+ if (year > MAX_NITZ_YEAR) {
+ if (DBG) loge("NITZ year: " + year + " exceeds limit, skip NITZ time update");
+ return;
+ }
c.set(Calendar.YEAR, year);
// month is 0 based!