diff options
| author | Alec Mouri <alecmouri@google.com> | 2019-04-30 18:24:05 -0700 |
|---|---|---|
| committer | Alec Mouri <alecmouri@google.com> | 2019-05-06 17:55:25 -0700 |
| commit | 485e4c358b26f09ec0634e63c311131c9507779a (patch) | |
| tree | 08a623a6f2942a359a5a785290b7f7c4a7e00e70 /libs/gui/include | |
| parent | e6f6a7c4d74c967c4ea38f2f6b7c68f9260c952c (diff) | |
| download | android_frameworks_native-485e4c358b26f09ec0634e63c311131c9507779a.tar.gz android_frameworks_native-485e4c358b26f09ec0634e63c311131c9507779a.tar.bz2 android_frameworks_native-485e4c358b26f09ec0634e63c311131c9507779a.zip | |
Clean-up egl image preallocation
Allocate EGL images in onFrameAvailable, instead of a custom
onBuffersAllocated callback. This way we reduce traffic over binder
while still performing GL work ahead of time in queueBuffer().
Bug: 130567928
Test: systrace
Change-Id: I4070e9ddbd379dac3d809d0e7edb2855fc8b7a80
Diffstat (limited to 'libs/gui/include')
| -rw-r--r-- | libs/gui/include/gui/BufferQueue.h | 1 | ||||
| -rw-r--r-- | libs/gui/include/gui/ConsumerBase.h | 1 | ||||
| -rw-r--r-- | libs/gui/include/gui/IConsumerListener.h | 7 |
3 files changed, 0 insertions, 9 deletions
diff --git a/libs/gui/include/gui/BufferQueue.h b/libs/gui/include/gui/BufferQueue.h index 721427be7..da952744f 100644 --- a/libs/gui/include/gui/BufferQueue.h +++ b/libs/gui/include/gui/BufferQueue.h @@ -61,7 +61,6 @@ public: void onDisconnect() override; void onFrameAvailable(const BufferItem& item) override; void onFrameReplaced(const BufferItem& item) override; - void onBufferAllocated(const BufferItem& item) override; void onBuffersReleased() override; void onSidebandStreamChanged() override; void addAndGetFrameTimestamps( diff --git a/libs/gui/include/gui/ConsumerBase.h b/libs/gui/include/gui/ConsumerBase.h index 7c2648250..366ced380 100644 --- a/libs/gui/include/gui/ConsumerBase.h +++ b/libs/gui/include/gui/ConsumerBase.h @@ -141,7 +141,6 @@ protected: // classes if they want the notification. virtual void onFrameAvailable(const BufferItem& item) override; virtual void onFrameReplaced(const BufferItem& item) override; - virtual void onBufferAllocated(const BufferItem& item) override; virtual void onBuffersReleased() override; virtual void onSidebandStreamChanged() override; diff --git a/libs/gui/include/gui/IConsumerListener.h b/libs/gui/include/gui/IConsumerListener.h index 03fefbe90..c0828820e 100644 --- a/libs/gui/include/gui/IConsumerListener.h +++ b/libs/gui/include/gui/IConsumerListener.h @@ -61,13 +61,6 @@ public: // This is called without any lock held and can be called concurrently by multiple threads. virtual void onFrameReplaced(const BufferItem& /* item */) {} /* Asynchronous */ - // onBufferAllocated is called to notify the buffer consumer that the BufferQueue has allocated - // a GraphicBuffer for a particular slot. Only the GraphicBuffer pointer and the slot ID will - // be populated. - // - // This is called without any lock held and can be called concurrently by multiple threads. - virtual void onBufferAllocated(const BufferItem& /* item */) {} /* Asynchronous */ - // onBuffersReleased is called to notify the buffer consumer that the BufferQueue has released // its references to one or more GraphicBuffers contained in its slots. The buffer consumer // should then call BufferQueue::getReleasedBuffers to retrieve the list of buffers. |