aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorElliott Hughes <enh@google.com>2016-05-10 15:03:41 -0700
committerElliott Hughes <enh@google.com>2016-05-10 15:03:41 -0700
commit498e61d5a4361d4a225947386ac8150292dcc466 (patch)
tree6ca6b5bca6089b2d993c16f482ae85f3ab65d8f5
parentd9417c06308cf9dd34941ca338ac31a9df54b42a (diff)
parent4e756d7f9fd1b32b545ce8c43120dc733653b52f (diff)
downloadandroid_external_toybox-498e61d5a4361d4a225947386ac8150292dcc466.tar.gz
android_external_toybox-498e61d5a4361d4a225947386ac8150292dcc466.tar.bz2
android_external_toybox-498e61d5a4361d4a225947386ac8150292dcc466.zip
Merge remote-tracking branch 'toybox/master' into HEAD
-rw-r--r--main.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/main.c b/main.c
index 9c70c961..eeae2f39 100644
--- a/main.c
+++ b/main.c
@@ -137,8 +137,11 @@ void toy_exec(char *argv[])
if (!(which = toy_find(*argv))) return;
// Return if stack depth getting noticeable (proxy for leaked heap, etc).
- if (toys.stacktop && labs((char *)toys.stacktop-(char *)&which)>6000)
- return;
+
+ // Compiler writers have decided subtracting char * is undefined behavior,
+ // so convert to integers. (LP64 says sizeof(long)==sizeof(pointer).)
+ if (!CFG_TOYBOX_NORECURSE)
+ if (toys.stacktop && labs((long)toys.stacktop-(long)&which)>6000) return;
// Return if we need to re-exec to acquire root via suid bit.
if (toys.which && (which->flags&TOYFLAG_ROOTONLY) && toys.wasroot) return;