diff options
| author | scroggo <scroggo@google.com> | 2015-04-07 06:41:22 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-07 06:41:22 -0700 |
| commit | fde1c85696656e5ccaa938114751e3f6bab6a90f (patch) | |
| tree | 628c45bd8682760fb6743f212c60ed0ee347392a /site | |
| parent | e35268ef4cdaa29600671cdf9d0ebb43b622d1a3 (diff) | |
| download | android_external_skia-fde1c85696656e5ccaa938114751e3f6bab6a90f.tar.gz android_external_skia-fde1c85696656e5ccaa938114751e3f6bab6a90f.tar.bz2 android_external_skia-fde1c85696656e5ccaa938114751e3f6bab6a90f.zip | |
Add sheriff documentation for rebaselining.
Copied from notes Robert emailed me.
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1051653006
Review URL: https://codereview.chromium.org/1051653006
Diffstat (limited to 'site')
| -rw-r--r-- | site/dev/sheriffing/index.md | 29 |
1 files changed, 29 insertions, 0 deletions
diff --git a/site/dev/sheriffing/index.md b/site/dev/sheriffing/index.md index 59f496d949..9c49dd7b22 100644 --- a/site/dev/sheriffing/index.md +++ b/site/dev/sheriffing/index.md @@ -16,6 +16,7 @@ Tree Sheriffs Documentation + [Compile bot failures automatically close the tree](#tree_closers) + [How to revert a CL](#how_to_revert) + [What to do if DEPS roll fails to land](#deps_roll_failures) + + [How to rebaseline](#how_to_rebaseline) <a name="what_is_a_sheriff"></a> @@ -112,3 +113,31 @@ See the revert documentation [here](https://skia.org/dev/contrib/revert). ### What to do if DEPS roll fails to land A common cause of DEPS roll failures are layout tests. Find the offending Skia CL by examining the commit hash range in the DEPS roll and revert (or talk to the commit author if they are available). If you do revert then keep an eye on the next DEPS roll to make sure it succeeds. + +If a Skia CL changes layout tests, but the new images look good, the tests need to be rebaselined. See [Rebaseline Layout Tests](#how_to_rebaseline). + +<a name="how_to_rebaseline"</a> +### Rebaseline Layout Tests (i.e., add suppressions) + +* First create a Chromium bug: + * goto [crbug.com](https://crbug.com) + * Make sure you’re logged in with your Chromium credentials + * Click “New Issue” + * Summary: “Skia image rebaseline” + * Description: + * DEPS roll #, + * Helpful message about what went wrong (e.g., “Changes to how lighting is scaled in Skia r#### changed the following images:”) + * Layout tests effected + * You should copy the list of affected from stdio of the failing bot + * Status: Assigned + * Owner: fmalita@ + * cc: reed@, bsalomon@, robertphillips@ & developer responsible for changes + * Labels: OS-All & Cr-Blink-LayoutTests + * If it is filter related, cc senorblanco@ + +* Edit [skia/skia_test_expectations.txt](https://chromium.googlesource.com/chromium/src/+/master/skia/skia_test_expectations.txt) + * Add # comment about what has changed (I usually paraphrase the crbug text) + * Add line(s) like after the comment: + * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ ImageOnlyFailure ] + +* Commit the changes and fire off new try bots (you usually only need to fire off the layout bots) |