Edges matter, part 2.

Affected modes: lighten, hard-light, overlay (== hard-light).
This fixes a couple places where I used < when I should have used <=,
or swapped the logic as I've done here.

Caught by layout tests; our tests should be unchanged.
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/68935/layout-test-results/css3/blending/background-blend-mode-crossfade-image-gradient-diffs.html

BUG=skia:

Review URL: https://codereview.chromium.org/1217013003

1 files changed, 5 insertions, 5 deletions

diff --git a/src/core/Sk4pxXfermode.h b/src/core/Sk4pxXfermode.h
index 09490dc990..f2f2d6682f 100644
--- a/src/core/Sk4pxXfermode.h
+++ b/src/core/Sk4pxXfermode.h
@@ -66,15 +66,15 @@ XFERMODE(HardLight) {
     auto sa = s.alphas(),
          da = d.alphas();
 
-    auto isDark = s < (sa-s);
+    auto isLite = (sa-s) < s;
 
     auto dark = s*d << 1,
          lite = sa*da - ((da-d)*(sa-s) << 1),
          both = s*da.inv() + d*sa.inv();
 
-    // TODO: do isDark in 16-bit so we only have to div255() once.
-    auto colors = isDark.thenElse((dark + both).div255(),
-                                  (lite + both).div255());
+    // TODO: do isLite in 16-bit so we only have to div255() once.
+    auto colors = isLite.thenElse((lite + both).div255(),
+                                  (dark + both).div255());
     return alphas.zeroColors() + colors.zeroAlphas();
 }
 XFERMODE(Overlay) { return HardLight::Xfer(d,s); }
@@ -94,7 +94,7 @@ XFERMODE(Lighten) {
     auto srcover = s + (d - dsa),
          dstover = d + (s - sda);
     auto alphas = srcover,
-         colors = (sda < dsa).thenElse(dstover, srcover);
+         colors = (dsa < sda).thenElse(srcover, dstover);
     return alphas.zeroColors() + colors.zeroAlphas();
 }