aboutsummaryrefslogtreecommitdiffstats
path: root/libselinux/src/booleans.c
diff options
context:
space:
mode:
authorWilliam Roberts <william.c.roberts@intel.com>2016-09-23 11:02:53 -0700
committerStephen Smalley <sds@tycho.nsa.gov>2016-09-23 14:51:48 -0400
commitd88597798fdb1a2b344ca47e48f2f80ad433fd95 (patch)
treefeb4ea4cf33c7e7f3b23ff138c6bfb99a2cc17f8 /libselinux/src/booleans.c
parent42be018d2e829e47f0dacf58ad1fb2e03f2bd498 (diff)
downloadandroid_external_selinux-d88597798fdb1a2b344ca47e48f2f80ad433fd95.tar.gz
android_external_selinux-d88597798fdb1a2b344ca47e48f2f80ad433fd95.tar.bz2
android_external_selinux-d88597798fdb1a2b344ca47e48f2f80ad433fd95.zip
libselinux: drop usage of _D_ALLOC_NAMLEN
_D_ALLOC_NAMLEN is not very portable. Currently, the code mallocs based on _D_ALLOC_NAMLEN() and then strcpy's dirent d_name into the buffer. Instead, just use strdup. Change-Id: I5c8ca47da2c593ea2726caba5781f5e9d9d910ae Signed-off-by: William Roberts <william.c.roberts@intel.com>
Diffstat (limited to 'libselinux/src/booleans.c')
-rw-r--r--libselinux/src/booleans.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/libselinux/src/booleans.c b/libselinux/src/booleans.c
index 4b39a28c..c438af18 100644
--- a/libselinux/src/booleans.c
+++ b/libselinux/src/booleans.c
@@ -63,12 +63,11 @@ int security_get_boolean_names(char ***names, int *len)
}
for (i = 0; i < *len; i++) {
- n[i] = (char *)malloc(_D_ALLOC_NAMLEN(namelist[i]));
+ n[i] = strdup(namelist[i]->d_name);
if (!n[i]) {
rc = -1;
goto bad_freen;
}
- strcpy(n[i], namelist[i]->d_name);
}
rc = 0;
*names = n;