aboutsummaryrefslogtreecommitdiffstats
path: root/socket.c
diff options
context:
space:
mode:
authorMartin Pool <mbp@samba.org>2002-03-16 08:23:08 +0000
committerMartin Pool <mbp@samba.org>2002-03-16 08:23:08 +0000
commite23d790fa73c6c615a81e16d21a7f7684922253c (patch)
tree7c314d980e490c672e7dada4c9984f803146cd5e /socket.c
parent2a5904a580ad3a10a43214e06846f086d8f7479e (diff)
downloadandroid_external_rsync-e23d790fa73c6c615a81e16d21a7f7684922253c.tar.gz
android_external_rsync-e23d790fa73c6c615a81e16d21a7f7684922253c.tar.bz2
android_external_rsync-e23d790fa73c6c615a81e16d21a7f7684922253c.zip
Doc: Note from Dave Dykstra that getaddrinfo calls must be paired with
freeaddrinfo().
Diffstat (limited to 'socket.c')
-rw-r--r--socket.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/socket.c b/socket.c
index ccc79cfe..acf6234b 100644
--- a/socket.c
+++ b/socket.c
@@ -119,6 +119,8 @@ int try_bind_local(int s,
return -1;
}
+ /* FIXME: Call freeaddrinfo() on all return paths! */
+
for (r = bres_all; r; r = r->ai_next) {
if (bind(s, r->ai_addr, r->ai_addrlen) == -1)
continue;
@@ -329,7 +331,8 @@ static int open_socket_in(int type, int port, const char *bind_address,
close(s);
continue;
}
-
+
+ /* FIXME: Call freeaddrinfo? */
return s;
}