diff options
| author | Thomas Graf <tgr@lsx.localdomain> | 2008-05-14 17:49:44 +0200 |
|---|---|---|
| committer | Thomas Graf <tgr@lsx.localdomain> | 2008-05-14 17:49:44 +0200 |
| commit | 8a3efffa5b3fde252675239914118664d36a2c24 (patch) | |
| tree | f8efc71b2bd4736f2a56084efea05d7ee191a422 /include/netlink/route/neightbl.h | |
| parent | 85f932552e61c5997c1e83fe386098c94d93c273 (diff) | |
| download | android_external_libnl-8a3efffa5b3fde252675239914118664d36a2c24.tar.gz android_external_libnl-8a3efffa5b3fde252675239914118664d36a2c24.tar.bz2 android_external_libnl-8a3efffa5b3fde252675239914118664d36a2c24.zip | |
Thread-safe error handling
In order for the interface to become more thread safe, the error
handling was revised to no longer depend on a static errno and
error string buffer.
This patch converts all error paths to return a libnl specific
error code which can be translated to a error message using
nl_geterror(int error). The functions nl_error() and
nl_get_errno() are therefore obsolete.
This change required various sets of function prototypes to be
changed in order to return an error code, the most prominent
are:
struct nl_cache *foo_alloc_cache(...);
changed to:
int foo_alloc_cache(..., struct nl_cache **);
struct nl_msg *foo_build_request(...);
changed to:
int foo_build_request(..., struct nl_msg **);
struct foo *foo_parse(...);
changed to:
int foo_parse(..., struct foo **);
This pretty much only leaves trivial allocation functions to
still return a pointer object which can still return NULL to
signal out of memory.
This change is a serious API and ABI breaker, sorry!
Diffstat (limited to 'include/netlink/route/neightbl.h')
| -rw-r--r-- | include/netlink/route/neightbl.h | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/include/netlink/route/neightbl.h b/include/netlink/route/neightbl.h index 20285ee..7120053 100644 --- a/include/netlink/route/neightbl.h +++ b/include/netlink/route/neightbl.h @@ -6,7 +6,7 @@ * License as published by the Free Software Foundation version 2.1 * of the License. * - * Copyright (c) 2003-2006 Thomas Graf <tgraf@suug.ch> + * Copyright (c) 2003-2008 Thomas Graf <tgraf@suug.ch> */ #ifndef NETLINK_NEIGHTBL_H_ @@ -25,14 +25,15 @@ struct rtnl_neightbl; extern struct rtnl_neightbl *rtnl_neightbl_alloc(void); extern void rtnl_neightbl_put(struct rtnl_neightbl *); extern void rtnl_neightbl_free(struct rtnl_neightbl *); -extern struct nl_cache *rtnl_neightbl_alloc_cache(struct nl_handle *); +extern int rtnl_neightbl_alloc_cache(struct nl_handle *, struct nl_cache **); extern struct rtnl_neightbl *rtnl_neightbl_get(struct nl_cache *, const char *, int); extern void rtnl_neightbl_dump(struct rtnl_neightbl *, FILE *, struct nl_dump_params *); -extern struct nl_msg *rtnl_neightbl_build_change_request(struct rtnl_neightbl *, - struct rtnl_neightbl *); +extern int rtnl_neightbl_build_change_request(struct rtnl_neightbl *, + struct rtnl_neightbl *, + struct nl_msg **); extern int rtnl_neightbl_change(struct nl_handle *, struct rtnl_neightbl *, struct rtnl_neightbl *); |